Helix SwarmHelix Swarm
Loading...

tom_tyler

tom_tyler (C. Thomas Tyler)
  • 9
    Followers
  • 0
    Following
  • 34
    Projects
Full Name
C. Thomas Tyler
Email address
ttyler@perforce.com
Followers
adarshnsz11
afuentes (afuentes)alan_petersen (alan_petersen)
andersonffx2
aurest (aurest)
cgeen (cgeen)distroronie (distroronie)kpark (Kevin Park)phopkins (phopkins)
Projects
  • Admin toolkit
    • Owner, Following
  • AutoMerge
    • Owner, Member
  • Azure-Quickstart-Template
    • Owner, Member
  • Battle School Workshop
    • Owner, Member
  • Helix Installer
    • Owner, Member
  • P4Training
    • Owner, Member
  • P4Transfer
    • Owner, Member
  • PDS
    • Owner
  • SDP
    • Owner, Member
  • SDP-Cloud-Deploy
    • Owner
  • ffr-reseed
    • Owner, Member
  • helix-failover
    • Owner, Member
  • hms
    • Owner, Member
  • log_analyzer
    • Owner, Member
  • p4bbi
    • Owner, Member
  • tom_test_proj_2017-01-19_1
    • Owner, Member
  • wfv-tidy
    • Owner, Member
  • CBD
    • Member
  • Helix Installer
    • Member
  • P4DTG-SDK
    • Member
  • P4Perl
    • Member
  • PDS
    • Member
  • Stuff Tom Follows
    • Member
  • VDSL
    • Member
  • VTFS2P4
    • Member
  • cic
    • Member
  • mktask
    • Member
  • p4ms
    • Member
  • Hive
    • Following
  • P4
    • Following
  • P4Flex
    • Following
  • P4Nagios
    • Following
  • Workshop
    • Following
  • jam
    • Following
  • Activity
  • Shelves
  • Settings
  • Notifications

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
4 minutes agoC. Thomas Tyler committed change 31365 into perforce-software-sdp:dev
Commented out broken test.
Add a comment
about an hour agoC. Thomas Tyler committed change 31363 into perforce-software-sdp:dev
In verify_sdp.sh, added checks to ensure defined P4USER exists, is
a super, and has a long-term ticket.  If the users does not exist
or does not... have super access, and error is generated. If the ticket
duration is too short, a warning is given. «
Add a comment
about 3 hours agoC. Thomas Tyler committed change 31362 into perforce-software-sdp:dev
Fixed issue where using mkdirs.sh to add a new instance to a machine
overwrites the crontab for the first instance.

Fixes SDP-1218.
Add a comment
about 4 hours agoC. Thomas Tyler committed change 31361 into perforce-software-sdp:dev
Completed change start in @31360.
Add a comment
about 4 hours agoC. Thomas Tyler committed change 31360 into perforce-software-sdp:dev
Enhanced and corrected docs for '-local' mode.
Fixes SDP-1193.

Various other doc corrections and spelling fixes, thanks to
apsell.
Add a comment
about 8 hours agoC. Thomas Tyler committed change 31359 into perforce-software-sdp:dev
Adapated fix for HI-139 into SDP-ported perforce_bashrc.
Enhanced detail in comments about shopt setting.
Add a comment
about 8 hours agoC. Thomas Tyler committed change 31358 into perforce-software-sdp:dev
Removed obsolete reference to discontinued product.
Brought bat script in alignment with bash script for P4AUDIT settings.
Added info in comments re:... P4AUDIT not being enabled by default. «
Add a comment
about 8 hours agoC. Thomas Tyler committed change 31357 into perforce-software-sdp:dev
Refined guidance in configure_new_server.{bat,sh} to align with ccheck.sh.
Add a comment
about 9 hours agoC. Thomas Tyler committed change 31355 into perforce-software-sdp:dev
Added '-v server=1 -v track=1' to PROXY_V_FLAGS.
Add a comment
about 9 hours agoC. Thomas Tyler committed change 31354 into perforce-software-sdp:dev
Fixed to avoid actually loading crontab in '-test' mode.

Fixes SDP-1209.
Add a comment
about 10 hours agoC. Thomas Tyler committed change 31353 into perforce-software-sdp:dev
Removed cruft files.
Add a comment
about 10 hours agoC. Thomas Tyler committed change 31352 into perforce-software-sdp:tools
Enhanced preview output.
Add a comment
about 11 hours agoC. Thomas Tyler committed change 31350 into perforce-software-sdp:dev
Refine cchech.sh and config file to allow specification of 'Unset'
to be required, in which case we pass the check if the value is
unset regardless o...f the default value.

We already allow checking the default value and consider it to comply
if the default value matches expected. This new change will support
some values being defined as required to be unset.

Add examples and descriptive text in configurables.cfg.

Fix ShellCheck compliance issues.

Changed '-v' so required values having expected values show as GREAT
rather than GOOD.  Recommended values having expected values still
show as GOOD.  For values *not* matching expectations, required values
show as BAD, while recommended values now show as WARN.

The word FAIL is now used only in the summary, and appears only if
there are any BAD indications (required values not matching) or else
any system errors checking configurables. «
Add a comment
4 days agoC. Thomas Tyler committed change 31346 into
Added Windows batch shell script to push change-by-change.
Add a comment
9 days agoC. Thomas Tyler committed change 31344 into perforce-software-sdp:dev
Added default P4ALIASES for perforce OS user to SDP.
Add a comment
11 days agoC. Thomas Tyler committed change 31341 into p4ms:main
Promoted files for referencing in URLs.
Add a comment
11 days agoC. Thomas Tyler committed change 31340 into
First pass at refactoring & rebranding.
Add a comment
11 days agoC. Thomas Tyler committed change 31339 into
Bootstrapped sample files.
Add a comment
11 days agoC. Thomas Tyler committed change 31338 into p4ms:main
Bootstrap files promoted to main so the project home page link works.
Add a comment
11 days agoC. Thomas Tyler committed change 31337 into
First crack at rebranding change.
WIP.
Add a comment
11 days agoC. Thomas Tyler committed change 31336 into
Bootstrapped P4MS.
Add a comment
11 days agoC. Thomas Tyler committed change 31335 into perforce_software-hms:dev
Updated Copyright to 2025.
Add a comment
11 days agoC. Thomas Tyler created project (p4ms)
12 days agoC. Thomas Tyler committed change 31329 into perforce-software-sdp:dev
Added summary of errors and warnings at the end.
This summary is displayed
by default. A '-skip_summary' option has been added to suppress the summary....

Added checks for existence of statepullL and statefailover files in P4ROOT
on p4d servers.  A warning is reported if these files exist, advising the
user to remove these failover remnant files.

Addressed some issues reported by shellcheck.

#review @robert_cowham «
Add a comment
18 days agoC. Thomas Tyler committed change 31325 into perforce-software-sdp:dev
Minor doc tweaks to add more detail on sync_replica.sh and
keep_offline_db_current.sh.
Add a comment
25 days agoC. Thomas Tyler committed change 31317 into perforce-software-sdp:dev
Tweaked set of tables to be used for edge servers to work for recovery with
modern SDP on a pre-2019.1 data set.  The CheckpointTables variable a...ppends
db.storage only if the p4d version is new enough to use db.storage. «
Add a comment
28 days agoC. Thomas Tyler committed change 31314 into perforce-software-sdp:dev
Added P4IGNORE entries useful clients associated with the //sdp/dev_insitu
stream rooted at /p4.
Add a comment
about a month agoC. Thomas Tyler committed change 31311 into perforce-software-sdp:dev
Updated run_if_*.sh scripts:
* Fixed bug in run_if_broker.sh.
* Normalized command line verification.
* Removed 'set -e' from run_if_*.sh scripts to... improve reliability.
* Made ShellCheck compliant. «
Add a comment
about a month agoC. Thomas Tyler committed change 31308 into
Added information about supported platforms.
Tweaked sample output to show hostname matching actual/expected name.
Add a comment
about a month agoC. Thomas Tyler committed change 31306 into perforce-software-sdp:dev
Doc tweak; non-functional change.
Add a comment
about a month agoC. Thomas Tyler committed change 31302 into
Tweaked tests passed to be more current, adjusted time zone to match other place in doc.
Add a comment
about a month agoC. Thomas Tyler committed change 31285 into perforce-software-sdp:dev
Fix so MASTER_ID value written into mkdirs.N.cfg file is correct.
This fixes an issue where p4_N.vars files are generated with an
incorrect P4MASTER_...ID value.

With this change, passsing the ServerID from install_sdp.sh to
called mkdirs.sh will no longer require the '-s <ServerID>' nor
the '-t <ServerType>' command line options.

Also change text in generated config file to indicate that it is OK
to set the ServerID of a commit/master server if you have a desired
ServerID that is different from the SDP-default (currently master.N).

Adjusted terminology to prefer 'p4d_commit' over 'p4d_master', but
preserve p4d_master as a synonym for backward compatibility with older
config giles. «
Add a comment
2 months agoC. Thomas Tyler committed change 31228 into perforce-software-sdp:dev
Fixed 'p4login1' typo in docs.
Add a comment
2 months agoC. Thomas Tyler committed change 31227 into
Corrected default time zone.
Add a comment
2 months agoC. Thomas Tyler committed change 31226 into
Added notes about setting host and time zone.
Add a comment
2 months agoC. Thomas Tyler committed change 31213 into perforce-software-sdp:dev
Fixed test suite issue with CLI tests formatted as p4@PORT@USER@CLIENT.
Add a comment
2 months agoC. Thomas Tyler committed change 31212 into perforce-software-sdp:dev
Corrected format of a test entry.
Add a comment
2 months agoC. Thomas Tyler committed change 31210 into perforce-software-sdp:dev
Fixed issue with case-sensitivty of server spec name in
configurable values. For example, if the server spec name
is p4d_edge_SITEX and is case-insen...sitive, the configurables
displayed with p4d -cshow can look like P4D_EDGE_sitex and
still be valid.

An example of an issue this fixes that an edge server being
migrated from Windows to Linux could have the run_if_edge.sh
script fail to determine that the server is an edge server;
a daily_checkpoint.sh would run fine interactively but would
fail to execute from the crontab, due to the run_if_edge.sh
not detecting it was an edge. The situation that could cause
this would be that a ServerID could be p4d_edge_SYD but the
lbr.replication configurable could be set as
P4D_EDGE_SYD#lbr.replication=readonly «
Add a comment
2 months agoC. Thomas Tyler committed change 31208 into perforce-software-sdp:dev
Merged down hot patch to web docs only (no functional change).
Add a comment
2 months agoC. Thomas Tyler committed change 31207 into perforce-software-sdp:main
Web doc update only; tweaked versions.
Add a comment
2 months agoC. Thomas Tyler committed change 31185 into perforce-software-sdp:dev
Added more detailed information on The Site Directory (/p4/common/site).

Adapted Makefile to generate HTML from Markdown for this special case
where... the /p4/common/site/ReadMe.md file deployed with the SDP in a
runtime environment in the site folder generates an HTML elsewhere,
in the SDP doc folder.

Fixes SDP-722. «
Add a comment
2 months agoC. Thomas Tyler modified SDP-722 for
Document the usage of the /p4/common/site folder more fully.

This is referenced in the docs for the sdp_upgrade.sh script,
but needs for comprehensi...ve treatment in the SDP Guide. «
Add a comment
2 months agoC. Thomas Tyler modified SDP-722 for
Document the usage of the /p4/common/site folder more fully.

This is referenced in the docs for the sdp_upgrade.sh script,
but needs for comprehensi...ve treatment in the SDP Guide. «
Add a comment
2 months agoC. Thomas Tyler committed change 31183 into perforce-software-sdp:dev
Rel notes WIP.
Add a comment
2 months agoC. Thomas Tyler committed change 31180 into perforce-software-sdp:tools
Added util for developing SDP in BSW lab.
Add a comment
2 months agoC. Thomas Tyler committed change 31178 into perforce-software-sdp:dev
Tweaked error message in sdp_upgrade.sh; non-functional change.
Add a comment
2 months agoC. Thomas Tyler committed change 31177 into
Corrected product name in utility script.
Add a comment
2 months agoC. Thomas Tyler committed change 31176 into perforce_software-helix-installer:downloads
Packaged Helix Installer 2024.2.31173.
Add a comment
2 months agoC. Thomas Tyler committed change 31175 into perforce_software-helix-installer:main
Released SDP 2024.2.31173 (2025/01/15).
Copy Up using 'p4 copy -r -b perforce_software-helix-installer-dev'.
Add a comment
2 months agoC. Thomas Tyler committed change 31174 into perforce_software-helix-installer:dev
Updated Version and Release Notes for release.
Add a comment
Change User Description Created
31327 C. Thomas Tyler 2024.2 Patch 1 18 days ago Request Review
31326 C. Thomas Tyler 2024.2 Patch 2. 18 days ago Request Review
31097 C. Thomas Tyler Fixed bug where a case-insensitive server is sensitive to
the case of a server spec in th...e server.id file.  If the
instance is case-sensitive, then a grep for the ServerID
in dumped db.server output should also be case-insensitive.

An impact of this is that the run_if_*.sh scripts, e.g.
run_if_edge.sh, will not work if the case of the ServerID
in the $P4ROOT/server.id file doesn't match what shows in
'p4 servers'.  The case must match if the data set is case-
sensitive, but not if it is insensitive.

Without this code change in SDP, an easy workaround for this
issue is simply to make the case of the ServerID value in the
server.id file match what appears in the output of 'p4 servers'.

This bug may appear in a Windows to Linux migration.

Fixes SDP-1184. «		 3 months ago Request Review
31078 C. Thomas Tyler Modernized. 3 months ago Request Review
31038 C. Thomas Tyler Modifed scans in db.{config,server} to be case-insensitive if the data
set is case-insens...itive. «		 3 months ago Request Review
30842 C. Thomas Tyler Semantically separated DoParallelCheckpionts into two variables,
CreateParallelCheckpoint... and LoadParallelCheckpoint, which are
logicall independent. «		 4 months ago Request Review
30781 C. Thomas Tyler Added files from Helix Installer pacakge into SDP.
* Added firewalld templates to SDP.
*... Added sudoers template.
* Added bash shell templates.

Added new script 'install_sdp.sh', a distilled version of the reset_sdp.sh script,
without any 'reset' logic. «		 10 months ago Request Review
30766 C. Thomas Tyler Added files from Helix Installer pacakge into SDP.
* Added firewalld templates to SDP.
*... Added sudoers template.
* Added bash shell templates.

Added new script 'install_sdp.sh', a distilled version of the reset_sdp.sh script,
without any 'reset' logic. «		 10 months ago Request Review
30713 C. Thomas Tyler Added files from Helix Installer pacakge into SDP.
* Added firewalld templates to SDP.
*... Added sudoers template.
* Added bash shell templates.

Added new script 'install_sdp.sh', a distilled version of the reset_sdp.sh script,
without any 'reset' logic. «		 10 months ago Request Review
30709 C. Thomas Tyler Added files from Helix Installer pacakge into SDP.
* Added firewalld templates to SDP.
*... Added sudoers template.
* Added bash shell templates.

Added new script 'install_sdp.sh', a distilled version of the reset_sdp.sh script,
without any 'reset' logic. «		 10 months ago Request Review
30690 C. Thomas Tyler Added files from Helix Installer pacakge into SDP.
* Added firewalld templates to SDP.
*... Added sudoers template.
* Added bash shell templates.

Added new script 'install_sdp.sh', a distilled version of the reset_sdp.sh script,
without any 'reset' logic. «		 10 months ago Request Review
30687 C. Thomas Tyler Local shelf to hold shelf @30360 changes from another workspace. 5 months ago Request Review
30588 C. Thomas Tyler Pending shelved change. 7 months ago Request Review
30472 C. Thomas Tyler WIP 8 months ago Request Review
30432 C. Thomas Tyler Added undocumented support for /opt/perforce/helix-sdp package directory.

#review-30435...

With this change, mkdirs.sh behavior is changed depending on the pre-existence of the
directory /opt/perforce/helix-sdp, the future package install location.  The
/opt/perforce/helix-sdp folder is not created by design, effectively making support
for the package structure a Tech Preview (i.e. Beta) feature.  This change provides
behaviors needed to support package installation that also dovetail with goals of
decoupling the /p4/common and /p4/sdp folders from NFS in NFS environments.

If the /opt/perforce/helix-sdp is created with proper permissions and user/group
ownersihp before mkdirs.sh is run, new behaviors apply.  The proper ownership
and permissions are:

/opt/perforce/helix-sdp - root:perforce, 775 perms. Allows perforce user
to manage subdirs, e.g. common, downloads, helix_binaries, p4/sdp.

/opt/perforce/helix-sdp/sdp - root:root, 755 perms. This is the immutable
area, an extract of the SDP tarball and no additional files. This root-managed
area is intended to be updated only by OS package upgrades, and cannot be
affected by the perforce user.

These folders in the structure are modifiable by the perforce user (owned by
perforce:perforce), and will contain generated files, symlinks,
and possibly even local custom files.

* /opt/perforce/helix-sdp/downloads, for unpacking SDP tarballs for upgrades.
* /opt/perforce/helix-sdp/helix_binaries, contains get_helix_binaries.sh, p4*.
* /opt/perforce/helix-sdp/p4/sdp - A copy of /opt/perforce/helix-sdp/sdp,
owned by perforce:perforce rather than root:root.

In this version, the following behaviour changes occur if /opt/perforce/helix-sdp
exists when this script is run:

* The /p4/sdp symlink points to /opt/perforce/helix-sdp/p4/sdp rather than
/hxdepots/sdp.
* The /p4/common symlink points to /opt/perforce/helix-sdp/p4/sdp/Server/Unix/p4/common
rather than /hxdepots/p4/common.

In this beta version, if run in an environment where those /p4/common and /p4/sdp
symlinks already exist, the symlinks are NOT changed even if /opt/perforce/helix-sdp
exists.

This is Phase 1 if a multi-phased release of this feature.  Phase 1 will support
only greenfield installations where /opt/perforce/helix-sdp is created externally
to this script. (Targeted for SDP 2024.1 Patch 1, July 2024)

In Phase 2, the /opt/perforce/helix-sdp will be created by this script in greenfield
installations with a documented '-pkg' option (if run as root), and sdp_upgrade.sh
will migrate to this structure if and only if /opt/perforce/helix-sdp exists. Targeted
for SDP 2024.1 Patch 2 (Summer 2024).

In Phase 3, this will be integrated into the OS package installation mechanism for
Rocky9+ and Ubuntu 22.04+, possibly others.  (Targeted for SDP 2025.1+.)

SDP-1069: Decouple /p4/common and /p4/sdp from NFS.

The above captures the initial plan.  See this wiki page with more updated information
as it evolves:
https://perforce.atlassian.net/wiki/spaces/PROS/pages/936542265/SDP-1069+Decouple+SDP+from+NFS «		 9 months ago View Review
30429 C. Thomas Tyler Precursor to package installation support; added /opt/perforce/sdp. 9 months ago Request Review
30361 C. Thomas Tyler Added support for /hxhostlocal volume for string SDP files. 10 months ago Request Review
30279 C. Thomas Tyler Enhanced recreate_offline_db_files() to always choose latest checkpoint   
with...out regard to whether it is a file (serial checkpiont) or a directory
(for parallel checkpoints). «		 11 months ago Request Review
30253 C. Thomas Tyler load_checkpoint.sh v2.11.0: 11 months ago Request Review
30250 C. Thomas Tyler wip 11 months ago Request Review
30090 C. Thomas Tyler mkdirs.sh v5.0.0:
* Added service initialization (systemd or SysV) by default if running a...s root.
* Added '-no_systemd' option to not use systemd.
* Added '-no_init' option to skip any/all service inititalization.
* THe '-no_init' is implied with '-test' (and with undo '-R' option).
* Added SELinux handling for services installed with systemd.

#review-30316 @robert_cowham @mark_zinthefer @will_kreitzmann «		 about a year ago View Review
30026 C. Thomas Tyler Enhanced upgrade.sh to better prepar for a rollback, adding
docs and skipping replay of t...he rotated journal to the offline_db
for the second journal rotation in a major version upgrade.

#review-30027 «		 about a year ago View Review
29905 C. Thomas Tyler Contributed changes to snapshot.sh:
* Added /hxlogs to list of snapshooted volumes.
* Ad...ded explicit output formatting (text) to AWS CLI calls.

#review-29906 «		 about a year ago View Review
29846 C. Thomas Tyler Enhanced sync_replica.sh and replica_status.sh to send summary rather than full email, sim...ilar to p4verify.sh. « about a year ago Request Review
29779 C. Thomas Tyler Added a fix for issue with tab expansion of variables.

#review-29780 		2 years ago View Review
29753 C. Thomas Tyler Added SDP coding standard for bash.

Enhanced format of p4_vars to improve testability. 		2 years ago Request Review
29729 C. Thomas Tyler Added script to detect Swarm and extract Swarm version.

#review-29730 		2 years ago View Review
29625 C. Thomas Tyler Added script to diff local sdp install from baseline. 2 years ago Request Review
29518 C. Thomas Tyler Enhanced sync_replica.sh to support operation on a 'ham'
type replica (HA, Metadata-only).... A 'ham' type replica
replicates only metadata, and shares the /hxdepots volume
(via NFS) with its target server.

In this configuration, the SHAREDDATA=TRUE value is set,
and this corresponds to a p4d configuration setting for
the replica of lbr.replication=shared.

In this configuration, the journalPrefix value of the
replica server will differ from that of its target
server.  For example, the commit server will may have
the First Form jour the journalPrefix, while an HA
of the commit will have the Second Form.  See
'The journalPrefix Standard':

https://swarm.workshop.perforce.com/projects/perforce-software-sdp/view/main/doc/SDP_Guide.Unix.html#_the_journalprefix_standard

As another example, for an edge server and HA of that
edge, both servers will use the Second Form of the
journalPrefix, the form which incorporates a shortened
form of the ServerID into the journalPrefix value. But
since the ServerIDs are different, the actual journalPrefix
values will be different, even though both are of the
Second Form.

The common pattern is that, when configured for NFS sharing,
the sync_replica.sh script should use the journalPrefix
of its target server when determining where to look for
a checkpoint and numbered journal to load into the offline_db.

#review-29520 @mark_zinthefer @robert_cowham «		 2 years ago View Review
29348 C. Thomas Tyler Added test for edge_vars to ensure we get the correct list of
edge-specific db.* files fo...r different p4d versions. «		 2 years ago Request Review
29344 C. Thomas Tyler Added documentation on sysconfig script. 2 years ago Request Review
29222 C. Thomas Tyler Take advantage of 'p4d -R' option for creating edge dumps for p4d 2022.1+.

This change... is on hold pending a needed p4d server change:

P4-23089/job114978 - For p4d, the '-R edge-server' option should work with '-P MyServerID'.

Search the diffs for EDITME to put in the correct p4d server version after this feature
is implemented. «		 2 years ago Request Review
29214 C. Thomas Tyler Added pic files. 2 years ago Request Review
29061 C. Thomas Tyler added temp file for xfer. 2 years ago Request Review
28523 C. Thomas Tyler Added logic to determine latest major versions of Helix binaries
by checking json files p...ublished at updates.perforce.com.

WIP - WORK IN PROGRESS CHANGE. Shelved due to need to clean up a
broken development environment. «		 3 years ago Request Review
28138 C. Thomas Tyler Added variant of install_sdp_python.sh with no SDP dependencies,
a default install locati...on of /usr/local/python, and no safety
checks related to RunUser. «		 3 years ago Request Review
28048 C. Thomas Tyler Attempted workaround for SDP-685.

Changed to enhance security by ensuring copied temp s...cripts have only
perms for owner from the point of inception. «		 3 years ago Request Review
27938 C. Thomas Tyler Added '-init' option to initialize SDP on an empty data set. 4 years ago Request Review
27866 C. Thomas Tyler Swapped out Docker image used for Rocky Linux to the official one. 4 years ago Request Review
27446 C. Thomas Tyler Eliminated separate log handling in p4login. 4 years ago Request Review
27435 C. Thomas Tyler Added CentOS 8 to test suite. 4 years ago Request Review
27393 C. Thomas Tyler Added support for CentOS 8.
Added support for doing a 'docker login' if a supplied .docker..._creds
file existed. «		 4 years ago Request Review
27004 C. Thomas Tyler WIP. 4 years ago Request Review
26978 C. Thomas Tyler Added build.sh file in doc directory.
Updated doc Makefile. 		4 years ago Request Review
26954 C. Thomas Tyler mkdirs.sh v4.1.0:
* Accounted for directory structucre change of Maintenancd to Unsupporte...d.
* Added standard command line procssing with '-h' and '-man' doc flags,
and other flags (all documented).
* Added in-code docs and updated AsciiDoc.
* Enhanced '-test' mode to simulate /hx* mounts.
* Enhanced preflight testing, and fixed '-test' mode installs.
* Added support for installing to an alternate root directory.
* Added '-s <ServerID>' option to override REPLICA_ID.
* Added '-S <TargetServerID>' used for replicas of edge servers.
* Added '-t <server_type>' option to override SERVER_TYPE.
* Added '-M' option to override mount points.
* Added '-f' fast option to skip big chown/chmod commands, and
moved those commands near the end as well.

verify_sdp.sh v5.9.0:
* Added check for /p4/Version file, and checked that other legacy
SDP methods of checking version
* Added sanity check for crontab.
* Added 'test skip' mechanism to skip certain tests:
 - crontab
 - version
 - license
 - version
* Added VERIFY_SDP_SKIP_TEST_LIST setting ton instance_vars.template,
to define a standard way to have verify_sdp.sh always skip certain
tests for a site.
* Extended '-online' checks to check for bogus P4MASTERPORT, a common
config error.

Update test_SDP.py:
* Adusted test suite to account for various changes in mkdirs.sh.
* Added 'dir' parameter to run_cmd() and sudo_cmd(), to run a
command from a specified directory (as required to test new
mkdirs.sh)
* Added check_links() similar to existing check_dirs() function.

=== Upgrade Process Changes ===

Made /p4/common/bin/p4d/p4/p4broker/p4p shell script rather than binary.

This changes the way SDP new binaries are staged for upgrade.  For
safety, exes are now staged to a director outside the PATH, the
/p4/sdp/exes foler. A new 'get_latest_exes.sh' script simplifies
the task of pulling executables from the Perforce FTP server. This
can be used 'as is' for environments with outbound internet access,
and is useful in any case to describe now to acquire binaries.

This addresses an issue where a p4d binary staged for a future
upgrade might be called before the actual upgrade is performed.

upgrade.sh v4.0.0:
* All preflight checks are now done first. Added '-p' to abort after preflight.
* Added '-n' to show what would be done before anything is executed.
* Minimalist logic to start/stop only servers that are upgrade, and apply
upgrades only as needed.
* Staging of exes for upgrade is now separate from /p4/common/bin
* Improved in-code docs, added '-h' and '-man' options.
* Retained pre/post P4D 2019.1 upgrade logic.

#review-26962 «		 4 years ago View Review
26897 C. Thomas Tyler Updated source for Python in SDP test suite for CentOS 6 and CentOS 7.

#review-26902 		4 years ago View Review
26894 C. Thomas Tyler ALL WIP Changes. 4 years ago Request Review
26760 C. Thomas Tyler Enhanced is_edge() and is_standby() to avoid excess I/O.

Also added internal code doc o...f sample usage.

Updated calls to is_edge() and is_standby() in backup_functions.sh and edge_dump.sh.

Added basic sanity test suite coverage for backup_functions.sh.

# review «		 5 years ago Request Review
26757 C. Thomas Tyler Fixed issue with load_checkpoint.sh not clearing journal.NNN file when working on a
stand...by (journalcopy) replica, which prevented replication from automatically
starting.  These files are now moved aside.

Removed undocumented edge processing logic determined to be unnecessary.

Minor doc improvements.

#review-26758 «		 5 years ago View Review
26722 C. Thomas Tyler Enhanced is_edge() and is_standby() to avoid unnecessary I/O, and provided
doc of sample... usage.

Updated calls to is_edge() and is_standby() in backup_functions.sh and edge_dump.sh. «		 5 years ago Request Review

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default
Check all
I change the state of a review
I am the author, and
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed