Change 14024

riesman (riesman)
riesman committed this change into //guest/riesman/p4review
Request Review
Download .zip
Problem: the email_summary was stuck at false, even if set to true in the config file because the arg parser defaulted it to false, and command line args override the config file.
 Solution: remove default value
Problem: opening the log file in binary mode "ab" caused errors in Python 3.  Solution: open it in text mode "a".
Problem: same changes getting parsed again and again.  Solution: update review counter to last change examined.
  • Files 1
  • Comments 0
1 edited 0 added 0 deleted
p4review2.py#3
Loading...
Tip: Use n and p to cycle through the changes.