commits/23939

Change 23939

punithc
punithc committed this change 7 years ago into //guest/punithc/p4flex/main/demo
Request Review
Download .zip
Extended support for UID/GID during volume creation or cloning
Add Job
1 edited 0 added 0 deleted
Tip: Use n and p to cycle through the changes.
paul_allen (Paul Allen)
sname = o[2:]
+ if o.startswith('-u'):
+ uid = pwd.getpwnam(o[2:]).pw_uid
+ if o.startswith('-g'):
+ gid = grp.getgrnam(o[2:]).gr_gid
Paul Allen (on flex.py, line 1104) commented 7 years ago

Do you want to allow a user to override the uid/gid for the clone command. Snapshot and Volume are more for admins and then shared by users. Perhaps your users have other accounts?
Reply
paul_allen (Paul Allen)
+ if uid:
+ gid = pwd.getpwuid(uid).pw_gid
+ else:
+ p4group = config.get("p4.osuser")
+ gid = pwd.getpwnam(p4group).pw_gid
Paul Allen (on flex.py, line 832) commented 7 years ago

This should be ok for the 99% use case. OS X and other unix platforms use 'staff' as the group. Perhaps we could get the group from the user's home directory?
Reply
punithc
+ if uid:
+ gid = pwd.getpwuid(uid).pw_gid
+ else:
+ p4group = config.get("p4.osuser")
+ gid = pwd.getpwnam(p4group).pw_gid
punithc (on flex.py, line 832) commented 7 years ago

I guess P4flex was never supported on OS X
Reply
punithc
sname = o[2:]
+ if o.startswith('-u'):
+ uid = pwd.getpwnam(o[2:]).pw_uid
+ if o.startswith('-g'):
+ gid = grp.getgrnam(o[2:]).gr_gid
punithc (on flex.py, line 1104) commented 7 years ago

BammBamm workflow that we have in Netapp benefits from this functionality. We create user workspace from a pre-built snapshot (generally owned by build account) and change the cloned volume ownership to user.
Reply
paul_allen (Paul Allen)
Paul Allen commented 7 years ago

Over all I am happy with the changes; did you want to copy the changes to the main netapp/p4flex project?
Reply
punithc
punithc commented 7 years ago

We did couple of rounds of testing and used the same code for customer demo as well. I think the modified changes are working fine, so it will be great help if you can please merge the changes to main project "netapp/p4flex"

Thanks.
Reply