Change 2407
Bug fix (kind of).
The reuse of the variable names otherLock and
otherOpen in the output of "p4 fstat" was causing P4Ruby to trash
the first value of the variable in favour of the second. So for
otherOpen you'd get the number of other people who have the file
open, but not their names or clients. This change introduces a
slightly unpleasant fix which renames the second, unindexed
occurrence of the variable (i.e. otherOpen not otherOpen1) by
simply appending an "s". So otherOpen becomes otherOpens and
otherLock becomes otherLocks.
In the case of otherOpen(s) this makes sense because the hash
member otherOpen points to an array of user/client combo's for
people who have the file open whilst otherOpens is the number of
other people who have the file open (i.e h[ "otherOpen" ].length ).
In the case of otherLock it makes slightly less sense since
otherLock is normally a flag but now it's a (one-element)
array containing the name & client of the locking user. otherLocks
is now the flag and contains only an empty string as its value.
In future it may make more sense to simply drop otherLocks and
otherOpens as the array elements give you all the info you need.
The reuse of the variable names otherLock and
otherOpen in the output of "p4 fstat" was causing P4Ruby to trash
the first value of the variable in favour of the second. So for
otherOpen you'd get the number of other people who have the file
open, but not their names or clients. This change introduces a
slightly unpleasant fix which renames the second, unindexed
occurrence of the variable (i.e. otherOpen not otherOpen1) by
simply appending an "s". So otherOpen becomes otherOpens and
otherLock becomes otherLocks.
In the case of otherOpen(s) this makes sense because the hash
member otherOpen points to an array of user/client combo's for
people who have the file open whilst otherOpens is the number of
other people who have the file open (i.e h[ "otherOpen" ].length ).
In the case of otherLock it makes slightly less sense since
otherLock is normally a flag but now it's a (one-element)
array containing the name & client of the locking user. otherLocks
is now the flag and contains only an empty string as its value.
In future it may make more sense to simply drop otherLocks and
otherOpens as the array elements give you all the info you need.