Change 24601
Eliminated unnecessary removal of live rdb.lbr file.
The rdb.lbr from was being removed duing the scripts that reset
a replica using offline databases. The rdb.lbr file is not
regenerated from a checkpoint, and is not affected in the process
of regneration from a checkpoint, and thus should not be removed
in checkpoint-related processing.
Removing it was functionally mostly harmless, as the rdb.lbr
file gets regenerated and update as needed by user activity,
and also by p4verify.sh. However, removing it unnecesarily
caused unnecessary delay in getting archive files sync'd.
The processing in switch_db_files() in backup_functions.sh
(for the UNIX/Linux implementation) expects the rdb.lbr file
to exist prior to the db swap.
#review-23900
The rdb.lbr from was being removed duing the scripts that reset
a replica using offline databases. The rdb.lbr file is not
regenerated from a checkpoint, and is not affected in the process
of regneration from a checkpoint, and thus should not be removed
in checkpoint-related processing.
Removing it was functionally mostly harmless, as the rdb.lbr
file gets regenerated and update as needed by user activity,
and also by p4verify.sh. However, removing it unnecesarily
caused unnecessary delay in getting archive files sync'd.
The processing in switch_db_files() in backup_functions.sh
(for the UNIX/Linux implementation) expects the rdb.lbr file
to exist prior to the db swap.
#review-23900
0 comments
Log in to comment
Tip: Use n and p to cycle through the changes.
|
|
move %OFFLINE_DB_DIR%\db.* %P4ROOT% >> %LOG% 2>&1 echo Removing state files >> %LOG% 2>&1 del state >> %LOG% 2>&1 -del rdb.lbr >> %LOG% 2>&1
Russell C. Jackson (Rusty) (on weekly_sync_replica.bat, line 91) commented
7 years ago
It is a good idea to delete the rdb.lbr to keep it small. When that file grows to a large size, which it will do if a lot of files are scheduled to be transferred by p4verify, it slows down the pull command. |
| ·0 | |
|
|