Change 25769

tom_tyler (C. Thomas Tyler)
C. Thomas Tyler committed this change into / under Review 25696
View Review
Download .zip
Fixed bug where P4PORT value might be 'Unset'.

This could be observed due to a misconfiguration where the
P4MASTER_ID value set in the instance vars file,
/p4/common/config/p4_N.vars, was incorrect (i.e. didn't match
the actual ServerID of the master/commit server). Or if a
replica was only partially defined without P4TARGET being
defined.  These misconfigurations are outside the realm of
this script to address, but they exposed a bad assumption in
the script.  That has been corrected.

Also:
* Added logic to ensure 'p4d -cshow' is not attempted unless
$P4ROOT/db.config exists, for error-free operation on proxy and
replica servers that have no p4d.
* Several unrelated minor tweaks were made to help with shellcheck
compliance.
  • Files 1
  • Comments 0
1 edited 0 added 0 deleted
guest/perforce_software/sdp/dev/Server/Unix/p4/common/bin/p4login#18
Loading...
Tip: Use n and p to cycle through the changes.