commits/30370

Change 30370

will_kreitzmann (Will Kreitzmann)
Will Kreitzmann committed this change 10 months ago into //guest/perforce_software/sdp/dev/Server/Unix/p4/common/bin under Review 30371
View Review
Download .zip
(SDP-1065) SNS fix's though I'd like to mow the lawn a bit more on this
Add Job
1 edited 0 added 0 deleted
Tip: Use n and p to cycle through the changes.
tom_tyler (C. Thomas Tyler)
+function sns_log_file_all () {
+ local subject="$1"
+ local short_subject="$(echo "${subject:0:100}")"
+ echo -e "Sending alert and log file contents to administrator via AWS SNS (all alerts)." >&2
C. Thomas Tyler (on backup_functions.sh, line 423) commented 10 months ago

Please remove the echo, or else surround it with an if conditional along the lines of:

if [[ -n "${SDP_DEBUG:-}" ]]; then
echo -e "Sending alert and log file contents to administrator via AWS SNS (all alerts)." >&2
fi

Reasoning: In backup_functions.sh, any direct output to the terminal (stdout or stderr) is generally a bug (except for debugging). SDP scripts that use these are called by crontab, and if scripts called by crontab generate any output, then crontab itself sends its own email, which causes confusion because it's not the desired content of the email that the SDP script's send themselves.
Reply