Change 32894

russell_jackson (Russell C. Jackson (Rusty))
Russell C. Jackson (Rusty) committed this change into //guest/russell_jackson/ansible-sdp
Request Review
Download .zip
Add group resource guardrails to perforce-sdp-install; inventory cleanup

Guardrails (gated on guardrails_enabled, commit server):
- New group_limits phase (thin orchestrator + group_limits/ subdir:
  deploy_scripts, set_limits, populate) included from main.yml. Templates the
  SDP keep_group_unset.py trigger and update_limits.py from inventory so no
  group/user name is hardcoded; sets Max* on each managed group via the new
  idempotent files/manage_p4group.py helper; populates the limits group once
  (marker-guarded). No new cron -- the SDP's hourly master cron maintains
  membership.
- Every group name is its own variable (p4_baseline_group, p4_integrators_group,
  p4_unlimited_group, p4_admins_group, p4_replicas_group); p4_group_limits is a
  list of {name, limits}. Naming convention in group_vars/main; per-environment
  values + enable flag in each commit server's host_vars; safe fallbacks in
  defaults.
- Molecule: install scenario now runs the guardrails phase after
  configure_new_server and verifies the scripts are deployed and the
  limits/p4-unlimited groups carry the expected values. README + docs updated.

Inventory cleanup:
- Removed the 2kgla1tst2 and la1v-rjackson commit hosts (host_vars + inventory).
- Renamed the top-level inventory group central -> main (group_vars dir moved,
  references updated across inventory, molecule, README, CLAUDE.md).

ansible-lint production-clean; playbooks syntax-check; helper/templates compile.
  • Files 21
  • Comments 0
10 edited 8 added 3 deleted
CLAUDE.md#2
Loading...
README.md#5
Loading...
inventories/group_vars/central/main.yml#4
Loading...
inventories/group_vars/main/main.yml#1
Loading...
inventories/host_vars/2kgla1tst2.yml#2
Loading...
inventories/host_vars/la1v-rjackson.yml#2
Loading...
inventories/host_vars/p4-cache-test.yml#3
Loading...
inventories/host_vars/perforce-commit.yml#3
Loading...
inventories/p4-sdp-install.yml#6
Loading...
roles/perforce-sdp-install/defaults/main.yml#6
Loading...
roles/perforce-sdp-install/files/manage_p4group.py#1
Loading...
roles/perforce-sdp-install/molecule/default/converge.yml#3
Loading...
roles/perforce-sdp-install/molecule/default/molecule.yml#4
Loading...
roles/perforce-sdp-install/molecule/default/verify.yml#2
Loading...
roles/perforce-sdp-install/tasks/group_limits.yml#1
Loading...
roles/perforce-sdp-install/tasks/group_limits/deploy_scripts.yml#1
Loading...
roles/perforce-sdp-install/tasks/group_limits/populate.yml#1
Loading...
roles/perforce-sdp-install/tasks/group_limits/set_limits.yml#1
Loading...
roles/perforce-sdp-install/tasks/main.yml#8
Loading...
roles/perforce-sdp-install/templates/keep_group_unset.py.j2#1
Loading...
roles/perforce-sdp-install/templates/update_limits.py.j2#1
Loading...
Tip: Use n and p to cycle through the changes.