Change 33011

tom_tyler (C. Thomas Tyler)
C. Thomas Tyler committed this change into //guest/perforce_software/sdp/dev/Server under Review 33012
View Review
Download .zip
Added safety preflight to avoid accidentally running on an existing
server. Running on a server with existing data (as determined by
whether the 'change' counter is 0) now requires using a '-f' (force)
option.

This entailed adding standard command line processing that comes from
the the Coding Standard for Bash. The Coding Standard also provides
more standard logging functionality. Moving to the coding standard
entailed moving away from key dependencies in backup_functions.sh();
e.g. the 'log()' and 'die()' functions were replaced with simpler
'msg()' and 'bail()' -- this greatly increases logging reliability.

Added a new library /p4/common/lib/service_management.lib.

This conversion to the Coding Standard for Bash is a preview of
future changes needed by legacy scripts like live_checkpoint.sh
and daily_checkpoint.sh, etc.

As part of this change, the definition of OFFLINE_DB has been moved
from backup_functions.sh to p4_vars, aligning it with other
fixed-by-standards paths are defined.

Fixes SDP-779.
  • Files 6
  • Comments 0
5 edited 1 added 0 deleted
Unix/p4/common/bin/backup_functions.sh#177
Loading...
Unix/p4/common/config/configurables.cfg#35
Loading...
Unix/p4/common/config/p4_vars.template#45
Loading...
Unix/p4/common/lib/service_management.lib#1
Loading...
Unix/setup/configure_sample_depot_for_sdp.sh#4
Loading...
setup/configure_new_server.sh#81
Loading...
Tip: Use n and p to cycle through the changes.