Change 33235
Rename stale svc_master.1.user.p4s to svc_commit.p4demo.1.user.p4s (and update its User/FullName fields to match), to fix create_master_service_user.sh in the BSW test/bsw suite.
create_master_service_user.sh builds the service-user spec filename dynamically from the live $SERVERID (svc_$SERVERID.user.p4s). This environment's actual ServerID is commit.p4demo.1 (per BSW-Lab-Reference.md's documented table for this generation), but the checked-in spec file was still named/keyed for an older 'master.1' ServerID convention -- so the script's 'p4 user -f -i < svc_commit.p4demo.1.user.p4s' failed with 'No such file or directory', which cascaded into every fleet host's p4login failing (BSW's qa_build test suite's Test 53, 'SUCCESS: Login OK on all targeted hosts.' never found).
Confirmed via the user this is intentional/fine to hardcode here: test/bsw/ is dedicated to supporting the BSW lab environment's own SDP testing, so BSW-specific values are expected in this directory.
Found while chasing qa_build test suite failures in the SDP-QA-Gen7 BSW lab.
create_master_service_user.sh builds the service-user spec filename dynamically from the live $SERVERID (svc_$SERVERID.user.p4s). This environment's actual ServerID is commit.p4demo.1 (per BSW-Lab-Reference.md's documented table for this generation), but the checked-in spec file was still named/keyed for an older 'master.1' ServerID convention -- so the script's 'p4 user -f -i < svc_commit.p4demo.1.user.p4s' failed with 'No such file or directory', which cascaded into every fleet host's p4login failing (BSW's qa_build test suite's Test 53, 'SUCCESS: Login OK on all targeted hosts.' never found).
Confirmed via the user this is intentional/fine to hardcode here: test/bsw/ is dedicated to supporting the BSW lab environment's own SDP testing, so BSW-specific values are expected in this directory.
Found while chasing qa_build test suite failures in the SDP-QA-Gen7 BSW lab.