Change 5752
The unicode support in the API seems still not to work entirely (it complains incorrectly that a client spec cannot be used from the server, removing the server from the clientspec fixes that).
Anyway, I discovered a number of bugs in P4ClientModule.cc during this process. The most serious seems to be that we need to hold on to the strings we pass to SetArgv(), since it doesn't appear to do so itself. I have yet to receive confirmation from P4 support on this but my fix fixes a lot of issues.
Other bugs had to do mostly with python reference counting and error handling.
I also added text handling to the SetTrans() method. I wonder if the "charset" attribute should be supported, since it apparently doesn't do anything in the API.
Anyway, I discovered a number of bugs in P4ClientModule.cc during this process. The most serious seems to be that we need to hold on to the strings we pass to SetArgv(), since it doesn't appear to do so itself. I have yet to receive confirmation from P4 support on this but my fix fixes a lot of issues.
Other bugs had to do mostly with python reference counting and error handling.
I also added text handling to the SetTrans() method. I wonder if the "charset" attribute should be supported, since it apparently doesn't do anything in the API.