Change 975

sam_stafford (Sam Stafford)
Sam Stafford committed this change into //guest/sam_stafford/p4hl
Request Review
Download .zip
Nigh-complete fix for job 4 - the "scan" methods all
go from tail to head now, and Get uses the improved
"addAfter" method where appropriate.

An unforeseen problem was the fact that a complex integ
history can get followed through more than one possible
path, causing later versions of a given file to get scanned
before earlier versions, and messing up the graph.

This is fixed (albeit in a kludgey fashion) in scanMain here
by making two passes through the FileHead, caching the files
on the first pass and actually running scans on the second
pass.  A slightly more efficient way of handling it might be
to keep a list of FileRevs that need to be scanned - perhaps
by declaring a temporary FileHead to serve as a list?  Once
it's been hammered out in scanMain() satisfactorily that method
can be employed in the other scan methods.
  • Files 4
  • Comments 0
4 edited 0 added 0 deleted
dist/dlls/p4hl.dll#6
Loading...
src/dlls/FileHead.cpp#4
Loading...
src/dlls/FileLogCache.cpp#3
Loading...
src/dlls/FileLogCache.h#2
Loading...
Tip: Use n and p to cycle through the changes.