# The form data below was edited by lester_cheung
# Perforce Workshop Jobs
#
#  Job:           The job name. 'new' generates a sequenced job number.
#  Status:        Job status; [open/closed/suspended].  Required
#  Project:       The project this job is for. Required.
#  Severity:      [A/B/C] (A is highest)  Required.
#  ReportedBy     The user who created the job. Can be changed.
#  ReportedDate:  The date the job was created.  Automatic.
#  ModifiedBy:    The user who last modified this job. Automatic.
#  ModifiedDate:  The date this job was last modified. Automatic.
#  OwnedBy:       The owner, responsible for doing the job. Optional.
#  Description:   Description of the job.  Required.
#  DevNotes:      Developer's comments.  Optional.
#  Type:	  Type of job; [Bug/Feature].  Required.

Job:	job000030

Status:	open

Project:	lester-cheung-p4review

Severity:	C

ReportedBy:	lester_cheung

ReportedDate:	2013/08/20 01:10:10

ModifiedBy:	lester_cheung

ModifiedDate:	2015/02/08 22:28:11

OwnedBy:	lester_cheung

Description:
	[p4review2] Handles file permissions and restricted changelists
	
	IDEAS:
	
	* people w/o (read?) access should not be notified.
	
	* filepaths who user have no list permission on should not
	  be included in the file list.
	
	* good thing that p4review2 is not sending diffs - or we
	  may expose content protected by the protection table.:)
	
	Idea from Sven:
	* Simply run p4review2 as a super user and inpersonate the user
	  when running "p4 desceribe" - basically let the server to do the
	  filtering.

DevNotes:
	2015/02/15 lester_cheung: job000138 is a dupe of this.
	Running "p4 desceribe" as the user seems a lot of work on
	the server when a lot users are subscribed to changes..

Type:	Feature