SDP-353 #4

  • //
  • spec/
  • job/
  • SDP-353
  • View
  • Commits
  • Open Download .zip Download (4 KB)
# The form data below was edited by tom_tyler
# Perforce Workshop Jobs
#
#  Job:           The job name. 'new' generates a sequenced job number.
#
#  Status:        Job status; required field.  There is no enforced or
#                 promoted workflow for transition of jobs from one
#                 status to another, just a set of job status values
#                 for users to apply as they see fit.  Possible values:
#
#                 open - Issue is available to be worked on.
#
#                 inprogress - Active development is in progress.
#
#                 blocked - Issue cannot be implemented for some reason.
#
#                 fixed - Fixed, optional status to use before closed.
#                 
#                 closed - Issue has been dealt with definitively.
#
#                 punted - Decision made not to address the issue,
#                    possibly not ever.
#
#                 suspended - Decision made not to address the issue
#                    in the immediate future, but noting that it may
#                    have some merit and may be revisited later.
#
#                 duplicate - Duplicate of another issue that.
#
#                 obsolete - The need behind the request has become
#                    overcome by events.
#
#  Project:       The project this job is for. Required.
#
#  Severity:      [A/B/C] (A is highest)  Required.
#
#  ReportedBy     The user who created the job. Can be changed.
#
#  ReportedDate:  The date the job was created.  Automatic.
#
#  ModifiedBy:    The user who last modified this job. Automatic.
#
#  ModifiedDate:  The date this job was last modified. Automatic.
#
#  OwnedBy:       The owner, responsible for doing the job. Optional.
#
#  Description:   Description of the job.  Required.
#
#  DevNotes:      Developer's comments.  Optional.  Can be used to
#                 explain a status, e.g. for blocked, punted,
#                 obsolete or duplicate jobs.  May also provide
#                 additional information such as the earliest release
#                 in which a bug is known to exist.
#
# Component:      Projects may use this optional field to indicate
#                 which component of the project a givenjob is associated
#                 with.
#
#                 For the SDP, the list of components is defined in:
#                 //guest/perforce_software/sdp/tools/components.txt
#
#  Type:          Type of job [Bug/Feature].  Required.
#
#  Release:       Release in which job is intended to be fixed.

Job:	SDP-353

Status:	closed

Project:	perforce-software-sdp

Severity:	C

ReportedBy:	tom_tyler

ReportedDate:	2018/10/12 14:37:45

ModifiedBy:	tom_tyler

ModifiedDate:	2019/03/01 13:21:57

OwnedBy:	tom_tyler

Description:
	Avoid doing 'p4d -cset' for P4JOURNAL, but preserve safety feature.
	
	Change @18686 introduced logic in p4d startup to always forcibly
	set P4JOURNAL to the correct SDP-defined value, /p4/N/logs/journal,
	by using 'p4d -cset' at the start of processing.  This matches
	the value set in the SDP shell environment.
	
	This was done to address a situation where, for whatever reason,
	P4JOURNAL was somehow set to an incorrect value, with bad
	consequences.  Apparently it was set with a 'p4 configure'
	command resulting in it being stored in db.config, which
	overrides the shell environment setting.
	
	Using 'p4d -cset' generates strange and atypical entries in the
	journal file, and so I want to stop doing that.  Also, I want
	to avoid defining things in more than one way.
	
	So, we want to change the logic so that we detect the
	P4JOURNAL value as set in db.config first.  If it is
	set, we should instead to a 'p4d -cunset' to make sure
	the value for P4JOURNAL defined in the shell environment
	does not get overriden.
	
	While we are at it, we may want to also ensure that P4LOG,
	and other key setting are not defined in db.config, so that they
	defer to the SDP standard shell environment values.

Component:	core-unix

Type:	Feature
# Change User Description Committed
#4 default
#3 default
#2 default
#1 default