SDP-728 #2

  • //
  • spec/
  • job/
  • SDP-728
  • View
  • Commits
  • Open Download .zip Download (4 KB)
# The form data below was edited by tom_tyler
# Perforce Workshop Jobs
#
#  Job:           The job name. 'new' generates a sequenced job number.
#
#  Status:        Job status; required field.  There is no enforced or
#                 promoted workflow for transition of jobs from one
#                 status to another, just a set of job status values
#                 for users to apply as they see fit.  Possible values:
#
#                 open - Issue is available to be worked on.
#
#                 inprogress - Active development is in progress.
#
#                 blocked - Issue cannot be implemented for some reason.
#
#                 fixed - Fixed, optional status to use before closed.
#                 
#                 closed - Issue has been dealt with definitively.
#
#                 punted - Decision made not to address the issue,
#                    possibly not ever.
#
#                 suspended - Decision made not to address the issue
#                    in the immediate future, but noting that it may
#                    have some merit and may be revisited later.
#
#                 duplicate - Duplicate of another issue that.
#
#                 obsolete - The need behind the request has become
#                    overcome by events.
#
#  Project:       The project this job is for. Required.
#
#  Severity:      [A/B/C] (A is highest)  Required.
#
#  ReportedBy     The user who created the job. Can be changed.
#
#  ReportedDate:  The date the job was created.  Automatic.
#
#  ModifiedBy:    The user who last modified this job. Automatic.
#
#  ModifiedDate:  The date this job was last modified. Automatic.
#
#  OwnedBy:       The owner, responsible for doing the job. Optional.
#
#  Description:   Description of the job.  Required.
#
#  DevNotes:      Developer's comments.  Optional.  Can be used to
#                 explain a status, e.g. for blocked, punted,
#                 obsolete or duplicate jobs.  May also provide
#                 additional information such as the earliest release
#                 in which a bug is known to exist.
#
# Component:      Projects may use this optional field to indicate
#                 which component of the project a givenjob is associated
#                 with.
#
#                 For the SDP, the list of components is defined in:
#                 //guest/perforce_software/sdp/tools/components.txt
#
#  Type:          Type of job [Bug/Feature/Problem].  Required.
#                 Feature and Bug are common terms.
#                 A Problem is suspected bug, or one without a clear
#                 understanding of exactly what is broken.
#
#  Release:       Release in which job is intended to be fixed.

Job:	SDP-728

Status:	punted

Project:	perforce-software-sdp

Severity:	A

ReportedBy:	amo

ReportedDate:	2021/12/16 10:18:11

ModifiedBy:	tom_tyler

ModifiedDate:	2022/01/30 11:43:13

OwnedBy:	amo

Description:
	New SDP doesn't like old SDP configuration. 
	
	Up to 2018.1, the "p4d_base" script explicitly set P4JOURNAL in the database using 'p4d -cset'. 
	
	      echo "Setting P4JOURNAL in the database to $P4JOURNAL." | tee -a $LOGFILE
	      echo $P4DBIN -r $P4ROOT -cset P4JOURNAL=$P4JOURNAL | tee -a $LOGFILE
	      $P4DBIN -r $P4ROOT "-cset P4JOURNAL=$P4JOURNAL" 2>&1 | tee -a $LOGFILE
	
	SDP 2018.1.23504 (2018/01/19)
	https://workshop.perforce.com/files/guest/perforce_software/sdp/main/Server/Unix/p4/common/bin/p4d_base?v=19
	
	From revision 7 of the 'verify_sdp.sh' script, there is an explicit checks for P4JOURNAL in the db.config file, and rejects this as invalid. 
	
	check_configurable "$SDP_INSTANCE" P4JOURNAL ALL UNDEF
	msg "Note: P4JOURNAL must be defined as a shell environment variable and must not set in db.config.\\n"
	
	https://workshop.perforce.com/files/guest/perforce_software/sdp/dev/Server/Unix/p4/common/bin/verify_sdp.sh?v=7
	
	This causes problems as call to 'verify_sdp' will report an error. Crops up when upgrading an existing SDP environment; calls to 'verify_sdp' are made from the upgrade and daily_checkpoint scripts, and it's also called from functions in 'backup_functions'. 
	NB: also a problem for Admins moving to SDP-control from a non-SDP environment where P4JOURNAL is often set in the database. 
	
	See also SDP-720.

DevNotes:
	2021-01-30 ttyler: Changed status from open to punted. See comments.

Type:	Bug
# Change User Description Committed
#2 default
#1 default