SDP-667
Closed
Make preview mode default behavior for upgrade.sh; add '-y' to confirm.
Then add a '-y' to execute actual upgrades.
Given the impact of changes made when upgrading and the inability to rollback, would it be worth having the upgrade.sh script default to preview mode similar to 'p4 obliterate' such that the user has to consciously add a flag to execute the work?
Then add a '-y' to execute actual upgrades.
Given the impact of changes made when upgrading and the inability to rollback, would it be worth having the upgrade.sh script default to preview mode similar to 'p4 obliterate' such that the user has to consciously add a flag to execute the work?
- Status
- Closed
- Project
- perforce-software-sdp
- Severity
- C
- Reported By
- Domenic
- Reported Date
- 4 years ago
- Modified By
- C. Thomas Tyler
- Modified Date
- 3 years ago
- Owned By
- Domenic
- Component
- core-unix
- Type
- Feature
Well, I've made similar arguments, e.g. requesting that 'p4 failover' follow the same model as 'p4 obliterate' for the same reason.
The upgrade.sh does of course have a '-n' preview mode, but this job is requesting that preview be the default, and have a separate flag (probably '-y' to commence the actual upgrade, similar to load_checkpoint.sh).
That's a reasonable ask. If we did that, I'd want to keep the '-n' in there for backward compatibility, even though it would be the default if this is implemented.
Thoughts, @robert_cowham?
+1 for this. I ran upgrade.sh without doing a -n first and ran into an issue because the user running the upgrade didn't have enough access to stop/start the perforce service, so the upgrade script hung and was uncrecoverable.