SDP-728

amo (Adam Morriss)
Adam Morriss created this job , modified by C. Thomas Tyler
Punted
New SDP doesn't like old SDP configuration.

Up to 2018.1, the "p4d_base" script explicitly set P4JOURNAL in the database using 'p4d -cset'.

      echo "Setting P4JOURNAL in the database to $P4JOURNAL." | tee -a $LOGFILE
      echo $P4DBIN -r $P4ROOT -cset P4JOURNAL=$P4JOURNAL | tee -a $LOGFILE
      $P4DBIN -r $P4ROOT "-cset P4JOURNAL=$P4JOURNAL" 2>&1 | tee -a $LOGFILE

SDP 2018.1.23504 (2018/01/19)
https://workshop.perforce.com/files/guest/perforce_software/sdp/main/Server/Unix/p4/common/bin/p4d_base?v=19

From revision 7 of the 'verify_sdp.sh' script, there is an explicit checks for P4JOURNAL in the db.config file, and rejects this as invalid.

check_configurable "$SDP_INSTANCE" P4JOURNAL ALL UNDEF
msg "Note: P4JOURNAL must be defined as a shell environment variable and must not set in db.config.\\n"

https://workshop.perforce.com/files/guest/perforce_software/sdp/dev/Server/Unix/p4/common/bin/verify_sdp.sh?v=7

This causes problems as call to 'verify_sdp' will report an error. Crops up when upgrading an existing SDP environment; calls to 'verify_sdp' are made from the upgrade and daily_checkpoint scripts, and it's also called from functions in 'backup_functions'.
NB: also a problem for Admins moving to SDP-control from a non-SDP environment where P4JOURNAL is often set in the database.

See also SDP-720.
  • Details
  • Comments -
Status
Punted
Project
perforce-software-sdp
Severity
A
Reported By
Adam Morriss
Reported Date
Modified By
C. Thomas Tyler
Modified Date
Owned By
amo
Dev Notes
2021-01-30 ttyler: Changed status from open to punted.
See comments.
Type
Bug