jobs/SDP-824

SDP-824

andy_boutte (Andy Boutte)
Andy Boutte created this job 3 years ago, modified by C. Thomas Tyler 2 years ago
Closed
CheckCaseTrigger.py fails if has Unicode mode enabled.

When Helix Core is in unicode mode CheckCaseTrigger.py will fail with the following error:

<class 'NameError'> name 'unicode' is not defined 

This comes from line 187 of CheckCaseTrigger.py https://swarm.workshop.perforce.com/projects/perforce-software-sdp/files/main/Unsupported/Samples/triggers/CheckCaseTrigger.py
29043
29027
Status
Closed
Project
perforce-software-sdp
Severity
C
Reported By
Andy Boutte
Reported Date
3 years ago
Modified By
C. Thomas Tyler
Modified Date
2 years ago
Owned By
andy_boutte
Component
maint
Type
Bug
andy_boutte (Andy Boutte)
Andy Boutte commented 3 years ago

In Python 3 you can no longer use 'unicode' for Unicode text because all strings are now unicode.

The whole 'canonical' function can be removed but for now I am testing by updating the method to be the following:

def canonical(self, aString):
    if self.p4.charset == &quot;utf8&quot;:
        return aString.lower()
    else:
        return aString.lower()
Reply