Swarm - DoNotSubmit

All Activity Followed Activity Reviews Commits Comments Jobs
	11 years agoMatt Attaway approved review 8324 for main Fixed regex matching. Command-line options parsing and changelist dictionary retrieval implemented. Does not check for Python version. Works with Pyt...hon3.3+. «
	14 comments

	11 years agoMatt Attaway approved review 8329 for main Added completed bash script. License file.
	2 comments

	12 years agoJoe Robinson committed change 8330 into main Fixed sha-bang.
	Add a comment

	12 years agoMatt Attaway requested revisions to review 8329 for main Clean up your sha-bang and I think you are set.
	2 comments

	12 years agoMatt Attaway commented on review 8329 (DoNotSubmit.sh, line 2) for main Why two sha-bang declarations? Pick one!
	2 comments

	12 years agoMatt Attaway joined review 8329 for main Added completed bash script. License file.
	2 comments

	12 years agoJoe Robinson requested review 8329 for main Added completed bash script. License file.
	2 comments

	12 years agoJoe Robinson committed change 8328 into main Added completed bash script. License file.
	Add a comment

	12 years agoJoe Robinson commented on change 8327 for main Ssshhh, Python will hear you and his feelings will get hurt.
	2 comments

	12 years agoMatt Attaway commented on change 8327 for main Ruby so much prettier than Python. This script way the hell more legible.
	2 comments

	12 years agoJoe Robinson committed change 8327 into main Ruby DoNotSubmit script complete.
	2 comments

	12 years agoJoe Robinson committed review 8324 for main File housekeeping - cleaned up spacing and obsolete comments. Removed '-u' flag. 'userArg' now part of admin options.
	14 comments

	12 years agoJoe Robinson committed change 8325 into main File housekeeping - cleaned up spacing and obsolete comments. Removed '-u' flag. 'userArg' now part of admin options.
	Add a comment

	12 years agoMatt Attaway commented on review 8324 (DoNotSubmit.py, line 43) for main I'd keep all that configuration in the script I think. They have to modify it anyway to set the path to p4; they can just set the perforce user too. T ... I'd keep all that configuration in the script I think. They have to modify it anyway to set the path to p4; they can just set the perforce user too. To be really nice you can optionally use th default user if they don't explicitly specify one. «
	14 comments

	12 years agoJoe Robinson commented on review 8324 (DoNotSubmit.py, line 43) for main Should I still allow the trigger to pass the name of some user? Perhaps the admin wants a particular service or admin user to request the data that is ... Should I still allow the trigger to pass the name of some user? Perhaps the admin wants a particular service or admin user to request the data that is different from the default user on the server. I could check if the user field is empty and simply not include it in the args list if None is passed. «
	14 comments

	12 years agoMatt Attaway commented on review 8324 (DoNotSubmit.py, line 21) for main http://images.wikia.com/adventuretimewithfinnandjake/images/b/b3/Kevin-Butler-Mind-Blown.gif
	14 comments

	12 years agoJoe Robinson commented on review 8324 (DoNotSubmit.py, line 21) for main Somewhere, I don't know where, there is a site that has a list of functional programs that also work as ASCII art. I'll see if I can find it later.
	14 comments

	12 years agoMatt Attaway commented on review 8324 (DoNotSubmit.py, line 21) for main http://cdn.meme.li/instances/400x/27536899.jpg
	14 comments

	12 years agoJoe Robinson commented on review 8324 (DoNotSubmit.py, line 21) for main Fear the power of my tab key! I'll fiddle with the editor's settings and find the tab-to-spaces option. I must have missed it earlier.
	14 comments

	12 years agoMatt Attaway requested revisions to review 8324 for main Bold steps forward here! Check my comments, and feel free to respond here in Swarm if you have any follow up questions.
	14 comments

	12 years agoMatt Attaway commented on review 8324 (DoNotSubmit.py, line 9) for main You can actually specify the options for them. Then they can just cut and paste this line into their trigger table.
	14 comments

	12 years agoMatt Attaway commented on review 8324 (DoNotSubmit.py, line 65) for main More crazy indentation. I generally advise sticking to spaces only so that you don't have to deal with variable tab width between editors/viewers.
	14 comments

	12 years agoMatt Attaway joined review 8324 for main Fixed regex matching. Command-line options parsing and changelist dictionary retrieval implemented. Does not check for Python version. Works with Pyt...hon3.3+. «
	14 comments

	12 years agoMatt Attaway commented on review 8324 (DoNotSubmit.py, line 21) for main Your whitespace here is cray cray.
	14 comments

	12 years agoMatt Attaway commented on review 8324 (DoNotSubmit.py, line 43) for main You don't need the name of the user; you likely cannot run commands as that person because you don't have a password. You'll need to add a variable fo ... You don't need the name of the user; you likely cannot run commands as that person because you don't have a password. You'll need to add a variable for the admin to set to specify the Perforce user to use. «
	14 comments

	12 years agoMatt Attaway commented on review 8324 (DoNotSubmit.py, line 58) for main Wait. I take it back I see the usage code.
	14 comments

	12 years agoMatt Attaway commented on review 8324 (DoNotSubmit.py, line 58) for main You should add some code to bail if the don't give you the args you need, I could be wrong but I'm not seeing anything like that here.
	14 comments

	12 years agoMatt Attaway commented on review 8324 (DoNotSubmit.py, line 37) for main You can actually force this at the top of your script. Add the line: !/bin/env python3 That will tell the system that by default it should use Python3
	14 comments

	12 years agoJoe Robinson requested review 8324 for main Fixed regex matching. Command-line options parsing and changelist dictionary retrieval implemented. Does not check for Python version. Works with Pyt...hon3.3+. «
	14 comments

	12 years agoJoe Robinson committed change 8323 into main Fixed regex matching. Command-line options parsing and changelist dictionary retrieval implemented. Does not check for Python version. Works with Pyt...hon3.3+. «
	Add a comment

projects/joe-robinson-donotsubmit

About

!/bin/env python3