| 11 years agoMatt Attaway committed change 8777 into mainTry to figure out weird command hang in Pulse.
For the time being we just kill the connection if NSTask hangs. I just wish I knew why it
was hanging.... « | |
|
|
| 11 years agoMatt Attaway committed change 8760 into mainRemove sound when sync is complete
I left it for now for the initial sync and login notifications, but it is annoying
for normal syncs.
User visi...ble change « | |
|
|
| 11 years agoMatt Attaway committed change 8759 into mainMove off of waitUntilExit when polling for changes
One of the great moments in coding where I don’t entirely
understand why this fixes things, but s...o far it appears using
isRunning checks prevents the stalled processes I was seeing
with waitUntilExit
User visible bug fix « | |
|
|
| 11 years agoMatt Attaway committed change 8723 into mainContinuously update state on opened files
Automatically checking out files is all well and good, but there’s a problem; frequently
in the course of... working on files, before you commit, files will go through a number of different
states. You may edit a file, then delete it, and then re-add it unchanged all before trying to commit.
At the end of the process in the case above nothing should happen, but if you edit a file
and never revisit it you are stuck with that initial edit.
Pulse now runs a non-destructive revert on files when it receives an event notification. This resets
the working state so that if there is a major change (from edit -> delete) we can properly catch it and
tell the system. It also is handy for dealing with added files that you then delete.
There are edge cases with this code that I’m confident are not handled correctly. The good news is
nothing should be destructive; the worse that happens is you revert -k everything and re-run reconcile.
User visible change « | |
|
|
| 11 years agoMatt Attaway committed change 8720 into mainRework reconcile methods to handle file arguments
Previously the only option was to blindly reconcile the world. Now reconciles
can be more targeted..., although there’s no code to actually do a targeted reconcile yet
in the Overseer.
Infrastructure only change « | |
|
|
| 11 years agoMatt Attaway committed change 8703 into mainConnect checkbox for auto sync to the correct action
Checking the auto-sync stopped working after I pulled the test out of the
window close event. T...his change fixes it all.
User visible bug fix « | |
|
|
| 11 years agoMatt Attaway committed change 8702 into mainAdd the ability to pause updates on a connection
After some fun today where I added a gazillion files while running automated tests
I realized there... is is much to be said for being able to pause your automated
friend.
This change adds the ability to pause updates on a connection. Syncs and file events
are not tracked while updates are paused. Paused connections are also not used when
figuring out what the state icon should be.
Also fix a bug related to all of this where a server coming online while in the connection
dialog would not cause the icon to update. We now do an icon state check after coming
out of the connection dialog. In addition, we use the proper timer when coming out of the
connection dialog, not always the sync timer.
User visible change « | |
|
|
| 11 years agoMatt Attaway committed change 8698 into main Add a method to run revert -k.
Will hook up later into the reconcile code | |
|
|
| 11 years agoMatt Attaway committed change 8692 into mainAdd auto-submit capability to Pulse
If you so choose you may now configure Pulse to automatically submit files as soon as they
are changed. This is... done as part of the file event watcher; files are opened with reconcile and
if configured to do so immediately submitted with a boilerplate commit message.
For obvious reasons auto-commit is off by default.
User visible change « | |
|
|
| 11 years agoMatt Attaway committed change 8691 into mainFix sundry connection dialog bugs
* Table text is now updated when the port changes
* Path is properly set when set using the browse button
* On cl...ose we set all of the values for the selected connection on the off chance our text field event didn’t fire
User visible bug fixes « | |
|
|
| 11 years agoMatt Attaway committed change 8690 into main Automatically append ":1666" to the end of a server if the user forgets
User visible change | |
|
|
| 11 years agoMatt Attaway committed change 8689 into main Fix bug where observers were repeatedly added, causing FSEvent watcher errors
Bug fix with no user visible change | |
|
|
| 11 years agoMatt Attaway committed change 8686 into mainSwap in new connection dialog
There’s still a fair amount of polish to do, but it’s good enough to
replace the old connection dialog.
User visib...le change « | |
|
|
| 11 years agoMatt Attaway committed change 8685 into mainUpdate connections with value from text fields in new dialog
This still feels like it needs some testing, but values entered into
the text boxes are... actually used but the connections now after
closing the dialog.
User visible change « | |
|
|
| 11 years agoMatt Attaway committed change 8684 into mainFirst steps on the new connection dialog
At this point it’s effectively a read only dialog. Changes made in the text fields are
currently ignored. I...t does look much nicer though. To view it use the appropriately named
‘??????’ menu entry.
User visible change « | |
|
|
| 11 years agoMatt Attaway committed change 8657 into mainTidy up constructors and whitespace a bit
Finally figured out the proper way to have a designated contructor in Obj-C.
Hooray for progress.
No us...er visible change. « | |
|
|
| 11 years agoMatt Attaway committed change 8656 into mainMove login check out to a thread too
At this point the only Perforce command that is running in the main thread is login from
the login dialog itsel...f. This should help keep Pulse peppy.
User visible change (less lag) « | |
|
|
| 11 years agoMatt Attaway committed change 8655 into mainPull logging out of the message parsing helpers
The logging was previously helpful, but now that I'm using
those methods heavily it's just noise.
...
No user visible change. « | |
|
|
| 11 years agoMatt Attaway committed change 8654 into mainMove connections checks into threads
Getting everything slow off of the main thread. That means you connection checks.
User visible change (in so... much as it’s less laggy now) « | |
|
|
| 11 years agoMatt Attaway committed change 8653 into main Disable/enable the login menu when appropriate
It’s pretty daft to have the login menu always active. --daftness
User visible change | |
|
|
| 11 years agoMatt Attaway committed change 8652 into mainRework login to take advantage of other clients logging in
Previously the Overseer entirely shut down operations when it noticed
that the user neede...d to login. This is all well and good if you only use Pulse,
but less helpful if use other clients too.
This change introduces a new timer that attempts ‘p4 login -s’ every few seconds to see if
there is a valid ticket. This is not unlike the timer that gets enabled when a connection is
lost.
This change also includes some WIP on submit support that I was too lazy to pull out.
User visible changelist « | |
|
|
| 11 years agoMatt Attaway committed change 8635 into mainMove reconcile and sync calls off into threads to improve UI performance
Not shockingly, running a giant p4 sync in the main thread is a bad idea. Wi...th this
change I put on my grown up pants and move all of the potentially long running commands
into their own threads.
User visible change « | |
|
|
| 11 years agoMatt Attaway committed change 8597 into mainHandle disconnected servers automatically
If Pulse loses its connection with the Perforce server it now reports that
the connection is down and star...ts a new timer to look for a live connection.
The Overseer handles all of this on its own; unlike login there’s really nothing for the user
to do.
This change also fixes a bug where the login dialog was not being properly regenerated for
connections after the first.
User visible change « | |
|
|
| 11 years agoMatt Attaway committed change 8595 into mainWIP on handling connection errors
With this change we report the errors to our delegate, but we don’t attempt to recover. That
will come with the ne...xt checkin. This change does add in the protocol for handling these errors.
User visible change « | |
|
|
| 11 years agoMatt Attaway committed change 8594 into main Custom message for completed sync after initial sync | |
|
|
| 11 years agoMatt Attaway committed change 8592 into mainAdd less aggressive notification when background processes detect need to login
Instead of popping a dialog up right in your face we use a standard n...otification
and change the status icon to indicate Pulse is unhappy. Using the login menu
item will log the user is and restart the background processes.
User visible change. « | |
|
|
| 11 years agoMatt Attaway committed change 8591 into mainMake the notification text for a single change more useful.
Pulse now gives the change number, author, and some of the change description when syncin...g a single file.
I think I might swap out the change number with the number of files changed, but that’s for later.
User visible change. « | |
|
|
| 11 years agoMatt Attaway committed change 8590 into mainAdd crude login capabilities
This is the first step toward getting the login behavior I want. Right now anytime a Peforce command
gets a login error... the Overseer ion charge notifies its delegate, which is currently the AppDelegate. The
AppDelegate then kicks off the requisite login dialog which gets the password and does the login.
There’s no error handling or feedback and the dialog pops up even when it is a background process that
hit the error.
The next step is to implement the Login menu item and the ‘need login’ tool tip and status icon.
User visible (and possibly user annoying) change « | |
|
|
| 11 years agoMatt Attaway committed change 8575 into mainAutomatically handle Unicode servers; stub out login handling
There's a lot going on in this change:
* Fixed a bug where charset was always set to n...one
* Added protocol on PLSOverseer so that something can properly handle login errors
* PLSAppDelegate implements stubs for the PLSOverseer protocol
* PLSOverseers automatically configure themselves for Unicode servers now
* Ripped out handleCommonErrors: because it turns out I want to handle the
same error in multiple ways.
Next step is to properly handle 'p4 login' and request a password.
User visible changes. « | |
|
|
| 11 years agoMatt Attaway committed change 8574 into mainMove message parsing smarts into P4Message.
This minimizes how much PLSOverseer knows about Perforce which
seems like a good thing from an architec...ture point of view and
makes the P4 group more reusable.
No functional change. « | |
|
|
| 11 years agoMatt Attaway committed change 8571 into mainExpand connection properties for charset; add method to crudely handle common errors
This is the next step towards handling login and unicode errors.... The interfaces have been
widened to track the charset. I’m using a string at this point so that I can just pass in the character
set without having to test it; ‘none’ works with non-Unicode servers. The handler just logs
what it would do so that I can test the behavior.
Next step is to actually ask the user for their password and run login.
Still no real functional change. « | |
|
|
| 11 years agoMatt Attaway committed change 8570 into mainStart capturing and returning stderr as well as stdout
In preparation for handlilng loggin in, start capturing and passing stderr
to the calling met...hod in the error portion of the P4Message. « | |
|
|
| 11 years agoMatt Attaway committed change 8569 into mainRejigger P4Connection to use a standard return type
The previous mechanism made it hard to return anything but error messages. With the P4Message
ob...ject we can return dictionaries, lists, and messages with a single object. I can use the new object
more intelligently, but that’s for another change.
I also reorganized the code to separate the ‘p4’ layer off into its own potentially reusable bucket.
No functional change. « | |
|
|
| 11 years agoMatt Attaway committed change 8555 into main Replace hardcoded defaultsfor new connections with user specific values. | |
|
|
| 11 years agoMatt Attaway committed change 8553 into main Add a bit of extra logging while I work out this occasional hang | |
|
|
| 11 years agoMatt Attaway committed change 8552 into mainProperly pluralize when handling just one changelist.
I probably need to rethink the notification titles; changelist counts are less useful
when mo...st syncs are just one changelist. « | |
|
|
| 11 years agoMatt Attaway committed change 8544 into main Hardcode P4IGNORE for now to properly ignore files taht should be ignored | |
|
|
| 11 years agoMatt Attaway committed change 8537 into mainRework Pulse startup to (sorta) support real users
Instead of repopulating the system with my test data it now pops up the
connection dialog if ther...e are no existing connections.
This change also fixes a bug where the PLSConnection object wasn’t being
refreshed when settings were changed on an Overseer. « | |
|
|
| 11 years agoMatt Attaway committed change 8536 into main Save out connections when closing the dialog | |
|
|
| 11 years agoMatt Attaway committed change 8521 into main Set a more sane initial position for the connection dialog | |
|
|
| 11 years agoMatt Attaway committed change 8520 into main Make the Connections dialog remember its position and size | |
|
|
| 11 years agoMatt Attaway committed change 8519 into mainFinally add a connections dialog to manage connections
It’s taken a week to figure out how to manage windows and tabelviews,
but this change adds a... crude connection dialog to add and remove connections
as well as save them out to the preferences file. More to do to make it
more sane, but it works for now! « | |
|
|
| 11 years agoMatt Attaway committed change 8518 into main Pulling out the C++ API for now; I’m going to stick to the command line for now. | |
|
|
| 11 years agoMatt Attaway committed change 8511 into mainGet a very crude form of reconcile and sync working.
Continuing in my purely experimental mode, this change adds rough versions
of the core features...:
1) Every 5 seconds a timer fires and runs sync to grab new files. The user
is made aware of the synced files via an OS X notification.
2) When files are modified ‘p4 reconcile’ is kicked off on the entire workspace
Of course there is no error or sanity checking, but it is technically usable
for very rough definitions of usable. « | |
|
|
| 11 years agoMatt Attaway committed change 8509 into mainAdd support for loading multiple connections
The code is rough, but Pulse can now load up and start watching multiple
paths, each associated with a... separate Perforce server. Also cleaned up
some white space and normalized the ‘*’ used to denote pointers. « | |
|
|
| 11 years agoMatt Attaway committed change 8506 into mainPull model out of controller; disable dock icon
No functional change, but the code is moderately more sane. This
change introduces an Overseer objec...t that is responsible for maintaining
one path/Port/User/Client combination. All of the delegation responsibilities
move to the Overseer, as does FileSystemWatcher configuration.
Overall this just sets me up to actually monitor multiple paths. « | |
|
|
