Swarm - Tsaukpaetra

All Activity Followed Activity Reviews Commits Comments Jobs
	7 years agoTsaukpaetra commented on change 23234 for p4-jenkins:main thanks. I'm hoping this will help troubleshooting other weirdness happening in Jenkins.
	1 comment

	7 years agoTsaukpaetra commented on review 23183 (PerforceScm.java) for p4-jenkins:main yeah, I'm not sure what Jenkins is doing in our case other than returning Jenkins' root. Perhaps the key is that I'm setting a custom workspace locati ... yeah, I'm not sure what Jenkins is doing in our case other than returning Jenkins' root. Perhaps the key is that I'm setting a custom workspace location in the job and that's confusing Jenkins? «
	5 comments

	7 years agoTsaukpaetra requested review 23186 for p4-jenkins:main Add configuration parameter for choosing whether to allow auto-submission of config changes to perforce. This can avoid creating floods of changeli...
	2 comments

	7 years agoTsaukpaetra requested further review of 23183 for p4-jenkins:main Re-submitted the file to the shelve with only the intended updates for this revision.
	5 comments

	7 years agoTsaukpaetra updated files in review 23183 for p4-jenkins:main Avoid resetting workspace root during polling operation. Ideally, workspaces shouldn't need to be reconfigured every poll, but adjusting the polling l...
	5 comments

	7 years agoTsaukpaetra requested revisions to review 23183 for p4-jenkins:main Ack, extra changes not intended in this changelist...
	5 comments

	7 years agoTsaukpaetra requested review 23183 for p4-jenkins:main Avoid resetting workspace root during polling operation. Ideally, workspaces shouldn't need to be reconfigured every poll, but adjusting the polling l...
	5 comments

	7 years agoTsaukpaetra requested review 23181 for p4-jenkins:main Allow expandedDesc to be used if only Description has been set. This can occur in the "Save Configuration" beta functionality.
	1 comment

	7 years agoTsaukpaetra liked a comment on review 23147 for Tsaukpaetra-p4jenkins:main You would need to merge down the latest changes to your branch, then copy up you changes to the parent and shelve them for review. I only see changes ... You would need to merge down the latest changes to your branch, then copy up you changes to the parent and shelve them for review. I only see changes/reviews on the parent branch not everyones private branches. «
	6 comments

	7 years agoTsaukpaetra commented on review 23147 for Tsaukpaetra-p4jenkins:main ok, so I need a shelved changelist on the parent branch, gotcha. I'll see what I can do...
	6 comments

	7 years agoTsaukpaetra commented on review 23147 for Tsaukpaetra-p4jenkins:main @paul_allen I guess I just don't really understand according to the doc located at https://swarm.workshop.perforce.com/files/guest/perforce_software/c ... @paul_allen I guess I just don't really understand according to the doc located at https://swarm.workshop.perforce.com/files/guest/perforce_software/contributing.md seems to indicate merely requesting a review should be all I need to do after committing changes. Is this incorrect? If so, I guess I'm emailing support to fix the docs and tell me what I did wrong, as far as I can tell everything needed to know about this request is publicly available (confirmed by incognito mode), so I don't know what else needs to be done.... «
	6 comments

	7 years agoTsaukpaetra commented on review 23147 for Tsaukpaetra-p4jenkins:main It's not an alternate workspace root, it's the workspace root that jenkins sets up according to the profile in the job configuration. Every time a wor ... It's not an alternate workspace root, it's the workspace root that jenkins sets up according to the profile in the job configuration. Every time a workspace poll occurs, it ends up re-writing the client definition (and the workspace root) to Jenkin's working directory. More details in my ticket there: https://issues.jenkins-ci.org/browse/JENKINS-46908 I'm not sure why this branch is private, I can't find any settings for that at all (and again, the contribution document doesn't mention this at all :( ) I'll try adding you as a member? «
	6 comments

	7 years agoTsaukpaetra commented on review 23147 for Tsaukpaetra-p4jenkins:main Since I have no idea how to attract reviewers... Um... @paul_allen ? Is mentioning active users the right thing? Contribution info docs are really va ... Since I have no idea how to attract reviewers... Um... @paul_allen ? Is mentioning active users the right thing? Contribution info docs are really vague, sorry if I'm misstepping. «
	6 comments

	7 years agoTsaukpaetra committed change 23166 into Tsaukpaetra-p4jenkins:main Merge down from main
	Add a comment

	7 years agoTsaukpaetra requested review 23165 for Tsaukpaetra-p4jenkins:main Add configuration parameter for choosing whether to allow auto-submission of config changes to perforce.
	Add a comment

	7 years agoTsaukpaetra committed change 23164 into Tsaukpaetra-p4jenkins:main Add configuration parameter for choosing whether to allow auto-submission of config changes to perforce.
	Add a comment

	7 years agoTsaukpaetra requested review 23163 for Tsaukpaetra-p4jenkins:main Allow expandedDesc to be used if only Description has been set
	Add a comment

	7 years agoTsaukpaetra committed change 23162 into Tsaukpaetra-p4jenkins:main Allow expandedDesc to be used if only Description has been set
	Add a comment

	7 years agoTsaukpaetra requested review 23147 for Tsaukpaetra-p4jenkins:main Try to avoid setting a different workspace root on the client.
	6 comments

	7 years agoTsaukpaetra committed change 23146 into Tsaukpaetra-p4jenkins:main Try to avoid setting a different workspace root on the client.
	Add a comment

	7 years agoTsaukpaetra committed change 23141 into Tsaukpaetra-p4jenkins:main "Forking branch Main of p4-jenkins to Tsaukpaetra-p4jenkins."
	Add a comment

Change	User	Description	Created
23180	Tsaukpaetra	Add configuration parameter for choosing whether to allow auto-submission of config change...	7 years ago	View Review
23179	Tsaukpaetra	Avoid resetting workspace root during polling operation. Ideally, workspaces shouldn't ne...	7 years ago	View Review
23178	Tsaukpaetra	Allow expandedDesc to be used if only Description has been set. This can occur in the "Sa...	7 years ago	View Review

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

I am the author, and
I change the state of a review
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed

Tsaukpaetra

Profile Settings

Reviews

Time Display

Email me when:

users/Tsaukpaetra

Tsaukpaetra

Profile Settings

Reviews

Time Display

Email me when: