Helix SwarmHelix Swarm

jim_brower

jim_brower (jim_brower)
  • 0
    Followers
  • 0
    Following
  • 0
    Projects
Full Name
jim_brower
Email address
jimrabrower@gmail.com
Followers
  • Activity
  • Shelves
  • Settings
  • Notifications

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
11 years agojim_brower committed change 10138 into
Added BSD license to ForceRmdir.
Add a comment
11 years agojim_brower committed change 10137 into
Added BSD license to several projects.
Add a comment
11 years agojim_brower committed change 10132 into
Moved sendrequest.rb and added webhook-wrapper
Add a comment
11 years agojim_brower requested review 10034 for
sendrequest.rb now supports the three requested trigger types.
   URLs are extracted from specific keys on the Perforce server.
  &nbs...p;Currently the user must create the keys manually before using the trigger.
   The program will not explode if the corresponding key is empty. «
1 comment
11 years agojim_brower committed change 10033 into
sendrequest.rb now supports the three requested trigger types.
   URLs are extracted from specific keys on the Perforce server.
  &nbs...p;Currently the user must create the keys manually before using the trigger.
   The program will not explode if the corresponding key is empty. «
Add a comment
11 years agojim_brower requested review 10029 for
Added the first version of the 'webhook' trigger.
   Correctly POSTs to my test rails app, but the array of files is currently a
  &nb...sp;string. «
1 comment
11 years agojim_brower committed change 10028 into
Added the first version of the 'webhook' trigger.
   Correctly POSTs to my test rails app, but the array of files is currently a
  &nb...sp;string. «
Add a comment
11 years agojim_brower requested review 9971 for
CreateThumbnails.rb is feature complete.
1 comment
11 years agojim_brower committed change 9970 into
CreateThumbnails.rb is feature complete.
Add a comment
11 years agojim_brower committed change 9961 into
CreateThumbnails functions properly, options and optimizations need to be added.
Add a comment
11 years agojim_brower requested review 9956 for
Modified CreateThumbnails.rb
Add a comment
11 years agojim_brower committed change 9955 into
Modified CreateThumbnails.rb
Add a comment
11 years agojim_brower requested review 9845 for
Added non-functional thumbnail trigger
4 comments
11 years agojim_brower committed change 9844 into
Added non-functional thumbnail trigger
Add a comment
11 years agojim_brower commented on change 9836 (ForceClientOptions.rb) for

I tried to design it a little bit better this time, but I am still not particularly satisfied with it. I feel like it should be short since it's a scr

...

I tried to design it a little bit better this time, but I am still not particularly satisfied with it. I feel like it should be short since it's a script, but I also feel the desire to turn my options array into a class and wrap it up better. Do you think the way it is now is better than the last iteration? Have I gone too far with trying to make it "better"?

 «
2 comments
11 years agojim_brower requested review 9837 for
Made significant changes to ForceClientOptions.
   It now relies less on magic numbers, and should be able to handle the inclusion of future... options without exploding.
   It's also much longer now, for better or for worse. «
Add a comment
11 years agojim_brower committed change 9836 into
Made significant changes to ForceClientOptions.
   It now relies less on magic numbers, and should be able to handle the inclusion of future... options without exploding.
   It's also much longer now, for better or for worse. «
2 comments
11 years agojim_brower commented on change 9829 (ForceClientOptions.rb) for

I know there will be issues with the command line arguments since I didn't use an awesome gem to do them. Putting an invalid argument will cause it to

...

I know there will be issues with the command line arguments since I didn't use an awesome gem to do them. Putting an invalid argument will cause it to give an ugly error, and you could potentially put duplicate arguments where the last one would be the one that's used.

 «
5 comments
11 years agojim_brower requested review 9830 for
Added trigger to let you force any client options you want.
   Not exactly proud of the implementation, but it seems to work.
Add a comment
11 years agojim_brower committed change 9829 into
Added trigger to let you force any client options you want.
   Not exactly proud of the implementation, but it seems to work.
5 comments
11 years agojim_brower requested review 9828 for
Fixed regular expression that checked for p4sandbox client name
   Eliminated use of temp file, changed are now made in a string
1 comment
11 years agojim_brower committed change 9827 into
Fixed regular expression that checked for p4sandbox client name
   Eliminated use of temp file, changed are now made in a string
Add a comment
11 years agojim_brower commented on review 9826 (ForceRmdir.rb, line 34) for

Not quite sure what you want, but I'll try to outline what I think you mean. Please clarify if I'm mistake.

  1. Read original as I am currently, but wri
...

Not quite sure what you want, but I'll try to outline what I think you mean. Please clarify if I'm mistake.

  1. Read original as I am currently, but write to a string instead of to a new file
  2. Make changes the same as I am currently, but those changes will be stored in one large string rather than a new file.
  3. Regardless of whether or not normdir was found, overwrite the original file with the contents of the string I've been building.

Or should I still dump the string into a temp file at the end, then change the temp filename to the original filename? I'm not sure about this since you said I should avoid creating temp files.

 «
5 comments
11 years agojim_brower requested review 9826 for
Added trigger to force rmdir client option
5 comments
11 years agojim_brower committed change 9825 into
Added trigger to force rmdir client option
Add a comment
Change User Description Created
9838 jim_brower Shelving CreateThumbnails.rb 11 years ago Request Review
9831 jim_brower Made argument handling in ForceClientOptions.rb more robust. 11 years ago Request Review

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default
Check all
I change the state of a review
I am the author, and
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed