9 years agorichard_baum commented on change 18209 for perforce-software-sdp:dev Thanks - works like a charm now -- just like the other scripts :-) | ||
1 comment | ||
9 years agorichard_baum (on behalf of russell_jackson) committed change 18209 into perforce-software-sdp:dev Added missing auto source of p4_vars to eliminate the need to use p4master_run. Missed in early changes to support that behavior. | ||
9 years agorichard_baum approved review 18207 for perforce-software-sdp:dev Added missing auto source of p4_vars to eliminate the need to use p4master_run. Missed in early changes to support that behavior. | ||
9 years agorichard_baum requested review 18201 for perforce-software-sdp:dev Removed hard-coded /p4 path for server.id file location. This fixes "-test" mode so server.id file is written to the correct location. Without... this it is written to /p4 where there could be an installation with the same instance ID. In that case the server.id file could get overwritten with different data. If there is not an existing instance an error message would be displayed. Now neither of these should occur :-) Also fixed some typos. « | ||
9 years agorichard_baum (on behalf of tom_tyler) committed change 17312 into perforce-software-sdp:dev Updated Version and Release Notes for release. | ||
9 years agorichard_baum approved review 17308 for perforce-software-sdp:dev Updated Version and Release Notes for release. | ||
9 years agorichard_baum opened an issue on review 11559 for perforce-software-sdp:main We do need to update the doc for this, though... | ||
9 years agorichard_baum approved review 11559 for perforce-software-sdp:main Reviewed all the individual changes here. Everything required for this useful feature change appears to be in place and ready to go. | ||
Change | User | Description | Created | ||
---|---|---|---|---|---|
18200 | richard_baum | Removed hard-coded /p4 path for server.id file location. This fixes "-test" mode s...o server.id file is written to the correct location. Without this it is written to /p4 where there could be an installation with the same instance ID. In that case the server.id file could get overwritten with different data. If there is not an existing instance an error message would be displayed. Now neither of these should occur :-) Also fixed some typos. #review-18201 « |
9 years ago | View Review |
Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).