Loading...
Helix SwarmHelix Swarm
Loading...

swarm-user

swarm-user (swarm-user)
  • 1
    Followers
  • 0
    Following
  • 0
    Projects
Full Name
swarm-user
Email address
opensource+swarm-user@perforce.com
Followers
3laaaioh
  • Activity
  • Shelves
  • Settings
  • Notifications

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
2 years agoswarm-user created workflow (Global Workflow) for
2 years agoswarm-user modified SDP-778 for
NFS sharing /p4/common causes upgrade.sh to classify major upgrade as patch.
Add a comment
2 years agoswarm-user modified SDP-919 for
p4verify.sh: Added -ignores <regex_ignores_file>' option.
Add a comment
2 years agoswarm-user modified SDP-918 for
Add db.storage to list of tables to checkpoint on an edge.
Add a comment
2 years agoswarm-user modified SDP-787 for
Define client.sendq.dir as part of template config variables

Important for parallel syncs and reducing contention
Add a comment
2 years agoswarm-user modified SDP-244 for
Define client.readonly.dir configurable and create dir on hxlogs volume.

See also: SDP-243.
Add a comment
2 years agoswarm-user modified SDP-243 for
Define client.readonly.dir configurable and create dir on /hxlogs volume.

See also: SDP-244.
Add a comment
2 years agoswarm-user modified SDP-917 for
Upgrade on Ubuntu does not attempt 'sudo setcap'.
Add a comment
2 years agoswarm-user modified SDP-916 for
Enhance granularity and extractability of timing info for p4verify.sh.
Add a comment
2 years agoswarm-user modified SDP-915 for
Add -paths option to p4verify.sh to verify specified paths.
Add a comment
2 years agoswarm-user modified SDP-912 for
Added P4D r23.1 OOM defense in SDP upgrade.sh.

Per release notes:
#2397436 (Job #112553) **
    The server on Linux can now protect itself... from the OOM killer
    during database writes.  This happens automatically when the
    necessary capabilities have been granted to the server executable,
    e.g. "sudo setcap 'CAP_SYS_RESOURCE=+ep' p4d".  A new server
    startup log entry is now written with details about the detected
    level of support for features like this. «
Add a comment
2 years agoswarm-user modified SDP-868 for
Fix call to p4login.bat in configure_new_server.bat (missing instance arg).
Add a comment
2 years agoswarm-user modified SDP-859 for
Windows template_configure_new_server.bat set net.autotune=0

This seems to be causing quite frequent hangs, especially over
slow links and with lar...ge submits or syncs (e.g. UE5 size of 100k+ files
100GB+). «
Add a comment
2 years agoswarm-user modified SDP-900 for
Add support for r23.1 hyper-parallel multi-thread per db table checkpoint capability.
Add a comment
2 years agoswarm-user modified SDP-909 for
p4verify.sh: Add safety feature to avoid verifying cache mode replica by default.
Add a comment
2 years agoswarm-user modified SDP-903 for
Broken / changed behavior in p4verify log name rotation.

In https://swarm.workshop.perforce.com/files/guest/perforce_software/sdp/dev/Server/Unix/p4/...common/bin/p4verify.sh?v=43 at line 589 the OldLogTimestamp is set to "$(ls -l --time-style +'%Y%m%d-%H%M%S' "$Log" | awk '{print $6}')". However, this does not work on (at least) Red Hat and Rocky 8.7 as the "print $6" output is the file size. Instead, $7 is needed.

In the same file at line 590 the OldLog is set to "$LOGS/p4verify.${OldLogTimestamp}.log" but prior to this change the old log file was "${LogToRotate}.${Datestamp}". As an example (after locally addressing the issue above), the new format naming results in p4verify.2023-05-09_09-40-05.log whereas the old name was p4verify.log.2023-05-09_09-28-17 so the files no longer sort the same. I *think* it was an intentional change to retain the .log extension on files but don't see it called out on https://swarm.workshop.perforce.com/projects/perforce-software-sdp/jobs/SDP-829 unless it fell under "general log file handling"?

Additionally, the previous time format was '%Y-%m-%d_%H-%M-%S' but is now '%Y%m%d-%H%M%S' so there aren't as many spacers for readability. «
Add a comment
2 years agoswarm-user modified SDP-907 for
Added '-Q <MaxTotalPullQueueSize>' option to p4verify.sh.
Add a comment
2 years agoswarm-user modified SDP-904 for
p4verify.sh: Add '-w <Wait>' and '-q <MaxActivePullQueueSize>' options.
Add a comment
2 years agoswarm-user committed change 29537 into
Added: //.swarm/attachments/0000000109-Screen-Shot-2023-04-25-at-7.35.42-AM.png
Add a comment
2 years agoswarm-user modified SDP-797 for
sync_replica.sh to maintain offline_db on a 'ham' replica.

The sdp_sync.sh script maintains the offline_db on a regular
an HA that uses the first fo...rm of the journalPrefix (per
the journalPrefix standard).  That form is: /p4/N/checkpoints/p4_N

Minor adjustment is needed for this script to maintain the
offline_db on a 'ham' replica, a metadata-only HA relpica
with lbr.replication=shared that shares /hxdepots over NFS
with its P4TARGET server. replica that uses the second form of
the journaPrefix.  That form is:

/p4/N/checkpoints.<ShortServerID>/p4_N.<ShortServerID>

Adjustments needed:
* On a ham replica, we don't need the rsync, due to the NFS
sharing. So if lbr.replication=1, skip the rsync.
* Load the latest checkpoint taken on the master (and in the
first form of the checkpoints direcotry) into the local
offline_db of the standby.

See also: SDP-676 «
Add a comment
2 years agoswarm-user modified SDP-888 for
mkrep.sh gets generated ServerID wrong if '-f' used when not daisy chaining.
Add a comment
2 years agoswarm-user modified SDP-813 for
mkrep.sh: Add preflight check for running on master and P4MASTER_ID OK.
Add a comment
2 years agoswarm-user modified SDP-880 for
p4login expands only first comma in SDP_AUTOMATION_USERS var.
Add a comment
2 years agoswarm-user modified SDP-872 for
For parallel checkpoint replay, need to add '-N'.

We need to add the '-N' parameter with '-jrp' when recovering the offline,
database since there is...n't a database in place for the command to read the
setting from. «
Add a comment
2 years agoswarm-user modified SDP-878 for
p4login fails to get P4TARGET if replica ServerID is subset of another.

The p4login script has a bad regex that needs to be tightened.

If the Serv...erID of current replica is a subset of the name of
another server spec, both values are returned and the p4login script
fails. «
Add a comment
2 years agoswarm-user modified SDP-876 for
Enhanced docs re: MAILTO/MAILFROM settings in Instance Vars file.
Add a comment
2 years agoswarm-user modified SDP-860 for
Directories that differ only by case aren't being caught by script.
Add a comment
2 years agoswarm-user modified SDP-868 for
Fix call to p4login.bat in configure_new_server.bat (missing instance arg).
Add a comment
2 years agoswarm-user modified SDP-867 for
Change server.extensions.dir to /hxlogs.
Add a comment
2 years agoswarm-user modified SDP-866 for
Add configurables for Helix Authentication Service (HAS).
Add a comment
2 years agoswarm-user modified SDP-840 for
Set net.paralllel.{max,threads} to reasonable defaults.

Also set net.parallel.sync.svrthreads.
Add a comment
2 years agoswarm-user modified SDP-859 for
Windows template_configure_new_server.bat set net.autotune=0

This seems to be causing quite frequent hangs, especially over
slow links and with lar...ge submits or syncs (e.g. UE5 size of 100k+ files
100GB+). «
Add a comment
2 years agoswarm-user modified SDP-865 for
Enhance robustness of systemctl management of p4d/p4p/p4broker.
Add a comment
2 years agoswarm-user modified SDP-864 for
Added '-delay <delay>' option to load_checkpoint.sh to delay call to p4verify.sh.

This is a workaround for p4d server job079842 (possibly to b...e fixed in P4D 2023.1). «
Add a comment
2 years agoswarm-user modified SDP-858 for
mkrep.sh: Add '-os' option to overwrite an existing ServerID.
Add a comment
2 years agoswarm-user modified SDP-857 for
mkrep.sh: Add preflight check to avoid overwriting existing ServerID.
Add a comment
2 years agoswarm-user modified SDP-777 for
mkrep.sh: Support daisy chaining of forwarding replicas.
Add a comment
2 years agoswarm-user modified SDP-624 for
Add mkrep.sh support for '<N>' per standard: <HelixServerTag>_<ReplicaTypeTag>[<N>]_<SiteTag>'

The Server Spec naming... standard allows for multiple edges/replicas to
be defined for the same site tag.  For example, you might have:

* p4d_edge_tok - An edge server in Tokyo
* p4d_edge2_tok - A second edge server in Tokyo
* p4d_edge3_tok - A third edge server in Tokyo

mkrep v2.7.x supports only the first example that doesn't use the
optional numeric integer. The second and third examples can't
be created with mkrep.sh presently.

Ref: Server Spec Naming Standard: https://swarm.workshop.perforce.com/projects/perforce-software-sdp/view/main/doc/SDP_Guide.Unix.html#_server_spec_naming_standard «
Add a comment
2 years agoswarm-user modified SDP-862 for
Adjust p4pcm.pl so it does not require a local perl build.
Add a comment
2 years agoswarm-user modified SDP-861 for
mkdirs.sh now creates crontab for proxy-only installs.
Add a comment
2 years agoswarm-user modified SDP-776 for
Add support for parallel checkpoint ops with -jcp/-jdp/-jrp.

When parallel checkpoints are added to p4d, the SDP will need
to adapt to expose parall...el checkpoint feature (with the usual
$P4D_VERSION check to only attempt to use it if the p4d version
is new enough to support it).

To define the number of threads, supply the -N option and/or
interact with the db.checkpoint.threads configurable. «
Add a comment
9 years agoswarm-user committed change 16238 into
"Forking branch Main of perforce-software-p4ruby to thomas_gray-p4ruby."
Add a comment
9 years agoswarm-user committed change 16233 into
"Forking branch Main of perforce-software-p4java to gromopetr-p4java."
Add a comment
9 years agoswarm-user committed change 16197 into
Added: //.swarm/attachments/0000000045-sockpuppet_avatar.png
Add a comment
9 years agoswarm-user committed change 16183 into
Deleted: //.swarm/attachments/0000000043-sockpuppet.jpg
Add a comment
9 years agoswarm-user committed change 16178 into
Added: //.swarm/attachments/0000000044-sockpuppet_avatar.png
Add a comment
9 years agoswarm-user committed change 16177 into
Added: //.swarm/attachments/0000000043-sockpuppet.jpg
Add a comment
9 years agoswarm-user committed change 16166 into
Added: //.swarm/attachments/0000000042-AssetStoreBanner.jpg
Add a comment
9 years agoswarm-user committed change 16165 into
Added: //.swarm/attachments/0000000041-p4connect_icon.jpg
Add a comment
9 years agoswarm-user committed change 16149 into
"Forking branch Main of perforce-software-workshop to thomas_gray-workshop."
Add a comment
Change User Description Created
31343 swarm-user Added default P4ALIASES for perforce OS user to SDP.

#review-31256 		11 days ago View Review
31278 swarm-user Added default P4ALIASES for perforce OS user to SDP.

#review-31256 		about a month ago View Review
31265 swarm-user Added default P4ALIASES for perforce OS user to SDP.

#review-31256 		2 months ago View Review
31264 swarm-user Added default P4ALIASES for perforce OS user to SDP.

#review-31256 		2 months ago View Review
31263 swarm-user Added default P4ALIASES for perforce OS user to SDP.

#review-31256 		2 months ago View Review
31257 swarm-user Added default P4ALIASES for perforce OS user to SDP.

#review-31256 		2 months ago View Review
30605 swarm-user Added gen_sudoers.sh script to generate a sudoers file for perforce OSUSER.

This can ge...nerate a full more secure limited sudoers file.

Previously, adding a sudoers entry for the OSUSER (usually 'perforce') was done only by the Helix Installer. In the Helix Installer variant, a single "one-size-filts-all" sudoers file was used, with the following characteristics:
* The instances for Helix Core services were referenced with a '*' wildcard to match all SDP instances, which has since been determined to introduce a vulnerability. In this new script, the wildcard is replaced with separate entries for each SDP instance.
* There were entries for all known paths of utilities like lslocks, setcap, and getcap. This new script generates the correct path valid for the current machine.

With this change, the functionality will be available in the SDP directly. This new gen_sudoers.sh script can be called by mkdirs.sh directly to update the sudoers file each time a new SDP instance is added, if the new '-fs' (full sudo) or '-ls' (limited sudoers) entries are used. There is no change to the default behavior of mkdirs.sh; only a change if new options are utilized.

This script comes with docs and examples for the new script as well as doc changes for mkdirs.sh. (Also added missing documentation for the '-no_enable' option).

Further changes needed:
* Add doc reference in SDP_Guide.Unix.adoc «		 6 months ago View Review
30604 swarm-user Added script to generate more secure limited sudoers file.

#review-30603 		6 months ago View Review
30560 swarm-user Fixed issue with '-no_cron' behavious not exactly matching the doc.

Desired behaviour i...s that crontab is always generated and always
moved to the correct location in the SDP structure, regardless of
the '-no_cron' option.  The only thing affected by the -no_cron option
is now whether the crontab file is loaded to become active.

#review-30559 «		 7 months ago View Review
30436 swarm-user Added undocumented support for /opt/perforce/helix-sdp package directory.

#review-30435...

With this change, mkdirs.sh behavior is changed depending on the pre-existence of the
directory /opt/perforce/helix-sdp, the future package install location.  The
/opt/perforce/helix-sdp folder is not created by design, effectively making support
for the package structure a Tech Preview (i.e. Beta) feature.  This change provides
behaviors needed to support package installation that also dovetail with goals of
decoupling the /p4/common and /p4/sdp folders from NFS in NFS environments.

If the /opt/perforce/helix-sdp is created with proper permissions and user/group
ownersihp before mkdirs.sh is run, new behaviors apply.  The proper ownership
and permissions are:

/opt/perforce/helix-sdp - root:perforce, 775 perms. Allows perforce user
to manage subdirs, e.g. common, downloads, helix_binaries, p4/sdp.

/opt/perforce/helix-sdp/sdp - root:root, 755 perms. This is the immutable
area, an extract of the SDP tarball and no additional files. This root-managed
area is intended to be updated only by OS package upgrades, and cannot be
affected by the perforce user.

These folders in the structure are modifiable by the perforce user (owned by
perforce:perforce), and will contain generated files, symlinks,
and possibly even local custom files.

* /opt/perforce/helix-sdp/downloads, for unpacking SDP tarballs for upgrades.
* /opt/perforce/helix-sdp/helix_binaries, contains get_helix_binaries.sh, p4*.
* /opt/perforce/helix-sdp/p4/sdp - A copy of /opt/perforce/helix-sdp/sdp,
owned by perforce:perforce rather than root:root.

In this version, the following behaviour changes occur if /opt/perforce/helix-sdp
exists when this script is run:

* The /p4/sdp symlink points to /opt/perforce/helix-sdp/p4/sdp rather than
/hxdepots/sdp.
* The /p4/common symlink points to /opt/perforce/helix-sdp/p4/sdp/Server/Unix/p4/common
rather than /hxdepots/p4/common.

In this beta version, if run in an environment where those /p4/common and /p4/sdp
symlinks already exist, the symlinks are NOT changed even if /opt/perforce/helix-sdp
exists.

This is Phase 1 if a multi-phased release of this feature.  Phase 1 will support
only greenfield installations where /opt/perforce/helix-sdp is created externally
to this script. (Targeted for SDP 2024.1 Patch 1, July 2024)

In Phase 2, the /opt/perforce/helix-sdp will be created by this script in greenfield
installations with a documented '-pkg' option (if run as root), and sdp_upgrade.sh
will migrate to this structure if and only if /opt/perforce/helix-sdp exists. Targeted
for SDP 2024.1 Patch 2 (Summer 2024).

In Phase 3, this will be integrated into the OS package installation mechanism for
Rocky9+ and Ubuntu 22.04+, possibly others.  (Targeted for SDP 2025.1+.)

SDP-1069: Decouple /p4/common and /p4/sdp from NFS.

The above captures the initial plan.  See this wiki page with more updated information
as it evolves:
https://perforce.atlassian.net/wiki/spaces/PROS/pages/936542265/SDP-1069+Decouple+SDP+from+NFS «		 9 months ago View Review
30425 swarm-user Modified through swarm. #review-30424

Major changes. Effectively a new approach. Signif...icant performance improvements. Specifically:
 * Change from time-last-modified to time-last-accessed.
 * Replace perl based find code with effectively equivalent shell code. Operates at least 7 times faster with smaller resource footprint than the perl code.
 * Threshold parameters can be specified as percentage of total disk space.
 * Enhanced parameter validation.
 * Enhanced log information for better performance tracking and debug support.
 * Added check so that a new run does not interrupt a run in progress.
 * Updated help information to reflect new technologies and capabilities.
 * Added internal algorithm related comments to aid future support/ enhancements.
 * Minor code consistency changes. Mostly adding support functions to standardize. «		 9 months ago View Review
30317 swarm-user mkdirs.sh v5.0.0:
* Added service initialization (systemd or SysV) by default if running a...s root.
* Added '-no_systemd' option to not use systemd.
* Added '-no_init' option to skip any/all service inititalization.
* THe '-no_init' is implied with '-test' (and with undo '-R' option).
* Added SELinux handling for services installed with systemd.

#review-30316 @robert_cowham @mark_zinthefer @will_kreitzmann «		 10 months ago View Review
30316 swarm-user mkdirs.sh v5.0.0:
* Added service initialization (systemd or SysV) by default if running a...s root.
* Added '-no_systemd' option to not use systemd.
* Added '-no_init' option to skip any/all service inititalization.
* THe '-no_init' is implied with '-test' (and with undo '-R' option).
* Added SELinux handling for services installed with systemd.

#review @robert_cowham @mark_zinthefer @will_kreitzmann «		 10 months ago Request Review
30314 swarm-user Added multi-platform support to include aarch64, and some modern OSX
variants.

Updated... default Helix binary version to r24.1, which adds aarch64 builds.

Design Goals (achieved):
* No operational procedure changes requied, so users on existing platforms
don't need to learn new tricks.
* Changes to support multiple platforms/OS architectures are contained
entirely within the /p4/sdp/helix_binaries directory. The rest of the
SDP can remain blissfully unaware of platform specifics.

New capabilities:
* Uses 'uname' to detect current OS platform, mapping it to available Helix
builds for each binary.
* Uses 'jq' if available to parse P4*.json release list files to determine
if a build is available for the detected platform.
* Adds fallback logic.  For example, there is an aarch64 build for OSX 12+, but
not for x86_64. So if on OSX 12+ on x86_64, use the older-but-compatible
OSX 10.15 build for x86_64.
* Adds a new '-d' debug mode option, as the script gets complex.

New Files:
* Added P4*.json release list files to SDP package in /p4/sdp/helix_binaries.

These *.json files are updated as part of the Helix Core release process
for p4, p4d, p4broker, and p4p (and also P4V and others not relevant to
this script).

Bonus Content:
* Silently/harmlessly introduces as-yet-unused SDP_INSTALL_ROOT variable,
a prelude to future SDP refactoring.

Tested Platforms:
* linux26x86_64
* linux26aarch64
* macosx12arm64
* macosx12x86_64; exercises fallback to maxosx1015x86_64

#review-30313 @robert_cowham @mark_zinthefer @will_kreitzmann «		 10 months ago View Review
30240 swarm-user Copy files to be dumped via p4d -jd to tmp dir first
to avoid locks on P4ROOT (or offline..._db)

SDP-1087 «		 12 months ago View Review
30217 swarm-user Copy files to be dumped via p4d -jd to tmp dir first
to avoid locks on P4ROOT (or offline..._db)

SDP-1087 «		 12 months ago View Review
30199 swarm-user Added entry for 2024.1.

Also tested a review.

#review-29682 		12 months ago View Review
30171 swarm-user #review-30170
Unix SDP docs update 		about a year ago View Review
30170 swarm-user Unix SDP docs update

@robert_cowham
@tom_tyler
@will_kreitzmann 		about a year ago Request Review
30065 swarm-user Fix FROM email function
While previous implementation with -Sfrom= do make emails appear t...o be sent from the $MAILFROM, it's still sent as <user>@<fqdn> of the p4 server.
Exchange will see this in the headers and consider it's sent from an untrusted place/domain. «		 about a year ago View Review
30037 swarm-user Enhanced upgrade.sh to better prepar for a rollback, adding
docs and skipping replay of t...he rotated journal to the offline_db
for the second journal rotation in a major version upgrade.

#review-30027 «		 about a year ago View Review
30033 swarm-user Enhanced upgrade.sh to better prepar for a rollback, adding
docs and skipping replay of t...he rotated journal to the offline_db
for the second journal rotation in a major version upgrade.

#review-30027 «		 about a year ago View Review
30032 swarm-user Enhanced upgrade.sh to better prepar for a rollback, adding
docs and skipping replay of t...he rotated journal to the offline_db
for the second journal rotation in a major version upgrade.

#review-30027 «		 about a year ago View Review
30028 swarm-user Enhanced upgrade.sh to better prepar for a rollback, adding
docs and skipping replay of t...he rotated journal to the offline_db
for the second journal rotation in a major version upgrade.

#review-30027 «		 about a year ago View Review
30017 swarm-user Added net.keepalive settings to best practices.

#review-30014 @robert_cowham @mwittenbe...rg «		 about a year ago View Review
30015 swarm-user Added net.keepalive settings to best practices.

#review-30014 @robert_cowham @mwittenbe...rg «		 about a year ago View Review
30011 swarm-user mkrep.sh v3.2.0:
* Enhanced error handling if 2+ 'standard' or 'commit' server specs exist....
* Checks for and gives error for condition where P4MASTER_ID is wrong.

#review-29735 @robert_cowham @mark_zinthefer «		 about a year ago View Review
30010 swarm-user mkrep.sh v3.2.0:
* Enhanced error handling if 2+ 'standard' or 'commit' server specs exist....
* Checks for and gives error for condition where P4MASTER_ID is wrong.

#review-29735 @robert_cowham @mark_zinthefer «		 about a year ago View Review
29907 swarm-user Contributed changes to snapshot.sh:
* Added /hxlogs to list of snapshooted volumes.
* Ad...ded explicit output formatting (text) to AWS CLI calls.

#review-29906 «		 about a year ago View Review
29808 swarm-user Changed mkdirs.sh to not require p4d on a non-p4d server.

#review-29807 		about a year ago View Review
29781 swarm-user Added a fix for issue with tab expansion of variables.

#review-29780 		2 years ago View Review
29780 swarm-user Added a fix for issue with tab expansion of variables. 2 years ago Request Review
29768 swarm-user Fixed bug where proxy_rotate.sh and broker_rotate.sh called check_dirs() looking
for p4d... directories, reporting errors.

Fixed by adding optional ServerType parameter:
1 (default) - check for dirs for a p4d server
2 - check for dirs for a standalone proxy or broker

Also addressed style issues to achieve compliance with ShellCheck v0.9.0.

#review-29767 @robert_cowham @karl_wirth «		 2 years ago View Review
29736 swarm-user mkrep.sh v2.10.0:
* Enhanced error handling if 2+ 'standard' or 'commit' server specs exis...t.
* Checks for and gives error for condition where P4MASTER_ID is wrong.

#review-29735 @robert_cowham @mark_zinthefer «		 2 years ago View Review
29731 swarm-user Added script to detect Swarm and extract Swarm version.

#review-29730 		2 years ago View Review
29687 swarm-user sync_replica.sh: Enhanced to silence spurious p4d output generated
when scanning db.confi...g to get the target host for the rsync.

Also improved error checking and error messages.

#review-29686 «		 2 years ago View Review
29683 swarm-user Added entry for 2023, testing a review.

#review-29682 		2 years ago View Review
29650 swarm-user Added clients.readonly.dir setting.

#review-29649 		2 years ago View Review
29649 swarm-user Added clients.readonly.dir setting. 2 years ago Request Review
29599 swarm-user Added configurables that are good for HAS deployments, and deemed
harmelss for non-HAS de...ployments, auth.sso.allow.passwd and
auth.sso.nonldap.

Removed explicit setting of filesys.checklinks, now deferring to p4d
default.

Set reasonable defaults for net.parallel.max, net.parallel.threads,
net.parallel.sync.svrthreads.

Changed monitor from 1->2.

Removed ref to discontinued KB link.

Fixed shellcheck compliance issues with *.sh script, and added summary
of errors and warnings.

#review-29318 @andy_boutte @robert_cowham @mark_zinthefer «		 2 years ago View Review
29575 swarm-user Merged.

#review-29520 		2 years ago View Review
29569 swarm-user Merged.
#review-29539 		2 years ago View Review
29566 swarm-user Merge
#review-29512 		2 years ago View Review
29552 swarm-user #review-29551
Fix update_limits.py to not crash when unicode characters encountered in use...r names or emails. «		 2 years ago View Review
29544 swarm-user Check for /p4/instance/bin and also -cshow output 2 years ago View Review
29543 swarm-user Check for /p4/instance/bin and also -cshow output 2 years ago View Review
29540 swarm-user Enhance p4verify to utilize die() function which will allow user to leverage AWS SNS or Pa...gerDuty #review-29539 « 2 years ago View Review
29536 swarm-user Adding correct spacing after .
 and ,  to increase readability #review-29535 		2 years ago View Review
29530 swarm-user Adding option to delivery log and alerts via PagerDuty #review-29512 2 years ago View Review
29526 swarm-user Adding optional local config directories for both instance and SDP wide configuration #rev...iew-29525 « 2 years ago View Review

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default
Check all
I change the state of a review
I am the author, and
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed