# The form data below was edited by tom_tyler
# Perforce Workshop Jobs
#
#  Job:           The job name. 'new' generates a sequenced job number.
#
#  Status:        Job status; required field.  There is no enforced or
#                 promoted workflow for transition of jobs from one
#                 status to another, just a set of job status values
#                 for users to apply as they see fit.  Possible values:
#
#                 open - Issue is available to be worked on.
#
#                 inprogress - Active development is in progress.
#
#                 blocked - Issue cannot be implemented for some reason.
#
#                 fixed - Fixed, optional status to use before closed.
#                 
#                 closed - Issue has been dealt with definitively.
#
#                 punted - Decision made not to address the issue,
#                    possibly not ever.
#
#                 suspended - Decision made not to address the issue
#                    in the immediate future, but noting that it may
#                    have some merit and may be revisited later.
#
#                 duplicate - Duplicate of another issue that.
#
#                 obsolete - The need behind the request has become
#                    overcome by events.
#
#  Project:       The project this job is for. Required.
#
#  Severity:      [A/B/C] (A is highest)  Required.
#
#  ReportedBy     The user who created the job. Can be changed.
#
#  ReportedDate:  The date the job was created.  Automatic.
#
#  ModifiedBy:    The user who last modified this job. Automatic.
#
#  ModifiedDate:  The date this job was last modified. Automatic.
#
#  OwnedBy:       The owner, responsible for doing the job. Optional.
#
#  Description:   Description of the job.  Required.
#
#  DevNotes:      Developer's comments.  Optional.  Can be used to
#                 explain a status, e.g. for blocked, punted,
#                 obsolete or duplicate jobs.  May also provide
#                 additional information such as the earliest release
#                 in which a bug is known to exist.
#
# Component:      Projects may use this optional field to indicate
#                 which component of the project a givenjob is associated
#                 with.
#
#                 For the SDP, the list of components is defined in:
#                 //guest/perforce_software/sdp/tools/components.txt
#
#  Type:          Type of job [Bug/Feature/Problem].  Required.
#                 Feature and Bug are common terms.
#                 A Problem is suspected bug, or one without a clear
#                 understanding of exactly what is broken.
#
#  Release:       Release in which job is intended to be fixed.

Job:	SDP-730

Status:	open

Project:	perforce-software-sdp

Severity:	B

ReportedBy:	Domenic

ReportedDate:	2022/01/10 11:22:05

ModifiedBy:	tom_tyler

ModifiedDate:	2022/02/06 12:05:31

OwnedBy:	Domenic

Description:
	Usage of P4P_TARGET_PORT is defined but implementation is missing / confusing.
	
	In mkdirs.cfg there is a definition for P4P_TARGET_PORT as the master's target port. However, in mkdirs.sh#100 there is a redefinition of that variable at line 1284 to "P4P_TARGET_PORT="${SSL_PREFIX}${P4MASTERHOST}:${P4_PORT}"" so it is used for more than just the master's target port. At line 1307 it is used by sed to replace REPL_P4P_TARGET_PORT in the instance_vars.template file, except that file doesn't have REPL_P4P_TARGET_PORT in it so ultimately P4P_TARGET_PORT is never actually used.
	
	Looking at CL 27512 it seems the intent was to remove REPL_P4P_TARGET_PORT? If so, the mkdirs.cfg and mkdirs.sh files also have P4P_TARGET_PORT removed to avoid confusion, and perhaps a comment added to use P4PORTNUM instead of P4BROKERPORTNUM for the proxy's target port. I can do this, but first wanted to open an issue because I wasn't sure if it was the right thing to do given the check for a ServerType = p4proxy at line 1283 of mkdirs.sh. I'm also not sure if there would be impacts to other scripts or functionality if everything related to P4P_TARGET_PORT goes away although from a quick grep it looks like nothing uses it.

DevNotes:

Component:	setup

Type:	Bug