commits/11443

Change 11443

paul_allen (Paul Allen)
Paul Allen committed this change 10 years ago into //guest/perforce_software/p4jenkins/main/src/main
Request Review
Download .zip
Workaround for Jelly bug.

Perforce Credentials for Ticket value/path Jelly was not reporting the selected 'radioBlock'.
Add Job
1 edited 2 added 0 deleted
Tip: Use n and p to cycle through the changes.
mark_foundry (mark_foundry)
}
public boolean isTicketPathSet() {
- return "ticketPathSet".equals(value);
+ return getTicketValue() == null;
mark_foundry (on TicketModeImpl.java, line 56) commented 10 years ago

Should this be getTicketPath()?
Reply
paul_allen (Paul Allen)
}
public boolean isTicketPathSet() {
- return "ticketPathSet".equals(value);
+ return getTicketValue() == null;
Paul Allen (on TicketModeImpl.java, line 56) commented 10 years ago

I used the != and == conditions of getTicketValue to guarantee only one condition. If I had used getTicketPath there is a small chance they both could be true.
Reply
mark_foundry (mark_foundry)
}
public boolean isTicketPathSet() {
- return "ticketPathSet".equals(value);
+ return getTicketValue() == null;
mark_foundry (on TicketModeImpl.java, line 56) commented 10 years ago

Ah right. It looks just like a copy-n-paste error, which is why I queried it :)
Reply
paul_allen (Paul Allen)
}
public boolean isTicketPathSet() {
- return "ticketPathSet".equals(value);
+ return getTicketValue() == null;
Paul Allen (on TicketModeImpl.java, line 56) commented 10 years ago

Thanks for checking; it did make me double check. I have added some help bubbles too for tips on using p4 login -p -a.
Reply