Helix SwarmHelix Swarm
Loading...

mark_foundry

mark_foundry (mark_foundry)
  • 0
    Followers
  • 0
    Following
  • 1
    Projects
Full Name
mark_foundry
Email address
mark@thefoundry.co.uk
Followers
Projects
  • P4Jenkins
    • Member
  • Activity
  • Shelves
  • Settings
  • Notifications

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
10 years agomark_foundry updated files in review 11559 for perforce-software-sdp:main
Adding -S from=<adminuseremail> in all $MAIL commands.

Our setup is that ADMINEMAIL in mkdirs.sh is a "mailing list" (no unique user). Our emai...l provider bounces mails that go to a list, but don't get sent from a real user (presumably to avoid some cases of spam). It also bounces if the MAILFROM is set to the mailing list email address (as it's not a real user).

So we at least need a MAILFROM option.

Although this initializes to ADMINEMAIL too (so won't work out of the box for us), I wasn't sure what to call it in mkdirs.sh, but at least it's easy to grep for MAILFROM to change it. «
3 comments
10 years agomark_foundry requested review 11559 for perforce-software-sdp:main
Adding -S from=<adminuseremail> in all $MAIL commands.

Our setup is that ADMINEMAIL in mkdirs.sh is a "mailing list" (no unique user). Our emai...l provider bounces mails that go to a list, but don't get sent from a real user (presumably to avoid some cases of spam). It also bounces if the MAILFROM is set to the mailing list email address (as it's not a real user).

So we at least need a MAILFROM option.

Although this initializes to ADMINEMAIL too (so won't work out of the box for us), I wasn't sure what to call it in mkdirs.sh, but at least it's easy to grep for MAILFROM to change it. «
3 comments
10 years agomark_foundry commented on review 11455 for perforce-software-sdp:main

Happy to help make the SDP better! :)

2 comments
10 years agomark_foundry requested review 11455 for perforce-software-sdp:main
Fixing the location of the upgrade.log.
Previously, it would try to write to /upgrade.log, which requires root permissions. So changed to use $LOGS wh...ich is what backupfunctions.sh uses, and is defined in p4vars. I've only tested upgrade.sh, as I don't have a pre-2013.3 server. «
2 comments
10 years agomark_foundry commented on change 11443 (TicketModeImpl.java, line 56) for p4-jenkins:main

Ah right. It looks just like a copy-n-paste error, which is why I queried it :)

4 comments
10 years agomark_foundry commented on change 11443 (TicketModeImpl.java, line 56) for p4-jenkins:main

Should this be getTicketPath()?

4 comments
10 years agomark_foundry commented on job000119 for

I'd like that. We were trying a Perforce server with NFS mounts (backed by GPFS!) that suffered from terrible performance. (Support have the details).

...

I'd like that. We were trying a Perforce server with NFS mounts (backed by GPFS!) that suffered from terrible performance. (Support have the details).

But it didn't click that NFS was a bad thing for metadata until Robert Cowham pointed out a knowledge base article to me. As soon as we moved off of NFS mounts to DAS, all was fine.

It would be great to make that very clear at the beginning of the SDP, if this is being pushed as the recommended way to set up your P4 server.

 «
2 comments
10 years agomark_foundry requested review 11020 for perforce-software-sdp:main
Fixing typos in the README.md file.
I assume that the README.html is generated from the markdown file, so I've not fixed that file.
Add a comment
10 years agomark_foundry created job000119 for
Fixing a collection of typos I spotted in the documentation
2 comments
No shelved changes.

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default
Check all
I change the state of a review
I am the author, and
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed