commits/9829

Change 9829

jim_brower (jim_brower)
jim_brower committed this change 11 years ago into //guest/jim_brower/triggers under Review 9830
View Review
Download .zip
Added trigger to let you force any client options you want.
   Not exactly proud of the implementation, but it seems to work.
Add Job
1 edited 1 added 0 deleted
Tip: Use n and p to cycle through the changes.
jim_brower (jim_brower)
jim_brower (on ) commented 11 years ago

I know there will be issues with the command line arguments since I didn't use an awesome gem to do them. Putting an invalid argument will cause it to give an ugly error, and you could potentially put duplicate arguments where the last one would be the one that's used.
Reply
matt_attaway (Matt Attaway)
+#!/usr/bin/env ruby
+#
+# Triggers:
+# ForceRmdir form-in client "ForceRmdir.rb %formfile%"
Matt Attaway (on ForceClientOptions.rb, line 4) commented 11 years ago

Make sure to update your usage.
Reply
matt_attaway (Matt Attaway)
+
+form.each do |line|
+ if /^Client:.*p4sandbox-.*$/ =~ line
+ form.close
+ exit 0
Matt Attaway (on ForceClientOptions.rb, line 45) commented 11 years ago

You can pull out the close statement; exiting will handle that.
Reply
matt_attaway (Matt Attaway)
+ if /.*modtime/ =~ option
+ opts[4] = option
+ end
+ if /.*rmdir/ =~ option
+ opts[5] = option
Matt Attaway (on ForceClientOptions.rb, line 33) commented 11 years ago

Ifs are totally functional here, but a case statement is probably a bit more legible. They even accept reflexes in Ruby.
Reply
matt_attaway (Matt Attaway)
Matt Attaway (on ) commented 11 years ago

The approach you chose is solid. For the sake of robustness, let's add a requirement that a new option could be added and the script needs to leave that new option unchanged. Let's assume that the new option is not guaranteed to be at the end of the list of options.

This change should effectively make the script completely future proof.
Reply