// // P4NetworkOperation.m // Perforce // // Created by Adam Czubernat on 08/01/2014. // Copyright (c) 2014 Perforce Software, Inc. All rights reserved. // #import "P4NetworkOperation.h" @interface P4NetworkOperation () <NSURLConnectionDelegate> { // Internal state BOOL executing, finished; void (^receive)(P4NetworkOperation *operation); void (^completion)(P4NetworkOperation *operation); NSString *MIMEType; NSDictionary *HTTPHeaders; NSInteger HTTPStatus; } - (void)cancelOperation; - (void)completeOperation; @end @implementation P4NetworkOperation @synthesize success, error; #pragma mark - Overrides - (void)start { if ([self isCancelled]) { [self cancelOperation]; return; } [self willChangeValueForKey:@"isExecuting"]; executing = YES; [self didChangeValueForKey:@"isExecuting"]; // Create connection connection = [[NSURLConnection alloc] initWithRequest:request delegate:self startImmediately:NO]; data = [[NSMutableData alloc] init]; // Force runloop for events passing [connection scheduleInRunLoop:[NSRunLoop mainRunLoop] forMode:NSRunLoopCommonModes]; [connection start]; } - (void)cancel { [super cancel]; if (executing) [self cancelOperation]; } - (BOOL)isConcurrent { return YES; } - (BOOL)isExecuting { return executing; } - (BOOL)isFinished { return finished; } - (void)dealloc { PSLogm(@""); } #pragma mark - Public + (P4NetworkOperation *)operation { return [[P4NetworkOperation alloc] init]; } + (P4NetworkOperation *)operationWithRequest:(NSURLRequest *)urlRequest receive:(P4NetworkBlock_t)receive completion:(P4NetworkBlock_t)completion { P4NetworkOperation *operation = [[P4NetworkOperation alloc] init]; [operation setRequest:urlRequest receive:receive completion:completion]; return operation; } + (P4NetworkOperation *)operationWithUrl:(NSString *)url HTTPMethod:(NSString *)method HTTPHeaders:(NSDictionary *)headers HTTPBody:(NSData *)body receive:(P4NetworkBlock_t)receive completion:(P4NetworkBlock_t)completion { NSMutableURLRequest *request; request = [NSMutableURLRequest requestWithURL:[NSURL URLWithString:url] cachePolicy:NSURLRequestReloadIgnoringCacheData timeoutInterval:60.0f]; [request setHTTPShouldHandleCookies:YES]; [request setHTTPMethod:method ?: @"GET"]; [request setHTTPBody:body]; // Add headers to request for (NSString *field in headers) [request setValue:[headers objectForKey:field] forHTTPHeaderField:field]; // Add length header [request setValue:[NSString stringWithFormat:@"%ld", [body length]] forHTTPHeaderField:@"Content-Length"]; P4NetworkOperation *operation = [[P4NetworkOperation alloc] init]; [operation setRequest:request receive:receive completion:completion]; return operation; } - (NSData *)data { return data; } - (NSString *)MIMEType { return MIMEType; } - (NSDictionary *)HTTPHeaders { return HTTPHeaders; } - (NSInteger)HTTPStatus { return HTTPStatus; } - (NSDate *)HTTPDate { static NSDateFormatter *formatter; if (!formatter) { formatter = [[NSDateFormatter alloc] init]; NSLocale *locale = [[NSLocale alloc] initWithLocaleIdentifier:@"en_US"]; [formatter setLocale:locale]; [formatter setDateFormat:@"EEE, d MMM y HH:mm:ss ZZZ"]; } NSString *stringDate = [HTTPHeaders objectForKey:@"Date"]; if (!stringDate) return nil; return [formatter dateFromString:stringDate]; } - (NSURLResponse *)HTTPResponse { return HTTPResponse; } - (CGFloat)progress { return progress; } - (long)completed { return completed; } - (long)length { return length; } - (NSURLRequest *)request { return request; } - (void)setRequest:(NSURLRequest *)urlRequest receive:(P4NetworkBlock_t)onReceive completion:(P4NetworkBlock_t)onCompletion { // Don't create new request if connection is already running if (executing) return; // Copy passed request request = [urlRequest copy]; // Copy passed blocks receive = [onReceive copy]; // Copy blocks from stack to heap, stack completion = [onCompletion copy]; // otherwise would be drained when calling // function returns. // Clear variables connection = nil; success = NO; error = nil; data = nil; MIMEType = nil; HTTPHeaders = nil; HTTPResponse = nil; HTTPStatus = 0; progress = 0.0f; completed = 0; length = 0; } #pragma mark - Private - (void)cancelOperation { [connection cancel]; success = NO; error = [NSError errorWithDomain:NSCocoaErrorDomain code:NSUserCancelledError userInfo:nil]; [self completeOperation]; } - (void)completeOperation { if (finished) return; [self willChangeValueForKey:@"isFinished"]; [self willChangeValueForKey:@"isExecuting"]; executing = NO; finished = YES; [self didChangeValueForKey:@"isExecuting"]; [self didChangeValueForKey:@"isFinished"]; if (completion) completion(self); connection = nil; completion = nil; receive = nil; } #pragma mark - NSURLConnection delegate - (void)connection:(NSURLConnection *)connection didReceiveResponse:(NSURLResponse *)response { length = [response expectedContentLength]; completed = 0; progress = 0.0f; HTTPResponse = (NSHTTPURLResponse *)response; MIMEType = [HTTPResponse MIMEType]; HTTPHeaders = [HTTPResponse allHeaderFields]; HTTPStatus = [HTTPResponse statusCode]; if (receive) receive(self); } - (void)connection:(NSURLConnection *)connection didReceiveData:(NSData *)receivedData { // if (outputFile) // data = receivedData; // Store new chunk of data // else [(NSMutableData *)data appendData:receivedData]; // Append new data // Add received bytecount into completedLength completed += receivedData.length; // Compute progress if (length == NSURLResponseUnknownLength) progress = 0.0; else progress = completed / (CGFloat) length; if (receive) receive(self); } - (void)connection:(NSURLConnection *)failedConnection didFailWithError:(NSError *)connectionError { success = NO; error = connectionError; [self completeOperation]; } - (void)connectionDidFinishLoading:(NSURLConnection *)finishedConnection { success = YES; // Check http errors if ((HTTPStatus >= 400 && HTTPStatus < 500) || // Client error (HTTPStatus >= 500 && HTTPStatus < 600)) { // Server error if (!error) error = [NSError errorWithDomain:NSCocoaErrorDomain code:HTTPStatus userInfo:@{ NSLocalizedDescriptionKey : [NSHTTPURLResponse localizedStringForStatusCode:HTTPStatus] }]; success = NO; } [self completeOperation]; } @end
# | Change | User | Description | Committed | |
---|---|---|---|---|---|
#1 | 15071 | alan_petersen |
Populate -o //guest/perforce_software/piper/... //guest/alan_petersen/piper/.... |
||
//guest/perforce_software/piper/mac/R2.0/Perforce/Classes/Client/P4NetworkOperation.m | |||||
#1 | 12962 | alan_petersen |
Populate -o //guest/perforce_software/piper/mac/main/... //guest/perforce_software/piper/mac/R2.0/.... |
||
//guest/perforce_software/piper/mac/main/Perforce/Classes/Client/P4NetworkOperation.m | |||||
#2 | 12961 | alan_petersen |
Piper 2.0 Mega Update New Features/Functionality - Added help menu redirecting to URL. - Added readonly property for creating new workspaces. - Added html hyperlinks for Copy link functionality. - Added functionality for managing Finder Favorite items in sidebar. - Redesigned the way mapping is stored in Piper. - First version of syncing finder sidebar items with workspace mapping. - Small sorting improvements. - Creating Projects directory inside users home folder. - Adding Projects folder to finder sidebar item. - Creating and removing symbolic links accordingly to mapped folders. - Preventing duplicate names in symbolic links. - Refreshing symbolic links on mapping change inside application. - Storing workspace and server details in p4 configuration for other applications to use. - Added contextual menu items for Finder integration. - Added services menu for Adobe Illustrator integration. - Keyboard shortcuts for Illustrator integration. - Code refactoring and fixes for mapping issues. - Added Finder functionality to edit all files in folder. - Added user friendly message when editing a file using Finder outside the workspace. - Implemented hidden automatic login when opening application using Finder integration. - Logging to file in ~/Library/Logs - Unified workspace and all files views to show both local and depot files and folders. - Removed my workspace view references and logic. - Editing unmapped files on server. - First version of adding file to unmapped folders. - Showing opened by and edit actions in column details for all depot files. - Improved mappings functionality. - Enabled same feature options for mapped and unmapped folders and files. - Redesigned from scratch mapping and unmapping procedures for adding and removing files. - Implemented cleaning workspace using new mapping functionality. Removed debug overlay coloring. - Automated workspace creation - Improvements in editing files already mapped to workspace. - Implemented deleting remote files. - Implemented first version of move operation for remote files. - Removing last workspace information when disconnecting from workspace using app menu. - Implemented editing and submitting using symbolic links in project folder. New finder menu service for symbolic links Show in Piper which acts like share link functionality. - New icons for files and folders not tracked in the filesystem. - Improvements in showing file using share link. - Switched to new way of retrieving files in order to show user changes. - Redesigned and implemented new functionality for chaining operations with mapping. - Improvements and redesign of Edit/add actions to use new chaining logic . Fixed issue with file edit. - Improvements in window showing when using services. - Simplified file loading so the local files appears only when remote are also loaded. - Improved deleting of untracked files to avoid mapping and marking for delete. - Enabling simple copy paste and moving of remote and local files. - Added abort for exception handling in order to force crashing application on critical failures - Added custom exception handling for catching runtime errors to log and crash instead of continuing in unstable state. - Changed file copying to use mark for add . - Simplified and fixed responding file representations to mapping changes. Bug Fixes - Fixed crash when synchronizing. - Fixed sync issue when downloading directory without file size information. - Fixed issue with unread list crashing when file is not existing on disk. - Fixed incorrect sync progress calculation. - Removed relative path issues. - Fixed many of case-sensitivity problems. - Fixed deprecated methods and related issues in OS X 10.10. - Fixed folder rename not updating in column view. Revised and fixed many potential problems from implicit casting. - Fixed missing sync button on fast sync completion. - Refreshing mapping on synchronization. Fixed symbolic links not appearing until app is restarted. - Fixed latest crashing of autosync. - Fixed loading indicator issues. - Fixed and redesigned submit dialog to work correctly with Submit All Files option in Finder. - Fixed multiple error messages on network outage. Redesigned showing errors in main window. - Fixed opening random locations when using Finder integration. - Fixed issue when panel was detached from parent window. - Fixed bug when creating new workspace wouldn't store default settings. - Fixed memory issues with network operations. - Fixes in relogging mappings and file listing. - Improvements in editing unmapped files. - Fixed crash when adding file outside workspace. - Fixed breadcrumbs control issue. - Fixed issue with double parent folders when opening unmapped files. - Fixed crashes on sync after mapping new files. - Fixed issue with editing file using Finder -- Merging code and additional fixes in add button functionality. - Fixed unsync not working - Fixed submit panel issue not selecting files with different name case. - Fixed missing revert and sync to workspace actions in some cases. - Fixed issue with Submit and Edit finder actions. Improvements in stability of finder integration. - Fixed issue with unsubmitted folders breaking status of files inside. - Fixed issue with added files not showing correct icon and status. - Fixed bug with file edit resulting in a new directory named exactly like a file. - Fixed issue with reloading of subpath resulting in untracked folders. - Fixed mapping issue when result was always view mapping not relative. - Fixed submit panel showing more than once. - Fixed illustrator services not working. - Fixed userdefaults preferences problem with workspace name being null. - Fixed userdefaults keypath problem of dot-containing workspace names. - Forcing recreating of browser to possibly prevent pre-10.10 errors with automatic workspace selection. - Fixed adding file to depot not presenting correct icon. - Fixed issues with reverting a file that was marked for add. - Presenting error when trying to submit untracked files. - Fixed issue when submit files service crashed when using unmapped files. - Fixed file representation disappearing when removing file. - Fixed issue with symlinks resolving working on 10.10 only. Issue related to workspace selection not showing. - Fixed error panel method calls unavailable in Mac OS versions before 10.10. Issue related to hanging error panels. - Fixed removing a local file resulting in action progress freezing. - Fixed open file not working after edit. - Fixing crash when mapping changed. Issue related to moving local file to unmapped folder and other similar cases. |
||
#1 | 11252 | alan_petersen | Rename/move file(s) | ||
//guest/perforce_software/piper/mac/Perforce/Classes/Client/P4NetworkOperation.m | |||||
#1 | 10744 | alan_petersen | Rename/move file(s) | ||
//guest/perforce_software/piper/Perforce/Classes/Client/P4NetworkOperation.m | |||||
#1 | 8919 | Matt Attaway | Initial add of Piper, a lightweight Perforce client for artists and designers. |