diff -rupN module.orig/Projects/view/projects/index/edit.phtml module/Projects/view/projects/index/edit.phtml --- module.orig/Projects/view/projects/index/edit.phtml 2015-01-19 20:55:17.000000000 +0000 +++ module/Projects/view/projects/index/edit.phtml 2015-08-21 12:57:18.000000000 +0000 @@ -180,6 +180,13 @@ $baseUrl = $this->escapeFullUrl($this- <?php echo ($emailMembers || $emailMembers === null) ? 'checked' : '' ?>> Email project members when a new review is requested </label> + <label class="checkbox" for="moderatorEmails"> + <?php $emailModerators = $project->getEmailFlag('review_email_branch_moderators') ?> + <input type="hidden" name="emailFlags[review_email_branch_moderators]" value="0" /> + <input type="checkbox" name="emailFlags[review_email_branch_moderators]" id="moderatorsEmails" value="1" + <?php echo ($emailModerators) ? 'checked' : '' ?>> + <?php echo $this->te('Email branch moderators when a review is changed')?> + </label> <label class="checkbox" for="changeEmails"> <?php $emailUsers = $project->getEmailFlag('change_email_project_users') ?> <input type="hidden" name="emailFlags[change_email_project_users]" value="0" /> diff -rupN module.orig/Reviews/src/Reviews/Listener/Review.php module/Reviews/src/Reviews/Listener/Review.php --- module.orig/Reviews/src/Reviews/Listener/Review.php 2015-01-19 20:55:16.000000000 +0000 +++ module/Reviews/src/Reviews/Listener/Review.php 2015-08-21 20:17:08.000000000 +0000 @@ -533,6 +533,18 @@ class Review extends AbstractListenerAgg } } } + + // Notify moderators of affected branches if the notify moderators project email flag is set. + $reviewProjects = $review->getProjects(); + foreach ($projects as $project) { + $emailModerators = $project->getEmailFlag('review_email_branch_moderators'); + if ($emailModerators) { + $branches = $reviewProjects[$project->getId()]; + if ($branches) { + $to = array_merge($to, $project->getModerators($branches)); + } + } + } // include any removed reviewers this one last time so they know it happened $to = array_merge($to, $removedReviewers);
# | Change | User | Description | Committed | |
---|---|---|---|---|---|
#1 | 15882 | jason_leonard |
Moderators Email patch by Jason Leonard (jason.leonard@citrix.com) This patch adds a new checkbox to the project to allow moderators to get all emails about changes to a review. This is equivilent (only for notification purposes) to automatically adding them as reviewers to a review. |