| # | Change | User | Description | Committed | |
|---|---|---|---|---|---|
| #2 | 27934 | Lester Cheung |
Fixed a few issues reported from github - updated script for PY3 (tested with v3.9.6 on Fedora 34) - whinge if config does not exist. Fixes GH issue#3 - re-formatted script with black - added option to control debug level - fixes GH issue#4 |
||
| #1 | 20563 | Lester Cheung | Branch to make line wrapping better. | ||
| //guest/lester_cheung/p4review/p4review2.py | |||||
| #39 | 20562 | Lester Cheung | Removed support email from help | ||
| #38 | 15011 | Lester Cheung | Import fixes for Python3. | ||
| #37 | 12323 | Lester Cheung | Warn, instead of failing hard when storing password in configuration files. | ||
| #36 | 12322 | Lester Cheung | Stop the script from failing when the -c option is not used. | ||
| #35 | 12073 | Lester Cheung | Plugged a bug in P4CLI - checks the returned value of re.match() and not run groups() on it if it's None. | ||
| #34 | 11983 | Lester Cheung |
Allow empty settings in the config file again. Also fixed a bug when html templates is explicitly disabled. |
||
| #33 | 11791 | Lester Cheung |
Updated comments - mainly to test Git Fusion over HTTPS! Imported from Git Author: Lester Cheung <lcheung@perforce.com> 1424399977 +1100 Committer: Lester Cheung <lcheung@perforce.com> 1424399977 +1100 sha1: 6fce71165229da5ea62a1fb7e14b915867544d6b push-state: complete parent-changes: 4608b155b4d9d7ffb701b257cb9cdc1b0e911740=[11693] |
||
| #32 | 11693 | Lester Cheung |
* [feature] added option -i to ignore users with a regex pattern * [fix] exception syntax. * [update] pulled new P4CLI from p4util |
||
| #31 | 10732 | Lester Cheung | Removed trailing whitespaces in the file - thanks emacs! | ||
| #30 | 10727 | Lester Cheung |
Making the following configurables an integer so we can use it in list-slicing notations: max_length max_emails max_email_size poll_interval When a float is used in the slicing notation you would see errors similar to: >>> 'abc'[1.1:] Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: slice indices must be integers or None or have an __index__ method Thanks Alan for the bug report! |
||
| #29 | 8471 | Lester Cheung | Using P4Review.unicode() instead of calling unicode() directly. | ||
| #28 | 8464 | Lester Cheung | I should learn how to type... | ||
| #27 | 8458 | Lester Cheung | Not notifying change submitter means we might have return without sending email. | ||
| #26 | 8457 | Lester Cheung |
Corrected a syntax error in line 985. :( |
||
| #25 | 8456 | Lester Cheung |
Fixing command-line argument parsing... :-/ |
||
| #24 | 8455 | Lester Cheung |
(Default) option to skip notification to change owners. Shows default_name in change notifications instead of author names. |
||
| #23 | 8449 | Lester Cheung |
Forgot to turn off debug. :( |
||
| #22 | 8448 | Lester Cheung |
Fixed the "to addr" argument of calls to P4Review.sendmail() and turned all print statements to function calls. |
||
| #21 | 8445 | Lester Cheung | Logging job & review counters | ||
| #20 | 8443 | Lester Cheung | Removing "//depot/jobs" as argument to "p4 reviews", fixing job000032. | ||
| #19 | 8442 | Lester Cheung | Now works with depot paths with unicode characters! | ||
| #18 | 8439 | Lester Cheung |
Fixed error message. Now printing the name of the review counter correctly instead of the job counter. Thanks Peter! |
||
| #17 | 8347 | Lester Cheung |
Sane default for the daemon option, logs daemon start/stop/restart and be lazy when running in opt-in-mode. |
||
| #16 | 8346 | Lester Cheung | [review-8338] Daemonizing p4review2.py | ||
| #15 | 8336 | Lester Cheung | SSL support for SMTP (in addition to TLS). | ||
| #14 | 8335 | Lester Cheung | Backout change 8334 to remove work in progress. | ||
| #13 | 8334 | Lester Cheung | SSL SMTP support (in addition to TLS). | ||
| #12 | 8285 | Lester Cheung |
Bug fix with config parsing and enhancement: * Null strings in job_counter and review_counter were parsed wronly and always return a string (thus will always run) - you can now disable change/job reviews by sending the config to one of ('FALSE', '0', 'NONE', 'DISABLED', 'DISABLE', 'OFF') * Removed debug outputs. * Pickling server specs via a sqlite converter. |
||
| #11 | 8244 | Lester Cheung | Minor tweaks in the docstring... | ||
| #10 | 8243 | Lester Cheung |
Fixed typo. :-/ |
||
| #9 | 8242 | Lester Cheung | Better description in docstring. | ||
| #8 | 8241 | Lester Cheung |
Dummy pull form //public/perforce/utils/reviewd/p4review.py so that this gets showed up in: http://public.perforce.com/wiki/P4Review |
||
| #7 | 8229 | Lester Cheung | Fixed "login -s" in P4CLI... | ||
| #6 | 8228 | Lester Cheung | Fixed scoping problem in pull_data_from_p4()... | ||
| #5 | 8227 | Lester Cheung | Fixed P4CLI so that it's actually working ;-) | ||
| #4 | 8225 | Lester Cheung | TLS (not SSL) and SMTP auth support. | ||
| #3 | 8224 | Lester Cheung |
Now uses P4 CLI when P4Python is not available! Also fixed a problem with default sender address. |
||
| #2 | 8223 | Lester Cheung | Removed extra outputs in job summaries | ||
| #1 | 8222 | Lester Cheung |
p4review2.py, a rewrite of p4review.py. Requires python2.7 and P4Python. |
||