| Name | Modified | Size |
|---|---|---|
| .. | ||
| Pulse | ||
| Pulse.xcodeproj | ||
| PulseTests | ||
| perforce.png | 11 years ago | 4 KB |
| perforce_angry.png | 11 years ago | 4 KB |
| perforce_sad.png | 11 years ago | 4 KB |
| Change | User | Description | Committed |
|---|---|---|---|
| 8777 | Matt Attaway | Try to figure out weird command hang in Pulse. For the time being we just kill the conn...ection if NSTask hangs. I just wish I knew why it was hanging. « |
11 years ago |
| 8760 | Matt Attaway | Remove sound when sync is complete I left it for now for the initial sync and login not...ifications, but it is annoying for normal syncs. User visible change « |
11 years ago |
| 8759 | Matt Attaway | Move off of waitUntilExit when polling for changes One of the great moments in coding w...here I don’t entirely understand why this fixes things, but so far it appears using isRunning checks prevents the stalled processes I was seeing with waitUntilExit User visible bug fix « |
11 years ago |
| 8723 | Matt Attaway | Continuously update state on opened files Automatically checking out files is all well... and good, but there’s a problem; frequently in the course of working on files, before you commit, files will go through a number of different states. You may edit a file, then delete it, and then re-add it unchanged all before trying to commit. At the end of the process in the case above nothing should happen, but if you edit a file and never revisit it you are stuck with that initial edit. Pulse now runs a non-destructive revert on files when it receives an event notification. This resets the working state so that if there is a major change (from edit -> delete) we can properly catch it and tell the system. It also is handy for dealing with added files that you then delete. There are edge cases with this code that I’m confident are not handled correctly. The good news is nothing should be destructive; the worse that happens is you revert -k everything and re-run reconcile. User visible change « |
11 years ago |
| 8722 | Matt Attaway | Optimize reconcile calls to minimize file scans The FSEvents API gives wonderfully deta...iled information which allows us to be a bit more precise in how we run reconcile. Now we only look for edited files if one of the files was flagged as modified. No user visible change (fairly subtle optimization) « |
11 years ago |
| 8721 | Matt Attaway | Move to using the file list provided by the file watcher for reconcile Instead of looki...ng at the world all the time Pulse now selectively only reconciles the files that were changed. Prior users will note files don’t get accidentally swept up anytime some other file changes. User visible change « |
11 years ago |
| 8720 | Matt Attaway | Rework reconcile methods to handle file arguments Previously the only option was to bli...ndly reconcile the world. Now reconciles can be more targeted, although there’s no code to actually do a targeted reconcile yet in the Overseer. Infrastructure only change « |
11 years ago |
| 8706 | Matt Attaway | Infrastructure work to more intelligently handle FSEvents Prior to this change all file... system events were equal; chown-ing a file was considered the same as changing the content. With this change we: 1) bundle all of the file events into one operation instead or doing it one file at a time 2) ignore any file events that are not create/delete/modify/rename The interfaces are all in place, but the Overseers are still not taking advantage of this information, so there’s no user visible change at this time. (hopefully) Infrastructure only change « |
11 years ago |
| 8703 | Matt Attaway | Connect checkbox for auto sync to the correct action Checking the auto-sync stopped wor...king after I pulled the test out of the window close event. This change fixes it all. User visible bug fix « |
11 years ago |
| 8702 | Matt Attaway | Add the ability to pause updates on a connection After some fun today where I added a g...azillion files while running automated tests I realized there is is much to be said for being able to pause your automated friend. This change adds the ability to pause updates on a connection. Syncs and file events are not tracked while updates are paused. Paused connections are also not used when figuring out what the state icon should be. Also fix a bug related to all of this where a server coming online while in the connection dialog would not cause the icon to update. We now do an icon state check after coming out of the connection dialog. In addition, we use the proper timer when coming out of the connection dialog, not always the sync timer. User visible change « |
11 years ago |
| 8698 | Matt Attaway |
Add a method to run revert -k. Will hook up later into the reconcile code |
11 years ago |
| 8692 | Matt Attaway | Add auto-submit capability to Pulse If you so choose you may now configure Pulse to aut...omatically submit files as soon as they are changed. This is done as part of the file event watcher; files are opened with reconcile and if configured to do so immediately submitted with a boilerplate commit message. For obvious reasons auto-commit is off by default. User visible change « |
11 years ago |
| 8691 | Matt Attaway | Fix sundry connection dialog bugs * Table text is now updated when the port changes *... Path is properly set when set using the browse button * On close we set all of the values for the selected connection on the off chance our text field event didn’t fire User visible bug fixes « |
11 years ago |
| 8690 | Matt Attaway | Automatically append ":1666" to the end of a server if the user forgets User visible ch...ange « |
11 years ago |
| 8689 | Matt Attaway | Fix bug where observers were repeatedly added, causing FSEvent watcher errors Bug fix w...ith no user visible change « |
11 years ago |
| 8686 | Matt Attaway | Swap in new connection dialog There’s still a fair amount of polish to do, but it’s good... enough to replace the old connection dialog. User visible change « |
11 years ago |
| 8685 | Matt Attaway | Update connections with value from text fields in new dialog This still feels like it n...eeds some testing, but values entered into the text boxes are actually used but the connections now after closing the dialog. User visible change « |
11 years ago |
| 8684 | Matt Attaway | First steps on the new connection dialog At this point it’s effectively a read only dia...log. Changes made in the text fields are currently ignored. It does look much nicer though. To view it use the appropriately named ‘??????’ menu entry. User visible change « |
11 years ago |
| 8657 | Matt Attaway | Tidy up constructors and whitespace a bit Finally figured out the proper way to have a... designated contructor in Obj-C. Hooray for progress. No user visible change. « |
11 years ago |
| 8656 | Matt Attaway | Move login check out to a thread too At this point the only Perforce command that is ru...nning in the main thread is login from the login dialog itself. This should help keep Pulse peppy. User visible change (less lag) « |
11 years ago |
| 8655 | Matt Attaway | Pull logging out of the message parsing helpers The logging was previously helpful, but... now that I'm using those methods heavily it's just noise. No user visible change. « |
11 years ago |
| 8654 | Matt Attaway | Move connections checks into threads Getting everything slow off of the main thread. Th...at means you connection checks. User visible change (in so much as it’s less laggy now) « |
11 years ago |
| 8653 | Matt Attaway | Disable/enable the login menu when appropriate It’s pretty daft to have the login menu... always active. --daftness User visible change « |
11 years ago |
| 8652 | Matt Attaway | Rework login to take advantage of other clients logging in Previously the Overseer enti...rely shut down operations when it noticed that the user needed to login. This is all well and good if you only use Pulse, but less helpful if use other clients too. This change introduces a new timer that attempts ‘p4 login -s’ every few seconds to see if there is a valid ticket. This is not unlike the timer that gets enabled when a connection is lost. This change also includes some WIP on submit support that I was too lazy to pull out. User visible changelist « |
11 years ago |
| 8635 | Matt Attaway | Move reconcile and sync calls off into threads to improve UI performance Not shockingly..., running a giant p4 sync in the main thread is a bad idea. With this change I put on my grown up pants and move all of the potentially long running commands into their own threads. User visible change « |
11 years ago |
| 8597 | Matt Attaway | Handle disconnected servers automatically If Pulse loses its connection with the Perfor...ce server it now reports that the connection is down and starts a new timer to look for a live connection. The Overseer handles all of this on its own; unlike login there’s really nothing for the user to do. This change also fixes a bug where the login dialog was not being properly regenerated for connections after the first. User visible change « |
11 years ago |
| 8595 | Matt Attaway | WIP on handling connection errors With this change we report the errors to our delegate..., but we don’t attempt to recover. That will come with the next checkin. This change does add in the protocol for handling these errors. User visible change « |
11 years ago |
| 8594 | Matt Attaway | Custom message for completed sync after initial sync | 11 years ago |
| 8592 | Matt Attaway | Add less aggressive notification when background processes detect need to login Instead... of popping a dialog up right in your face we use a standard notification and change the status icon to indicate Pulse is unhappy. Using the login menu item will log the user is and restart the background processes. User visible change. « |
11 years ago |
| 8591 | Matt Attaway | Make the notification text for a single change more useful. Pulse now gives the change... number, author, and some of the change description when syncing a single file. I think I might swap out the change number with the number of files changed, but that’s for later. User visible change. « |
11 years ago |
| 8590 | Matt Attaway | Add crude login capabilities This is the first step toward getting the login behavior I... want. Right now anytime a Peforce command gets a login error the Overseer ion charge notifies its delegate, which is currently the AppDelegate. The AppDelegate then kicks off the requisite login dialog which gets the password and does the login. There’s no error handling or feedback and the dialog pops up even when it is a background process that hit the error. The next step is to implement the Login menu item and the ‘need login’ tool tip and status icon. User visible (and possibly user annoying) change « |
11 years ago |
| 8575 | Matt Attaway | Automatically handle Unicode servers; stub out login handling There's a lot going on in... this change: * Fixed a bug where charset was always set to none * Added protocol on PLSOverseer so that something can properly handle login errors * PLSAppDelegate implements stubs for the PLSOverseer protocol * PLSOverseers automatically configure themselves for Unicode servers now * Ripped out handleCommonErrors: because it turns out I want to handle the same error in multiple ways. Next step is to properly handle 'p4 login' and request a password. User visible changes. « |
11 years ago |
| 8574 | Matt Attaway | Move message parsing smarts into P4Message. This minimizes how much PLSOverseer knows a...bout Perforce which seems like a good thing from an architecture point of view and makes the P4 group more reusable. No functional change. « |
11 years ago |
| 8571 | Matt Attaway | Expand connection properties for charset; add method to crudely handle common errors Th...is is the next step towards handling login and unicode errors. The interfaces have been widened to track the charset. I’m using a string at this point so that I can just pass in the character set without having to test it; ‘none’ works with non-Unicode servers. The handler just logs what it would do so that I can test the behavior. Next step is to actually ask the user for their password and run login. Still no real functional change. « |
11 years ago |
| 8570 | Matt Attaway | Start capturing and returning stderr as well as stdout In preparation for handlilng log...gin in, start capturing and passing stderr to the calling method in the error portion of the P4Message. « |
11 years ago |
| 8569 | Matt Attaway | Rejigger P4Connection to use a standard return type The previous mechanism made it hard... to return anything but error messages. With the P4Message object we can return dictionaries, lists, and messages with a single object. I can use the new object more intelligently, but that’s for another change. I also reorganized the code to separate the ‘p4’ layer off into its own potentially reusable bucket. No functional change. « |
11 years ago |
| 8555 | Matt Attaway | Replace hardcoded defaultsfor new connections with user specific values. | 11 years ago |
| 8553 | Matt Attaway | Add a bit of extra logging while I work out this occasional hang | 11 years ago |
| 8552 | Matt Attaway | Properly pluralize when handling just one changelist. I probably need to rethink the no...tification titles; changelist counts are less useful when most syncs are just one changelist. « |
11 years ago |
| 8544 | Matt Attaway | Hardcode P4IGNORE for now to properly ignore files taht should be ignored | 11 years ago |
| 8537 | Matt Attaway | Rework Pulse startup to (sorta) support real users Instead of repopulating the system w...ith my test data it now pops up the connection dialog if there are no existing connections. This change also fixes a bug where the PLSConnection object wasn’t being refreshed when settings were changed on an Overseer. « |
11 years ago |
| 8536 | Matt Attaway | Save out connections when closing the dialog | 11 years ago |
| 8527 | Matt Attaway | Improve query efficiency and improve feedback to user This change adds a check for the... highest synced changed. Instead of blindly running sync over and over Pulse now runs ‘p4 changes -m 1 //<client>/...' and if the number is higher than the stored value it runs sync and then stores the new highest change. Highest change numbers are written to the preferences to further reduce needless queries. With this change we also fetch the list of changes between the previous high change and the new one so that we can report the number of changes synced. « |
11 years ago |
| 8526 | Matt Attaway | Force connection dialog to the front | 11 years ago |
| 8525 | Matt Attaway | Refactor the Perforce interaction out of the Overseer into a separate class No function...al change, hopefully. This should just simplify the Overseer code and set me up to have a proper place to run Perforce commands. « |
11 years ago |
| 8524 | Matt Attaway | Stop trying to add files that are hidden (start with ‘.’) It just ends in tears and revert... -k’s. « | 11 years ago |
| 8523 | Matt Attaway | Prevent double start call to FSEvents This was a bit of shuffling, but the behavior is... much tidier now. Overseers do not start overseeing until they are explicitly told to do so. This makes their behavior much more predictable. « |
11 years ago |
| 8522 | Matt Attaway | Clean up the behavior of the connections dialog All of the Overseers are now paused whi...le the connection dialog is up so that the user can fiddle with their settings in peace. « |
11 years ago |
| 8521 | Matt Attaway | Set a more sane initial position for the connection dialog | 11 years ago |
| 8520 | Matt Attaway | Make the Connections dialog remember its position and size | 11 years ago |
