| Change | User | Description | Committed |
|---|---|---|---|
| 14024 | riesman | Problem: the email_summary was stuck at false, even if set to true in the config file beca...use the arg parser defaulted it to false, and command line args override the config file. Solution: remove default value Problem: opening the log file in binary mode "ab" caused errors in Python 3. Solution: open it in text mode "a". Problem: same changes getting parsed again and again. Solution: update review counter to last change examined. « |
10 years ago |
| 14001 | riesman | p4review2 - Add config file parameters: debug_level, p4tickets, and p4bin. Print message... and exit if the config file is unreadable. Fix orphaned pid file bug in cleanup. Include full stack trace when logging exceptions. Test on both python 2.7 and 3.3 in Windows and fix errors. Move imports to top of file where possible. « |
10 years ago |
| 14000 | riesman |
Installed p4review2 at work. It rocks. |
10 years ago |