---
# Optional dummy network interface used for multi-homed Perforce licensing.
# Controlled by the dummy_interface variable.
- name: "Set up the dummy interface"
when: dummy_interface
block:
- name: "Add the dummy module file for reboots"
ansible.builtin.copy:
content: "dummy"
dest: "/etc/modules-load.d/dummy.conf"
owner: "root"
group: "root"
mode: '0644'
when: ansible_facts["os_family"] == "RedHat"
- name: "Add the dummy module"
community.general.modprobe:
name: "dummy"
state: "present"
when: ansible_facts["os_family"] == "RedHat"
- name: "Set up dummy interface for perforce license (RedHat)"
ansible.builtin.copy:
src: "./ifcfg-dummy0"
dest: "/etc/sysconfig/network-scripts/ifcfg-dummy0"
owner: "root"
group: "root"
mode: '0644'
when: ansible_facts["os_family"] == "RedHat"
- name: "Check the dummy interface admin state (RedHat)"
ansible.builtin.command: "ip link show dummy0"
register: dummy0_link
changed_when: false
failed_when: false
when: ansible_facts["os_family"] == "RedHat"
- name: "Start the dummy interface (RedHat)"
ansible.builtin.command: "ifup dummy0"
# 'UP' appears in the interface flags (<...,UP,LOWER_UP>) only when it is
# already administratively up, so only bring it up when it is not.
when:
- ansible_facts["os_family"] == "RedHat"
- "'UP' not in (dummy0_link.stdout | default(''))"
changed_when: true
- name: "Set up dummy netdev for perforce license (Debian)"
ansible.builtin.copy:
src: "./10-dummy0.netdev"
dest: "/etc/systemd/network/10-dummy0.netdev"
owner: "root"
group: "root"
mode: '0644'
when: ansible_facts["os_family"] == "Debian"
- name: "Set up dummy network for perforce license (Debian)"
ansible.builtin.copy:
src: "./20-dummy0.network"
dest: "/etc/systemd/network/20-dummy0.network"
owner: "root"
group: "root"
mode: '0644'
when: ansible_facts["os_family"] == "Debian"
- name: "Restart systemd-networkd"
ansible.builtin.systemd:
name: "{{ item }}"
state: restarted
loop:
- systemd-networkd
- systemd-resolved
when: ansible_facts["os_family"] == "Debian"
- name: "Pause to give DNS a chance to recover"
ansible.builtin.pause:
seconds: 15
| # | Change | User | Description | Committed | |
|---|---|---|---|---|---|
| #2 | 32876 | Russell C. Jackson (Rusty) |
Make both ansible roles idempotent (full converge re-runs cleanly) Existence gate: - main.yml: stat /p4/common/bin/p4_vars -> sdp_installed fact; gate the destructive cleanup (wipe sdp folder + crontab) on 'not sdp_installed' so a re-converge skips wipe/reinstall and only reconciles idempotent config. Run-once installers gated with creates/checks: - run_mkdirs.sh: creates /p4/common/bin/p4_vars (drop changed_when:true). - pyenv: drop changed_when on the creates-guarded bootstrap; add creates for the Python build; gate p4python install on 'pip3 show p4python'. - monitoring prometheus.yml: gate the p4prometheus install script on creates /usr/local/bin/p4prometheus. changed_when:true lies fixed: - login.yml: gate admin/service logins on 'p4 login -s' (only log in when no valid ticket); use command for the no-shell status check. - network_interface.yml: ifup gated on the interface not already being UP. touch/cron idempotence: - authorized_keys touch: modification_time/access_time preserve. - cron/common.yml: remove 'crontab -r' (cron/cronvar modules manage entries idempotently by name; cron.yml is now the authoritative crontab manager). - install/crontab.yml removed + its include dropped: the SDP-generated p4.crontab load was redundant (cron.yml's reset discarded it every run). - packages.yml: apt update_cache cache_valid_time=3600. Molecule: configure_new_server gated behind a marker in the install converge and monitoring prepare; re-added the 'idempotence' step to both scenarios' test_sequence. ansible-lint production-clean; all playbooks syntax-check. |
||
| #1 | 32842 | Russell C. Jackson (Rusty) |
Reorganize ansible-sdp into per-concern task files; ansible-lint production-clean - Split install.yml/cron.yml/dependencies.yml and the monitoring role into thin orchestrators plus single-purpose phase files; extract shared steps into tasks/common/ (fetch_sdp, fetch_binaries, run_mkdirs, copy_ssl, configure_broker, sudoers). - Full best-practices pass: FQCN, true/false, quoted modes, changed_when, loops, document-start markers; fill both roles' meta; add .ansible-lint. - RedHat parity: parameterized EPEL enable, dnf, full upgrade, sysctl/bbr tuning. - Collapse the 12 journal-rotation cron tasks to one; consolidate duplicate download/broker logic; fix broken tests/test.yml role reference. - Validated ansible-lint clean at the production profile (ansible-core 2.21 / python 3.12) and ansible-playbook --syntax-check OK. |