| 7 years agoTsaukpaetra liked a comment on review 23147 for mainYou would need to merge down the latest changes to your branch, then copy up you changes to the parent and shelve them for review. I only see changes ...You would need to merge down the latest changes to your branch, then copy up you changes to the parent and shelve them for review. I only see changes/reviews on the parent branch not everyones private branches. « | |
|
|
| 7 years agoTsaukpaetra commented on review 23147 for mainok, so I need a shelved changelist on the parent branch, gotcha. I'll see what I can do... | |
|
|
| 7 years agoPaul Allen commented on review 23147 for mainYou would need to merge down the latest changes to your branch, then copy up you changes to the parent and shelve them for review. I only see changes ...You would need to merge down the latest changes to your branch, then copy up you changes to the parent and shelve them for review. I only see changes/reviews on the parent branch not everyones private branches. « | |
|
|
| 7 years agoTsaukpaetra commented on review 23147 for main@paul_allen I guess I just don't really understand according to the doc located at https://swarm.workshop.perforce.com/files/guest/perforce_software/contributing.md seems to indicate merely requesting a review should be all I need to do after committing changes.
Is this incorrect?
If so, I guess I'm emailing support to fix the docs and tell me what I did wrong, as far as I can tell everything needed to know about this request is publicly available (confirmed by incognito mode), so I don't know what else needs to be done.... « | |
|
|
| 7 years agoTsaukpaetra commented on review 23147 for mainIt's not an alternate workspace root, it's the workspace root that jenkins sets up according to the profile in the job configuration. Every time a wor ...It's not an alternate workspace root, it's the workspace root that jenkins sets up according to the profile in the job configuration. Every time a workspace poll occurs, it ends up re-writing the client definition (and the workspace root) to Jenkin's working directory.
More details in my ticket there: https://issues.jenkins-ci.org/browse/JENKINS-46908
I'm not sure why this branch is private, I can't find any settings for that at all (and again, the contribution document doesn't mention this at all :( ) I'll try adding you as a member? « | |
|
|
| 7 years agoPaul Allen commented on review 23147 for mainSorry if I missed your change/comment, but I have no visibility of your private branch.
I'm not sure why you are trying to set an alternative worksp ...Sorry if I missed your change/comment, but I have no visibility of your private branch.
I'm not sure why you are trying to set an alternative workspace root? Jenkins manages where the code will build. For example, if you use a slave the code could get built on another machine. With pipeline Jobs you can use ws() to change Jenkins build workspace and as a result the client root for sync. Alternatively you could use the Workspace View to remap some paths.
Please contact our support team support@perforce.com as they can give you specific help or you could ask the Jenkins community on the JIRA pages:
https://issues.jenkins-ci.org/secure/RapidBoard.jspa?rapidView=141 « | |
|
|
| 7 years agoTsaukpaetra commented on review 23147 for mainSince I have no idea how to attract reviewers... Um... @paul_allen ? Is mentioning active users the right thing?
Contribution info docs are really va ...Since I have no idea how to attract reviewers... Um... @paul_allen ? Is mentioning active users the right thing?
Contribution info docs are really vague, sorry if I'm misstepping. « | |
|
|
| 7 years agoTsaukpaetra committed change 23166 into main Merge down from main | |
|
|
| 7 years agoTsaukpaetra requested review 23165 for main Add configuration parameter for choosing whether to allow auto-submission of config changes to perforce. | |
|
|
| 7 years agoTsaukpaetra committed change 23164 into main Add configuration parameter for choosing whether to allow auto-submission of config changes to perforce. | |
|
|
| 7 years agoTsaukpaetra requested review 23163 for main Allow expandedDesc to be used if only Description has been set | |
|
|
| 7 years agoTsaukpaetra committed change 23162 into main Allow expandedDesc to be used if only Description has been set | |
|
|
| 7 years agoTsaukpaetra requested review 23147 for main Try to avoid setting a different workspace root on the client. | |
|
|
| 7 years agoTsaukpaetra committed change 23146 into main Try to avoid setting a different workspace root on the client. | |
|
|
| 7 years agoTsaukpaetra committed change 23141 into main "Forking branch Main of p4-jenkins to Tsaukpaetra-p4jenkins." | |
|
|
