| 8 years agoC. Thomas Tyler requested review 22463 for mainFixed a bug with logging enhancements in @19223.
Changed default value for $sameName to 1, indicating job names should
match issue names from the d...efect tracking system, as that is the
preferred and most commonly used setting.
#review @karl_wirth « | |
|
|
| 8 years agoC. Thomas Tyler committed change 22462 into mainFixed a bug with logging enhancements in @19223.
Changed default value for $sameName to 1, indicating job names should
match issue names from the d...efect tracking system, as that is the
preferred and most commonly used setting.
#review @karl_wirth « | |
|
|
| 9 years agoC. Thomas Tyler requested review 19244 for main | |
|
|
| 9 years agoC. Thomas Tyler committed change 19243 into main | |
|
|
| 9 years agoC. Thomas Tyler rejected review 19226 for main Backing out this change per comments form Karl and Joel. | |
|
|
| 9 years agoC. Thomas Tyler commented on review 19226 for mainThanks for the feedback! I'll back out this change. | |
|
|
| 9 years agoC. Thomas Tyler approved review 19224 for main Karl gave this a +1; approving. | |
|
|
| 9 years agoC. Thomas Tyler approved review 19222 for main Karl gave this a +1, approving. | |
|
|
| 9 years agoC. Thomas Tyler archived review 18828 for main | |
|
|
| 9 years agoC. Thomas Tyler archived review 18825 for main | |
|
|
| 9 years agoC. Thomas Tyler archived review 18822 for main | |
|
|
| 9 years agoKarl Wirth voted up review 19222 for mainRemoved the 'host:' prefix of the sample P4PORT value, to promote the
best pratice of using purely numeric P4PORT value for trigger and
broker script...s.
There's never reason for a server-side trigger (or broker) script to
specify the optional 'host:' portion of a P4PORT value, and in fact
doing so can be dangerous. Having a hard-coded 'host:' field makes it
all too easy for testing of triggers on a development server to
interact unwitingly with the live production server.
#review @karl_wirth « | |
|
|
| 9 years agoKarl Wirth voted up review 19224 for mainLogging enhancement: If LOGS environment varialbe is defined, store
the log file in that directory.
This makes P4DTG work work in an SDP envi...ronment, but without
introducing any dependency on the SDP. The SDP defines LOGS in the
shell environment before starting the p4d server process, thus making
it available to all trigger scripts.
#review @karl_wirth « | |
|
|
| 9 years agoKarl Wirth commented on review 19226 for mainAgree. Jira workflows are too configurable. We still recommend that you update a custom field called 'P4Status' (for example) then let a JIRA trigger ...Agree. Jira workflows are too configurable. We still recommend that you update a custom field called 'P4Status' (for example) then let a JIRA trigger decide if that's a valid state change. The alternative would be to write an API request that checks if the state change were valid before trying to replicate it (if possible), but that has scaling and maintenance issues. « | |
|
|
| 9 years agoJoel Brown commented on review 19226 for mainPrefer not. Fine for bugzilla. For JIRA, we strongly advise NOT to mirror status so no need to change. Note that this setting has no affect on ...Prefer not. Fine for bugzilla. For JIRA, we strongly advise NOT to mirror status so no need to change. Note that this setting has no affect on jobs status changes via a fix with a submit. « | |
|
|
| 9 years agoC. Thomas Tyler committed change 19227 into main Updated copyright year.
No functional change. | |
|
|
| 9 years agoC. Thomas Tyler requested review 19226 for mainAllow users to set the 'Status' field value from Perforce.
#review @karl_wirth | |
|
|
| 9 years agoC. Thomas Tyler committed change 19225 into mainAllow users to set the 'Status' field value from Perforce.
#review @karl_wirth | |
|
|
| 9 years agoC. Thomas Tyler requested review 19224 for mainLogging enhancement: If LOGS environment varialbe is defined, store
the log file in that directory.
This makes P4DTG work work in an SDP envi...ronment, but without
introducing any dependency on the SDP. The SDP defines LOGS in the
shell environment before starting the p4d server process, thus making
it available to all trigger scripts.
#review @karl_wirth « | |
|
|
| 9 years agoC. Thomas Tyler committed change 19223 into mainLogging enhancement: If LOGS environment varialbe is defined, store
the log file in that directory.
This makes P4DTG work work in an SDP envi...ronment, but without
introducing any dependency on the SDP. The SDP defines LOGS in the
shell environment before starting the p4d server process, thus making
it available to all trigger scripts.
#review @karl_wirth « | |
|
|
| 9 years agoC. Thomas Tyler requested review 19222 for mainRemoved the 'host:' prefix of the sample P4PORT value, to promote the
best pratice of using purely numeric P4PORT value for trigger and
broker script...s.
There's never reason for a server-side trigger (or broker) script to
specify the optional 'host:' portion of a P4PORT value, and in fact
doing so can be dangerous. Having a hard-coded 'host:' field makes it
all too easy for testing of triggers on a development server to
interact unwitingly with the live production server.
#review @karl_wirth « | |
|
|
| 9 years agoC. Thomas Tyler committed change 19221 into mainRemoved the 'host:' prefix of the sample P4PORT value, to promote the
best pratice of using purely numeric P4PORT value for trigger and
broker script...s.
There's never reason for a server-side trigger (or broker) script to
specify the optional 'host:' portion of a P4PORT value, and in fact
doing so can be dangerous. Having a hard-coded 'host:' field makes it
all too easy for testing of triggers on a development server to
interact unwitingly with the live production server.
#review @karl_wirth « | |
|
|
| 9 years agoC. Thomas Tyler approved review 18822 for mainRemoved the 'host:' prefix of the sample P4PORT value, to promote the
best pratice of using purely numeric P4PORT value for trigger and
broker scrip...ts.
There's never reason for a server-side trigger (or broker) script to
specify the optional 'host:' portion of a P4PORT value, and in fact
doing so can be dangerous. Having a hard-coded 'host:' field makes it all
too easy for testing of triggers on a development server to interact with
the live production server.
#review @karl_wirth « | |
|
|
| 9 years agoC. Thomas Tyler requested review 18828 for mainAllow users to set the 'Status' field from Perforce.
#review @karl_wirth | |
|
|
| 9 years agoC. Thomas Tyler requested review 18825 for mainLogging enhancement: If LOGS environment varialbe is defined, store
the log file in that directory.
This makes P4DTG work work in an SDP envi...ronment, but without introducing
any dependency on the SDP. The SDP defines LOGS in the p4d before starting
the server, thus making it available to all server-side triggers.
#review @karl_wirth « | |
|
|
| 9 years agoC. Thomas Tyler requested review 18822 for mainRemoved the 'host:' prefix of the sample P4PORT value, to promote the
best pratice of using purely numeric P4PORT value for trigger and
broker script...s.
There's never reason for a server-side trigger (or broker) script to
specify the optional 'host:' portion of a P4PORT value, and in fact
doing so can be dangerous. Having a hard-coded 'host:' field makes it all
too easy for testing of triggers on a development server to interact with
the live production server.
#review @karl_wirth « | |
|
|
| 10 years agoBruce McPeek commented on change 12396 (changeid.pl, line 47) for main | |
|
|
| 10 years agoMatt Attaway commented on change 12396 for mainNew versions of changed.pl and README.txt with proper newlines have been pushed.
That note in the README is fine. I'll clean it up, but it's from the ...New versions of changed.pl and README.txt with proper newlines have been pushed.
That note in the README is fine. I'll clean it up, but it's from the days when you had send us your first born to get access to the SDK. « | |
|
|
| 10 years agoMatt Attaway commented on change 12396 (changeid.pl, line 47) for mainThis script is a trigger used to enforce some behavior in Perforce that Bugzilla requires. I don't think it's for transitioning. | |
|
|
| 10 years agoBruce McPeek commented on change 12396 (changeid.pl, line 47) for mainSince this is a script to allow a system previously using P4DTI to more easily transition to P4DTG, shouldn't the $p4authuser be set to the user that ...Since this is a script to allow a system previously using P4DTI to more easily transition to P4DTG, shouldn't the $p4authuser be set to the user that P4DTI used?
For my situation of moving from P4DTI to P4DTG, I have a bit of existing infrastructure that uses the P4DTI-replicator0 user. I had thought to update the name but since it was not an user facing account and I would have to touch some of my infrastructure scripts that would otherwise go untouched, it was a simple decision to keep the old name for the replication user. « | |
|
|
| 10 years agoMatt Attaway commented on change 12396 for mainThat's.... interesting. Considering I did it all on a Mac I'm not sure where the \r\n's could have come from. I'll resubmit with the line endings clea ...That's.... interesting. Considering I did it all on a Mac I'm not sure where the \r\n's could have come from. I'll resubmit with the line endings cleaned up. « | |
|
|
| 10 years agoBruce McPeek commented on change 12396 (changeid.pl, line 1) for mainDitto for the changeid.pl script on the line ending comment made for README.txt. | |
|
|
| 10 years agoBruce McPeek commented on change 12396 (README.txt, line 1) for mainThe diff is showing line ending differences.
Is this the always fun issue of line endings, mixed platform environments, and the LineEnd: setting in th ...The diff is showing line ending differences.
Is this the always fun issue of line endings, mixed platform environments, and the LineEnd: setting in the client spec? « | |
|
|
| 10 years agoBruce McPeek commented on change 12396 (README, line 6) for mainShould this statement be of concern given this has been released to workshop? | |
|
|
| 10 years agoMatt Attaway commented on change 12396 for mainJust a heads up for those following; P4DTG-SDK has been updated with the code for the JIRA REST API. Apologies for the delay. | |
|
|
| 10 years agoMatt Attaway commented on change 8981 for main | |
|
|
| 10 years agoBruce McPeek commented on change 8981 for mainHi Matt,
A gentle ping... | |
|
|
| 10 years agoMatt Attaway commented on change 8981 for mainMost definitely. I'll work to get it out this week; sorry for the delay. | |
|
|
| 10 years agoBruce McPeek commented on change 8981 for mainHi Matt,
Could you update the p4dtg source with the REST changes now that it has been out a while? | |
|
|
| 10 years agoMatt Attaway commented on change 8981 for mainCompletely agree. There's a lot of polish work we need to do for these projects; thankfully we have another set of hands joining us soon. I'll put the ...Completely agree. There's a lot of polish work we need to do for these projects; thankfully we have another set of hands joining us soon. I'll put these in our backlog. « | |
|
|
| 10 years agomarct22 commented on change 8981 for maincan we also have a distro directory in https://swarm.workshop.perforce.com/files/guest/perforce_software/p4dtg-sdk that has the last bundled installer (perhaps with some kind of version number or patch version) and a tgz or zip of the source code that made that particular installer?
perhaps something looking like how sdp is doing it (other than they don't add a source bundle) like https://swarm.workshop.perforce.com/files/guest/perforce_software/sdp/dist While source is secondary and I guess if you don't want to do it, that's ok with me, I can get it out of perforce, provided there's some way to identify which versions are in a particular release label/rel stream), it would be nice for the installer versions for windows and *nix.
THen maybe have a way to tell people where to download the installer at if they are looking at the P4DtG-SDK project in the 'Overview -> about' « | |
|
|
| 10 years agoMatt Attaway commented on change 8981 for mainThe REST version will be available in November. I'll make sure that the Workshop is promptly updated at the same time. | |
|
|
| 11 years agoMatt Attaway commented on change 8981 for mainSorry for the slow response; I need to check with the dev team to see if the REST version is ready to publish. It should below; when were putting the ...Sorry for the slow response; I need to check with the dev team to see if the REST version is ready to publish. It should below; when were putting the finishing touches on it when I first pushed the DTG code. I'll check up and let you know! « | |
|
|
| 11 years agomarct22 commented on change 8981 for mainI am looking at p4dtg and jira 6.x. The docs say to enable RPC-Jira, but that plugin is deprecated. I'm having problems just finding that plugin. At ... | |
|
|
| 11 years agorsmith commented on change 8981 for mainJust to confirm, our Corporate firewall was blocking the outbound connection for port 1666. Sorry for the confusion. | |
|
|
| 11 years agorsmith commented on change 8981 for mainyeah, I'm def behind the corp mosquito net. I can't reach public.perforce.com on 1666 either.
I'll inquire with our IT folks. Thanks and thanks for fi ...yeah, I'm def behind the corp mosquito net. I can't reach public.perforce.com on 1666 either.
I'll inquire with our IT folks. Thanks and thanks for fixing the links. « | |
|
|
| 11 years agoMatt Attaway commented on change 8981 for mainI've also added a rule to properly handle those wiki links; I rejiggered some rewrite rules last week and I accidentally broke the old wiki links. Tha ...I've also added a rule to properly handle those wiki links; I rejiggered some rewrite rules last week and I accidentally broke the old wiki links. Thanks for letting me know. « | |
|
|
| 11 years agoMatt Attaway commented on change 8981 for mainI just double checked and the Workshop server appears to be up and happy. Are you connecting from behind a corporate firewall? I've seen a couple case ...I just double checked and the Workshop server appears to be up and happy. Are you connecting from behind a corporate firewall? I've seen a couple cases now where firewalls have prevented people from accessing the Workshop p4d. « | |
|
|
| 11 years agoLiz Lam commented on change 8981 for mainpublic.perforce.com:1666 should work. | |
|
|
| 11 years agorsmith commented on change 8981 for mainHow can I grab the code with a p4 client without having to use a browser file-by-file? workshop.perforce.com:1666 always responds with connection refu ... | |
|
|
