on further thought, you'd probably want to pass in the instance number just like you do with mkdirs.sh and configure_new_server.sh, that way you don't have to hack the file for each new instance (and update the guides to reflect the instance argument

odd, when I run p4login per the SDP User guide, it fails. I get ./p4login: line 29: /p4//logs/p4login.log: No such file or directory. This is because $INSTANCE is not set.
If I manually do export INSTANCE=1, then it appears to work but yet it doesn't. cat /p4/1/logs/p4login.log, I now get the message
./p4login: line 29: -p: command not found
Is there a line missing in p4login? like source /p4/common/bin/p4_vars 1 (assuming instance 1)?

While this isn't about comments on typos, was wondering if the documentation should have recommendations on NOT using NFS mounts for metadata and logs or wherever the journal file is to reside. This is to minimize file locking issues if the metadata is on an nfs-mount, and to eliminate a source of slowdown if the journal is on an nfs mount.

Cool!

Uh, sorry about this, but another couple of comments, particularly around p4_vars and configure_new_server.sh

In certain sites, P4PORT cannot be just 1666, some sites have to specify the hostname like P4PORT=blah:1666
So if you so export P4PORT=blah:1666
then do a p4 login, you create that .p4ticket in your home directory.
But when you invoke configure_new_server.sh, it runs 'source p4_vars $instancenum'. p4_vars re-sets P4PORT to just 1666 (assuming $instancenum=1), and then you get the dreaded P4PASSWD invalid or unset error, and you don't know why. You may want to add a step somewhere saying that either p4_vars or p4_vars.template needs to be modified so that p4_vars is correct for P4PORT.

2nd comment is over P4TICKET. by default, if I log in as the user 'perforce', and do p4 login, it will create the .p4ticket in /p4. Again, p4_vars looks for it in /p4/1/, and you again get that error.

Instructions need to be included such that, for the default user 'perforce'. My guess (I haven't tested it out) that that user's .bashrc or .bash_profile should have the P4TICKET environment variable set. I haven't thought it through yet on what to do if that same user also admin's more than one instance.

I got around it by just changing p4_var's P4TICKET to just /p4, but of course, that means that the login works for all p4 intances on that machine since they all would share the ticket.

Anyhoo, just more food for thought!

sorry, this has nothing to do with the readme files, but in looking at the SDP guides (both docx and pdf) that's bundled in the unix gz (in doc/), in the section 'Starting the server", it doesn't seem to start the server. I see nothing about invoking p4d_1_init. I see stuff about crontab and init scripts from within the $SDP directory, and running configure_server, but nothing about really starting p4d. Is this a bug?

can we also have a distro directory in https://swarm.workshop.perforce.com/files/guest/perforce_software/p4dtg-sdk that has the last bundled installer (perhaps with some kind of version number or patch version) and a tgz or zip of the source code that made that particular installer?
perhaps something looking like how sdp is doing it (other than they don't add a source bundle) like https://swarm.workshop.perforce.com/files/guest/perforce_software/sdp/dist While source is secondary and I guess if you don't want to do it, that's ok with me, I can get it out of perforce, provided there's some way to identify which versions are in a particular release label/rel stream), it would be nice for the installer versions for windows and *nix.

THen maybe have a way to tell people where to download the installer at if they are looking at the P4DtG-SDK project in the 'Overview -> about'

A comment in general. When I go to SDP project, I see the latest reviews, members and followers, etc, I can browse through the files on main, but one thing I can't find is how to download it. While I did eventually find it (it's not on SDP project 'files' at all, at least not as I have found so far), but outside in //guest/perforce_software/sdp/dist folder (I just saw Tom's last comment on that last commit he did, and only because he added a comment that he updated the distro, then I was able to find it. Is there a way to modify the 'About' SDP to add a link to //guest/perforce_software/sdp/distro? I can't find it anymore on ftp.perforce.com (it used to be in private/outgoing, but I can't ls to see if it got renamed, looked around, but couldn't stumble on it).

and another comment, totally unrelated to SDP, how can I change my icon? If I go to my profile, All I can change is my password and do RSS, and view stuff (comments, reviews, changes (of which I only have a comment, maybe two after I click 'post')

I am looking at p4dtg and jira 6.x. The docs say to enable RPC-Jira, but that plugin is deprecated. I'm having problems just finding that plugin. Atlassian says they are moving from SOAP to REST. Is there plans to switch to REST? https://developer.atlassian.com/display/JIRADEV/SOAP+and+XML-RPC+API+Deprecated+in+JIRA+6.0