Helix SwarmHelix Swarm

SeanHalliday

SeanHalliday (SeanHalliday)
  • 0
    Followers
  • 0
    Following
  • 0
    Projects
Full Name
SeanHalliday
Email address
shalliday@ea.com
Followers
  • Activity
  • Shelves
  • Settings
  • Notifications

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
9 years agoSeanHalliday created job000402 for perforce-software-p4api-net:
Please allow Connection.Connect to be cancelled.
Add a comment
9 years agoSeanHalliday modified job000401 for perforce-software-p4api-net:
Add flags to P4CommandResult to disable the serialization from C++ results to C# results.
 For example, don't update the TaggedOutput.
1 comment
9 years agoSeanHalliday commented on job000401 for

We wrote our own custom P4CommandResult to work around this. The issue we were having was that for large result sets we were already filtering the re

...

We wrote our own custom P4CommandResult to work around this. The issue we were having was that for large result sets we were already filtering the results and updating our own data structures using the TaggedObject callbacks. The issue is that a great deal of memory is allocated after the command runs to populate the TaggedObjects in the P4CommandResult because it must serialize all the data from unmanaged results in C++ to a dictionary per result in C#. All that is needed is a flag on the results class to disable this serialization (for Tagged, Info, Binary, etc.)

 «
1 comment
9 years agoSeanHalliday created job000401 for perforce-software-p4api-net:
Add flags to P4CommandResult to disable the serialization from C++ results to C# results.
 For example, don't update the TaggedResults.
1 comment
10 years agoSeanHalliday created job000346 for perforce-software-p4api-net:
The API should verify that the command is completed if StartQueryCancel returns false and throw an Exception stating that StartQueryCancel should not... return unless cancelled or completed. «
Add a comment
10 years agoSeanHalliday created job000345 for perforce-software-p4api-net:
Please add Connection.CancelCommand(uint cmdId).
 This will make it possible to cancel commands called via the Repository.
Add a comment
No shelved changes.

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default
Check all
I change the state of a review
I am the author, and
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed