| 7 years agobrandon_m_bare committed change 23585 into Added new file types to the list of valid extensions. | ||
Add a comment | ||
| 8 years agobrandon_m_bare committed change 22261 into Added support for Visual Studio 2017. | ||
| 8 years agobrandon_m_bare approved review 20952 for shadauxcat-libsprawl:mainline - Reworked ConcurrentQueue::Dequeue to be a lot faster and wait-free - Added constexpr constructor for sprawl tag - Added support for specifying base... for int-to-tag conversion - Added ability to force poolallocator to pass through to malloc - Added a helper class that will eventually be used in StringBuilder for faster int-to-string conversion #review post-commit « | ||
| 8 years agobrandon_m_bare approved review 20959 for shadauxcat-libsprawl:mainline New memory management startegy for ConcurrentQueue that eliminates the need for traditional reference counting and now uses a decrement-only counter t...o reliably clean up memory without stomping on any other threads. The removal of the reference counting, and the movement of the buffer capacity check to a member variable on the queue itself, has resulted in a performance increase of roughly 20-25% and eliminated a very rare accounting error. Also cleaned up the comments and removed a commented-out alternative implementation of Dequeue(). #review post-commit « | ||
| 8 years agobrandon_m_bare commented on review 20959 (UnitTests_ConcurrentQueue.cpp, line 21) for shadauxcat-libsprawl:mainline This could probably be | ||
| 8 years agobrandon_m_bare commented on review 20952 (StringBuilder.cpp, line 7) for shadauxcat-libsprawl:mainline Looks like you got an extra 'b' in there. | ||
| 8 years agobrandon_m_bare commented on review 20952 (PoolAllocator.hpp, line 67) for shadauxcat-libsprawl:mainline Just fyi, I remember jemalloc defining this per-platform and only some have the ability to query the system for the exact value. | ||
| 8 years agobrandon_m_bare commented on review 20952 (ConcurrentQueue.hpp, line 91) for shadauxcat-libsprawl:mainline Shouldn't this one be dereferencing the memory? | ||
| 8 years agobrandon_m_bare commented on review 20952 (ConcurrentQueue.hpp, line 78) for shadauxcat-libsprawl:mainline Double semicolon. | ||
| 8 years agobrandon_m_bare commented on review 20952 (UnitTests_ConcurrentQueue.cpp, line 197) for shadauxcat-libsprawl:mainline How is this expected to work? | ||
| 8 years agobrandon_m_bare commented on review 20952 (UnitTests_ConcurrentQueue.cpp, line 138) for shadauxcat-libsprawl:mainline And this one is | ||
| 8 years agobrandon_m_bare commented on review 20952 (UnitTests_ConcurrentQueue.cpp, line 80) for shadauxcat-libsprawl:mainline Another | ||
| 8 years agobrandon_m_bare commented on review 20952 (UnitTests_ConcurrentQueue.cpp, line 15) for shadauxcat-libsprawl:mainline Is there a reason you left this here? | ||
| 9 years agobrandon_m_bare approved review 19913 for shadauxcat-libsprawl:mainline Fix various linux warnings and errors under clang 3.6 | ||
| 9 years agobrandon_m_bare approved review 19911 for shadauxcat-libsprawl:mainline | ||
| 9 years agobrandon_m_bare approved review 19909 for shadauxcat-libsprawl:mainline | ||
| 9 years agobrandon_m_bare approved review 19907 for shadauxcat-libsprawl:mainline - Added tag, compile time string type - Since tag requires visual studio 2015, removed compatibility code for earlier versions of visual studio - Imp...roved compiler detection - Added endianness detection - Added template if/else helper - Fixed bug with murmur3 64 bit - Added seed argument for murmur3 « | ||
| 9 years agobrandon_m_bare committed change 18645 into Integrated latest version of libsprawl. | ||
| 9 years agobrandon_m_bare committed change 18285 into shadauxcat-csbuild:brandon-m-bare -- Switched the manual logic of reconstructing the command line arguments to using subprocess.list2cmdline(). -- Changed the visual studio project ge...nerator to create a batch file that handles project regeneration and the (REGENERATION_SOLUTION) project just calls into that batch file. #review-17245 @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 18284 for shadauxcat-csbuild:brandon-m-bare | ||
| 9 years agobrandon_m_bare committed change 18283 into shadauxcat-csbuild:brandon-m-bare | ||
| 9 years agobrandon_m_bare requested review 17245 for shadauxcat-csbuild:brandon-m-bare -- Switched the manual logic of reconstructing the command line arguments to using subprocess.list2cmdline(). -- Changed the visual studio project ge...nerator to create a batch file that handles project regeneration and the (REGENERATION_SOLUTION) project just calls into that batch file. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 17242 for shadauxcat-csbuild:brandon-m-bare -- Changed the default value for the stdLib to an empty string and preventing it from being passed in the gcc toolchain unless it's explicitly set in... the makefile. -- Moved the objc abi version arg in the gcc toolchain to the extended command method and now not passing it if the input file is not an objective c/c++ file. -- Updated the README and setup.py. -- Fixed an out-of-date error message. -- Fixed a string in the gui, making it more consistent with our usage pattern for unicode strings. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare committed change 17241 into shadauxcat-csbuild:brandon-m-bare -- Changed the default value for the stdLib to an empty string and preventing it from being passed in the gcc toolchain unless it's explicitly set in... the makefile. -- Moved the objc abi version arg in the gcc toolchain to the extended command method and now not passing it if the input file is not an objective c/c++ file. -- Updated the README and setup.py. -- Fixed an out-of-date error message. -- Fixed a string in the gui, making it more consistent with our usage pattern for unicode strings. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare committed change 17202 into shadauxcat-csbuild:brandon-m-bare -- Added /usr/local/include as a default include directory to the gcc_darwin toolchain. -- Added the ability to have default library directories in th...e gcc_darwin toolchain along with the initial defaults of /usr/lib and /usr/local/lib. #review-16884 @ShadauxCat « | ||
| 9 years agobrandon_m_bare committed change 17201 into shadauxcat-csbuild:brandon-m-bare | ||
| 9 years agobrandon_m_bare committed change 17200 into shadauxcat-csbuild:brandon-m-bare Fixed the issues that were causing the profile window and context menu to hang the entire gui when running pyqt5 under python3. (Submitting from a di...fferent changelist because the old one is on a computer I no longer have access to.) #review-16650 @ShadauxCat « | ||
| 9 years agobrandon_m_bare updated files in review 16884 for shadauxcat-csbuild:brandon-m-bare -- Added /usr/local/include as a default include directory to the gcc_darwin toolchain. -- Added the ability to have default library directories in th...e gcc_darwin toolchain along with the initial defaults of /usr/lib and /usr/local/lib. #review-16884 @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 16884 for shadauxcat-csbuild:brandon-m-bare -- Added /usr/local/include as a default include directory to the gcc_darwin toolchain. -- Added the ability to have default library directories in th...e gcc_darwin toolchain along with the initial defaults of /usr/lib and /usr/local/lib. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 16856 for shadauxcat-csbuild:brandon-m-bare | ||
| 9 years agobrandon_m_bare committed change 16824 into shadauxcat-csbuild:brandon-m-bare Fixed an exception when logging occurs outside of a decorated function in the makefile when running it with --help. #review-16822 @ShadauxCat | ||
| 9 years agobrandon_m_bare requested review 16822 for shadauxcat-csbuild:brandon-m-bare Fixed an exception when logging occurs outside of a decorated function in the makefile when running it with --help. #review @ShadauxCat | ||
| 9 years agobrandon_m_bare approved review 16769 for shadauxcat-libsprawl:mainline Improvements to error handling in builds with exceptions disabled: - In debug builds or with SPRAWL_ERRORSTATE_STRICT enabled, ErrorState will output... a message to stderr and terminate if Get() is called when an error flag is set. (In release buils or with SPRAWL_ERRORSTATE_PERMISSIVE defined, Get() will return junk memory in this case.) - In debug builds or with SPRAWL_ERRORSTATE_STRICT enabled, ErrorState will output a message to stderr and terminate if its destructor is called without checking the errorstate if an error is present (equivalent to an exception terminating the application if no catch() block is present for it). - On linux builds and when running "Analyze" through visual studio, a warning will be issued if any function returning ErrorState has its return value ignored. (This only applies to builds with exceptions not enabled; when exceptions are enabled no warning is issued) - Many functions that could return ErrorState were having their return values silently ignored in internal sprawl code so the user would not find out about errors if exceptions are disabled; now anything in sprawl code that calls a function returning ErrorState will either handle the error, or (in most cases) surface it back up to the user. - As a positive side-effect of the warnings for ignoring ErrorState, several constructors that were capable of throwing exceptions are no longer capable of doing so. « | ||
| 9 years agobrandon_m_bare commented on review 16769 (compat.hpp, line 64) for shadauxcat-libsprawl:mainline Is OPTIMIZE defined on all compilers? I know gcc and clang have it, but I don't recall seeing it in msvc. | ||
| 9 years agobrandon_m_bare commented on review 16769 (UnitTests_Exceptions.cpp, line 30) for shadauxcat-libsprawl:mainline Not even if they're defined as static? | ||
| 9 years agobrandon_m_bare commented on review 16769 (UnitTests_Exceptions.cpp, line 52) for shadauxcat-libsprawl:mainline Since the following tests have death tests (and some platforms have problems handling those), I would recommend adding "&& GTEST_HAS_DEATH_TES ...Since the following tests have death tests (and some platforms have problems handling those), I would recommend adding "&& GTEST_HAS_DEATH_TEST" to the #if condition. « | ||
| 9 years agobrandon_m_bare commented on review 16769 (UnitTests_Exceptions.cpp, line 30) for shadauxcat-libsprawl:mainline These 2 variables are only used inside the following test. Wouldn't it be better to define them in there rather than at the global scope? | ||
| 9 years agobrandon_m_bare requested review 16650 for shadauxcat-csbuild:brandon-m-bare Fixed the issues that were causing the profile window and context menu to hang the entire gui when running pyqt5 under python3. #review @ShadauxCa...t « | ||
| 9 years agobrandon_m_bare committed change 16635 into shadauxcat-csbuild:brandon-m-bare -- Fixed the GUI not working correctly when only warnings and errors from the linker would be present during a build. -- Fixed QtMessageBox not being... aliased for pyqt5. #review-16633 @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 16633 for shadauxcat-csbuild:brandon-m-bare -- Fixed the GUI not working correctly when only warnings and errors from the linker would be present during a build. -- Fixed QtMessageBox not being... aliased for pyqt5. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare committed change 16488 into shadauxcat-csbuild:brandon-m-bare -- Added additional command line arguments for osx and ios for overriding the target versions to compile against. -- Added assertions on setting the... target version for osx and ios to validate the selected version is actually installed. #review-16363 @ShadauxCat « | ||
| 9 years agobrandon_m_bare commented on review 16363 (toolchain_gcc.py, line 340) for shadauxcat-csbuild:brandon-m-bare As much as I'd like to just have to call this fewer times, I don't think we can. Build settings may change between different targets or architectures ...As much as I'd like to just have to call this fewer times, I don't think we can. Build settings may change between different targets or architectures, which may be interleaved. It might be possible to do what you're talking about, but it may end up requiring architectural changes in the toolchains. « | ||
| 9 years agobrandon_m_bare approved review 16381 for shadauxcat-libsprawl:mainline Missed a header, also corrected missing newline in exceptions.hpp, also corrected exceptions.hpp being exceptions.h. | ||
| 9 years agobrandon_m_bare approved review 16379 for shadauxcat-libsprawl:mainline New exception framework, phase one. Added new class, ErrorState, for handling errors when exceptions are disabled. When exceptions are enabled, Err...orState<T> is an alias for T. When they're disabled, ErrorState<T> additionally encodes an error code, and will have junk data (and probably a crash) if an error is returned and not checked before the data is used. ErrorState<T> is implicitly convertible to and from T, so applications that don't care about errors can code like they don't exist... Phase two will involve overloading operators on ErrorState so that things that return ErrorState can still function as much as possible like they do when exceptions are enabled. « | ||
| 9 years agobrandon_m_bare commented on review 16379 (UnitTests_Path.cpp) for shadauxcat-libsprawl:mainline Unchanged file. | ||
| 9 years agobrandon_m_bare commented on review 16379 (Serializer.cpp, line 134) for shadauxcat-libsprawl:mainline You missed a space. | ||
| 9 years agobrandon_m_bare updated files in review 16363 for shadauxcat-csbuild:brandon-m-bare -- Added additional command line arguments for osx and ios for overriding the target versions to compile against. -- Added assertions on setting the... target version for osx and ios to validate the selected version is actually installed. #review-16363 @ShadauxCat « | ||
| 9 years agobrandon_m_bare committed change 16367 into shadauxcat-csbuild:brandon-m-bare Added the NsightTegraUpgradeOnceWithoutPrompt element to the Visual Studio project generator when generating for Android. This should hypothet...ically suppress the upgrade prompt for older project versions, but as of Nsight Tegra 3.1, it doesn't seem to work. Keeping it in since it seems reasonable that nvidia will fix that on their end. #review-16307 @ShadauxCat « | ||
| 9 years agobrandon_m_bare requested review 16363 for shadauxcat-csbuild:brandon-m-bare -- Added additional command line arguments for osx and ios for overriding the target versions to compile against. -- Added assertions on setting the... target version for osx and ios to validate the selected version is actually installed. #review @ShadauxCat « | ||
| 9 years agobrandon_m_bare committed change 16343 into Fixed the order of the revision histories in the release notes. | ||
Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).