Loading...
Helix SwarmHelix Swarm
Loading...

joel_kovisto

joel_kovisto (Joel Kovisto)
  • 0
    Followers
  • 0
    Following
  • 1
    Projects
Full Name
Joel Kovisto
Email address
jkovisto@perforce.com
Followers
Projects
  • P4Maven
    • Member
  • Activity
  • Shelves
  • Settings
  • Notifications

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
5 years agoJoel Kovisto commented on SDP-435 for

There is a strong need for this.

4 comments
6 years agoJoel Kovisto approved review 24619 for
Columns were definitely out of order for the process table - now corrected.
Didn't see any place else that might need changing.
4 comments
8 years agoJoel Kovisto commented on change 21770 for

Canonical copy to maintained here:
https://swarm.workshop.perforce.com/files/guest/perforce_software/admin_toolkit/p4dstate.sh

1 comment
8 years agoJoel Kovisto created job000708 for perforce-software-p4api-net:
Repository.GetUser() should be case-insensitive against a case-insensitive server.

Line 566 of Repository.user.cs has this, which is fine for the cas...e-sensitive server.

        if (to.ContainsKey("User") && to["User"] == user)

But it should be something like this against a case-insensitive server.

        if (to.ContainsKey("User") && to["User"].Equals(user, StringComparison.OrdinalIgnoreCase)

Case-sensitivity is maintained in Server.ServerMetaData.CaseSensitive. «
Add a comment
8 years agoJoel Kovisto commented on job000559 for

There is specific demand for this version of Strawberry Perl:
Platform:
osname=MSWin32, osvers=6.3, archname=MSWin32-x86-multi-thread-64int
uname='Wi

...

There is specific demand for this version of Strawberry Perl:
Platform:
osname=MSWin32, osvers=6.3, archname=MSWin32-x86-multi-thread-64int
uname='Win32 strawberry-perl 5.22.0.1 #1 Mon Jun 1 20:04:50 2015 i386'
config_args='undef'
hint=recommended, useposix=true, d_sigaction=undef
useithreads=define, usemultiplicity=define
use64bitint=define, use64bitall=undef, uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='gcc', ccflags =' -s -O2 -DWIN32 -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fwrapv -fno-strict-aliasing -mms-bitfields',
optimize='-s -O2',
cppflags='-DWIN32'
ccversion='', gccversion='4.9.2', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678, doublekind=3
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=8, longdblkind=3
ivtype='long long', ivsize=8, nvtype='double', nvsize=8, Off_t='long long', lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries:
ld='g++.exe', ldflags ='-s -L"C:\perl\perl\lib\CORE" -L"C:\perl\c\lib"'
libpth=C:\perl\c\lib C:\perl\c\i686-w64-mingw32\lib C:\perl\c\lib\gcc\i686-w64-mingw32\4.9.2
libs=-lmoldname -lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32 -lshell32 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm -lversion -lodbc32 -lodbccp32 -lcomctl32
perllibs=-lmoldname -lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32 -lshell32 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm -lversion -lodbc32 -lodbccp32 -lcomctl32
libc=, so=dll, useshrplib=true, libperl=libperl522.a
gnulibc_version=''
Dynamic Linking:
dlsrc=dl_win32.xs, dlext=xs.dll, d_dlsymun=undef, ccdlflags=' '
cccdlflags=' ', lddlflags='-mdll -s -L"C:\perl\perl\lib\CORE" -L"C:\perl\c\lib"'

 «
1 comment
9 years agoJoel Kovisto commented on job000204 for

Thanks!

4 comments
9 years agoJoel Kovisto updated description of review 16777 for p4-jenkins:main
[JENKINS-32351] Inject quotes around paths for label view in TaggingTask.java.
@pallen
Add a comment
9 years agoJoel Kovisto updated files in review 16777 for p4-jenkins:main
[JENKINS-32351] Inject quotes around paths for label view in TaggingTask.java.
Add a comment
9 years agoJoel Kovisto commented on change 16775 (TaggingTask.java) for p4-jenkins:main

Scratch this. My integ must have done nothing. The change isn't there.

1 comment
9 years agoJoel Kovisto requested review 16777 for p4-jenkins:main
[JENKINS-32351] Inject quotes around paths for label view in TaggingTask.java.
Add a comment
9 years agoJoel Kovisto created job000430 for perforce_software-p4python:
Help P4Python find correct SSL library.

Customer obtained P4Python from https://pypi.python.org/pypi/P4Python

Got this error when running on Mac.../Yosemite.

File "/Users/twick/sDev/tableau-tools/pipeline/common_dep/file_utils.py", line 11, in <module>

    from perforce import P4Conn

  File "/Users/twick/.tabvenvs/server-dev-b9be31fe483ffffa5a742dfb57832590/tube/lib/python3.4/site-packages/perforce/__init__.py", line 20, in <module>

    from P4 import P4, P4Exception, Map

  File "/Users/twick/.tabvenvs/server-dev-b9be31fe483ffffa5a742dfb57832590/tube/lib/python3.4/site-packages/P4.py", line 410, in <module>

    import P4API

ImportError: dlopen(/Users/twick/.tabvenvs/server-dev-b9be31fe483ffffa5a742dfb57832590/tube/lib/python3.4/site-packages/P4API.so, 2): Library not loaded: /opt/local/lib/libssl.1.0.0.dylib

  Referenced from: /Users/twick/.tabvenvs/server-dev-b9be31fe483ffffa5a742dfb57832590/tube/lib/python3.4/site-packages/P4API.so

  Reason: image not found

Suggest bundling libssl in the wheels (.whl files) they're publishing here, so that this problem can be avoided. «
Add a comment
9 years agoJoel Kovisto committed change 16715 into
Inject quotes around paths for label view in TaggingTask.java.
p4.jar and p4.hpi included.
Add a comment
9 years agoJoel Kovisto created job000368 for perforce_software-p4python:
P4Python documentation does not make it clear that keyword arguments are available for use.
A note that if P4Python methods are overridden **kargs sh...ould be accounted for should also be added.

Provide example code using **kargs. «
Add a comment
9 years agoJoel Kovisto created job000364 for perforce-software-p4eclipse:
P4Eclipse Time-lapse view to show relevant revision detail when cursor is on a related line of code.
 Currently the only way to show the revisi...on detail is through the ruler. «
Add a comment
10 years agoJoel Kovisto committed change 12940 into
P4BlameResult.processBlameLines() should use fileAnnotation.getLower() to show when the line was introduced.
Add a comment
10 years agoJoel Kovisto created job000230 for perforce-software-p4maven:
Allow UUID instead of path in client names.
 Paths can get quite long.  UUIDs are fixed at 37 chars.

See P4executor.generateClientName(...) «
Add a comment
10 years agoJoel Kovisto created job000229 for perforce-software-p4maven:
Client names include backslashes when generated from Windows.
 This causes problems for spec depots.

Should be able to add '\' to the regula...r expression in P4Executor.generateClientName().  Might need 4 backslashes to account for one.

                path = encodeWildcards(workDir.getCanonicalPath()
                        .replaceAll("[\\\\/ ~]", "-").replaceAll(",", "")); «
Add a comment
10 years agoJoel Kovisto commented on job000204 for

It's possible this might work in 2014.2.

4 comments
10 years agoJoel Kovisto created job000204 for
P4::Progress does not appear to work.

We are having some issues with P4::Progress in P4PERL. P4::Progress does not work in either P4Perl 2012.2 or 20...14.1

If we try following the example code in the POD for P4::Progress (perldoc P4::Progress) and then do a $p4->RunSync('-q','-f','...') for example, none of the callbacks get called. Performing the same operation at the CLI works as expected.

Also, the unit test provided for P4::Progress, t/55-progress.t does not verify any of the expected behaviors (none of the values of %count are verified); so the fact that this test passes doesn't prove anything. «
4 comments
11 years agoJoel Kovisto commented on change 10009 for

Thanks, that's a better test. I looked for that, but somehow didn't see it documented (just rfind). Got no help from vi.

2 comments
11 years agoJoel Kovisto committed change 10010 into
Better test for reviews users
Add a comment
11 years agoJoel Kovisto committed change 10009 into
Setting to not send emails to git-fusion-reviews- users
2 comments
11 years agoJoel Kovisto committed change 10008 into
integ p4review_py from perforce_software
Add a comment
13 years agoJoel Kovisto committed change 8154 into
Implementation of ISSOCallback for P4Java
Add a comment
Change User Description Created
16775 Joel Kovisto [JENKINS-32351] Inject quotes around paths for label view in TaggingTask.java. 9 years ago View Review

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default
Check all
I change the state of a review
I am the author, and
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed