10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Back out unnecessary changes. | ||
36 comments | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Back out unnecessary changes to test_config | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Add first part of configuration for enabling GitFusion. | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Move GitFusion strings encoding to a sepearate gem, refactor bits in client and HWS. Modify run_files for user keys for GF 15.2 | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Add a special user to p4init. | ||
10 years agoptomiak commented on review 15549 for perforce-software-helix-web-services:main I tried to find where you set the test users up - like the JDOE_USER one. I tried to find where you set the test users up - like the JDOE_USER one. Could you point me to the magic that automagically creates users? « | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Pull in latest changes. Revert changes to hws_web_services. | ||
10 years agoptomiak commented on review 15549 for perforce-software-helix-web-services:main There are two more endpoints that were requested - thing is, I would have to wait for GitFusion to implement features on their side, so for now thats ...There are two more endpoints that were requested - thing is, I would have to wait for GitFusion to implement features on their side, so for now thats all I can do. « | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Style changes, nothing major. Change message severity to 3 on git-fusion errors, and return code back to 0. | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Clean up file upload, remove obsolete file. | ||
10 years agoptomiak commented on review 15549 for perforce-software-helix-web-services:main I ended up using your submit service everywhere, and looks like its really happy doing that and I reduced the amount of code :) If you could skim thr ...I ended up using your submit service everywhere, and looks like its really happy doing that and I reduced the amount of code :) If you could skim through that would be absolutely brilliant! « | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Fix minor doc typos. | ||
10 years agoptomiak commented on review 15549 (change_service.rb, line 43) for perforce-software-helix-web-services:main This has been added to help with cases when file being saved does not pass validation in git-fusion, the client locks the file so next person in is un ...This has been added to help with cases when file being saved does not pass validation in git-fusion, the client locks the file so next person in is unable to touch it. '-f' flag is brilliant, but it was causing permissions issues when doing stuff as a normal user. @tjuricek - can you bless this change? it doesn't change much, but if its unacceptable could you help me figure out how to handle that problematic scenario from the git-fusion app put and patch? « | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main | ||
10 years agoptomiak commented on review 15549 for perforce-software-helix-web-services:main Yeah, will absolutely use it - it was on my to-do list, after the keys will be 'more-or-less-looking-good'. Thanks, I'll re-add usernames and move stu ...Yeah, will absolutely use it - it was on my to-do list, after the keys will be 'more-or-less-looking-good'. Thanks, I'll re-add usernames and move stuff around a bit. « | ||
10 years agoptomiak commented on review 15549 for perforce-software-helix-web-services:main @tjuricek Could you skim over after the changes to keys? | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main | ||
10 years agoptomiak commented on review 15549 (app.rb, line 34) for perforce-software-helix-web-services:main Better be safe than sorry, thanks for the explanation! | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Rename SSH key endpoints to be consistent in naming, update docs and tests to reflect that. | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Further key endpoint restrictions, change tests and api to only accept requests from user for the same user. Update docs. | ||
10 years agoptomiak committed change 15745 into Second part of shelved changes. Contains updated git-fusion app, changes to string encodig/decoding and updated docs. | ||
10 years agoptomiak committed change 15744 into Unshelve files from review 15549 to my dev branch. | ||
10 years agoptomiak committed change 15741 into Branch HWS for my use. | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Lock down access to other-user's SSH keys based on authenticated user's username. | ||
10 years agoptomiak commented on review 15549 (helix_web_services.rb, line 137) for perforce-software-helix-web-services:main Sorry, local change that was not supposed to go in. | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Forgot to include specs. | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Modify patch method to accept renaming branches. Finish work on repositories. Add couple more tests. | ||
10 years agoptomiak commented on review 15549 (app.rb, line 34) for perforce-software-helix-web-services:main Would you be able to give an example of an array that would break the result.shift result.join approach? I tried investigating a bit with couple of st ...Would you be able to give an example of an array that would break the result.shift result.join approach? I tried investigating a bit with couple of strings and files, and every time the shift+join approach and the content.b approach produced the same results. Seems like a good thing to know, so if you wouldn't mind explaining the pros over the other I would be super happy. « | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Add more docs, rework error handling. Replace configs with JSON representations, modify docs on the matter. | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Combine POST and PUT method into one, further tweaks to error handling. Added docs for keys, modified tests. | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Add more tests, add PATCH method for repositories and some docs. Change the way errors from methods are raised. | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Futher changes to sefvices, add tests | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Futher changes to sefvices, add tests | ||
10 years agoptomiak updated files in review 15549 for perforce-software-helix-web-services:main Futher changes to sefvices, add tests | ||
10 years agoptomiak commented on review 15549 for perforce-software-helix-web-services:main Specs under way :) Thanks for the rest! | ||
10 years agoptomiak commented on review 15549 for perforce-software-helix-web-services:main I just noticed Sync also uses the encoding stuff - maybe git fusion should have its own? | ||
10 years agoptomiak requested review 15549 for perforce-software-helix-web-services:main Add support for repo creation/update and deletion, same for SSH keys. Add util module for supporting methods, modify temp client to dissapear. | ||
Change | User | Description | Created | ||
---|---|---|---|---|---|
15548 | ptomiak | Add support for repo creation/update and deletion, same for SSH keys. Add util module f...or supporting methods, modify temp client to dissapear. « |
10 years ago | View Review |
Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).