| 23 years agoSteve Borrett committed change 1322 into Only submit if we need to, so check "p4 opened" before trying the submit. | |
| 23 years agoSteve Borrett committed change 1321 intoAltered the comments, since they were a bit excessive.
If you really want to see a version with every line of
code fully commented then you should l...ook at the previous
revision. « | |
| 23 years agoSteve Borrett committed change 1269 into Fixed a minor bug in the P4Logger class.
There was an "if" with a
capital "I". | |
| 23 years agoSteve Borrett committed change 1252 intoMoved the logger counter checking to the constructor of the P4Logger
class so that there is less chance of more events occuring before the
counters... value is recorded and the logger reset in the CleanUp() method.
Added the config variable 'alwaysprint'. This will mean that all messages
are always written to STDOUT, even if a log file is specified.
We now write the entire dictionary to the message in the DeleteJob() method
of the P4Job class instead of ignoring the 'code' field. Because, why not...
Finished commenting the code and config variables and did some minor
rearranging of the code layout to make things more obvious and readable. « | |
| 23 years agoSteve Borrett committed change 1202 intoMoved the code which decides what action to take with a job to
a TakeAction() method of the P4Job class.
Added a call to the above function to the... MainLoop() function of
the of the P4Versioner class
Commented the code in the main program body and the P4Versioner
class and it's methods. « | |
| 23 years agoSteve Borrett committed change 1201 intoAdded a "revert" config variable which allows users to either ignore
alterations to jobs by unauthorised users, or revert thier changes to
the previ...ous state.
Reformatted the code to fit in an 80 column screen.
Altered the P4Job.DeleteJob() function to include the job details
in the logged message before the job is deleted from Perforce.
Added + '\n' to the end of the print statement in P4Job.HandleMessage()
to ensure that logged messages always end with a LF.
Made some changes and additions to the comments at the start of the
script. « | |
| 23 years agoSteve Borrett committed change 1082 intoAlter imports to only import required functions.
Alter code to reflect above import changes.
Add config variable "add" to determine the action to... be taken when an
unauthorised user creates a job.
Altered code to reflect the above. « | |
| 23 years agoSteve Borrett committed change 1077 into Reorganisation of code to better reflect class hierarchy.
No functional alterations. | |
| 23 years agoSteve Borrett committed change 1076 intoAn update to ensure all the latest fixes are in the
public depot version of the script, since I am mostly
controling this on my local Perforce server.... « | |
| 23 years agoSteve Borrett committed change 1074 intoDelete original job versioning script and add in the new improved
version 2 script.
This script has vast differences from the original and is now to...tally
class based.
As far as I can tell all of the issues in the original script have
been resolved in this incarnation, including such things as being able
to delete jobs from Perforce. The job file will simply be "p4 delete"ed
and the job itself will be deleted from Perforce. This means that although
there is still no protections possible on being able to delete jobs, there
is a record of what they were prior to their deletion.
One thing to be wary of with this version of the script is that jobs
created by an unauthorised user are currently simply removed from
Perforce and no trace of them exists. This is possibly a little extreme
but for now is the easist solution to implement.
See the to do list at the bottom of the script for things which I am
currently working on for this script. « | |
| 23 years agoSteve Borrett committed change 1073 into Eliminated "script" directory.
Now putting things directly in a Python
directory. | |
| 23 years agoSteve Borrett committed change 1056 intoFixed a bug where the MainLoop() function wasn't handling
unedited jobs correctly. This probably effected the general
job authorisation section of th...e function.
Removed some code added for email notification. Since this isn't
implemented yet, it isn't required and simply confused things.
Also did a bit of syntactic clean up. « | |
| 23 years agoSteve Borrett committed change 1049 intoInitial add of Job Versioning script.
The script header contains more details, but this will basically
add some degree of versioning and protections... to jobs in Perforce
to aid in using the Perforce jobs as a defect tracking mechanism. « | |
