/******************************************************************************* Copyright (c) 2001-2008, Perforce Software, Inc. All rights reserved. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL PERFORCE SOFTWARE, INC. BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. *******************************************************************************/ /******************************************************************************* * Name : p4mergedata.cc * * Author : Tony Smith <tony@perforce.com> or <tony@smee.org> * * Description : Class for holding merge data * ******************************************************************************/ #include <ruby.h> #include "undefdups.h" #include <clientapi.h> #include <i18napi.h> #include <strtable.h> #include <spec.h> #include "extconf.h" #include "p4result.h" #include "p4rubydebug.h" #include "clientuserruby.h" #include "p4mergedata.h" static void mergedata_free( P4MergeData *md ) { delete md; } static void mergedata_mark( P4MergeData *md ) { md->GCMark(); } P4MergeData::P4MergeData( ClientUser *ui, ClientMerge *m, StrPtr &hint ) { this->debug = 0; this->ui = ui; this->merger = m; this->hint = hint; // Extract (forcibly) the paths from the RPC buffer. StrPtr *t; if( ( t = ui->varList->GetVar( "baseName" ) ) ) base = t->Text(); if( ( t = ui->varList->GetVar( "yourName" ) ) ) yours = t->Text(); if( ( t = ui->varList->GetVar( "theirName" ) ) ) theirs = t->Text(); } VALUE P4MergeData::GetYourName() { return rb_str_new2( yours.Text() ); } VALUE P4MergeData::GetTheirName() { return rb_str_new2( theirs.Text() ); } VALUE P4MergeData::GetBaseName() { return rb_str_new2( base.Text() ); } VALUE P4MergeData::GetYourPath() { return rb_str_new2( merger->GetYourFile()->Name() ); } VALUE P4MergeData::GetTheirPath() { return rb_str_new2( merger->GetTheirFile()->Name() ); } VALUE P4MergeData::GetBasePath() { return rb_str_new2( merger->GetBaseFile()->Name() ); } VALUE P4MergeData::GetResultPath() { return rb_str_new2( merger->GetResultFile()->Name() ); } VALUE P4MergeData::GetMergeHint() { return rb_str_new2( hint.Text() ); } VALUE P4MergeData::RunMergeTool() { Error e; ui->Merge( merger->GetBaseFile(), merger->GetTheirFile(), merger->GetYourFile(), merger->GetResultFile(), &e ); if( e.Test() ) return Qfalse; return Qtrue; } VALUE P4MergeData::Wrap( VALUE pClass ) { VALUE md; VALUE argv[ 1 ]; md = Data_Wrap_Struct( pClass, mergedata_mark, mergedata_free, this ); rb_obj_call_init( md, 0, argv ); return md; } void P4MergeData::GCMark() { // We don't hold Ruby objects }
# | Change | User | Description | Committed | |
---|---|---|---|---|---|
#8 | 14682 | Git Fusion |
Git Fusion branch management Imported from Git ghost-of-change-num: 960958 ghost-of-sha1: 005052ae424bd69f426f7209e741ca1c8c3253c7 ghost-precedes-sha1: ad052c71a568ef12165e143a6866ad9ceffbb4a1 parent-branch: None@960958 push-state: incomplete |
||
#7 | 14655 | tony |
Fix crashing bug in P4Ruby when an exception is raised from within the block passed to P4#run_resolve. This happened because the P4::MergeData object was attached to the exception and so survived longer than the resolve process itself. Ruby's exception handling then tries to call P4::MergeData#to_s to format the object as a string, but some of the internal pointers inside the MergeData object (provided by P4Api) have already been deleted. The to_s method tried to access those objects and caused the crash. This change ensures that the MergeData object invalidates its pointers to objects owned by P4Api and passed in with the scope of an individual resolve as soon as that resolve is completed (successfully or otherwise). |
||
#6 | 14636 | jmistry |
Fix binary file resolve Accessing the base_name attribute of a P4::MergeData object resulted in a segmentation fault when resolving binary files. This is because the base file is empty for binary files, and the Name() method invoked on it does not protect itself in case of a NULL value. User visible change, to be documented in the release notes. |
||
#5 | 14629 | jmistry |
Implemented 'action resolve' in P4Ruby. This extends the existing P4MergeData class to support action resolve. Users will need to test the MergeData object passed to the block to determine if the resolve is for content (P4::MergeData#content_resolve?) or action (P4::MergeData#action_resolve?). The attributes available in 'P4::MergeDatamerge' for an action resolve are: merge_action : The action chosen for the merge, can be emtpy yours_action: your action/filetype their_action: their action/filetype type: the type of merge. Can be "Branch resolve", "Filetype resolve", "Delete resolve" "Filename resolve" info: a dictionary with additional information that can vary with the resolve type. Updated unit test to test action resolve. User visible change, to be documented in the release notes for 2012.1. |
||
#4 | 14608 | jmistry |
Add encoding to Strings As part of adding Ruby 1.9 support we need to associate the encoding for Ruby's strings from the server. This approach is similar to Sven's (in changelist 257263), where everything but the 'content' charset was set to 'utf8'. The content charset is picked up from P4CHARSET and this is used to translate any file content. Also disabled the Ruby 1.9 warning for each compile. User visible change to be documented in release notes. |
||
#3 | 14541 | tony |
Copyright notice housekeeping: update all notices to 2008, and correct start date from 1997 to 2001 when P4Ruby was first released from the public depot. No functional change |
||
#2 | 14521 | tony | Update copyright notices in all applicable P4Ruby files. | ||
#1 | 14480 | tony |
Add P4Ruby 1.5944 to main as start-point for the first productized release of P4Ruby |