Swarm - UnstoppableDrew

All Activity Followed Activity Reviews Commits Comments Jobs
	8 years agoUnstoppableDrew requested review 21456 for perforce-software-sdp:dev Save SHELLOPTS and unset nounset if it wasn't set.
	1 comment

	8 years agoUnstoppableDrew commented on review 21159 (backup_functions.sh, line 302) for perforce-software-sdp:dev You could save a little hoop-jumping here by using readlink. OLDBLINK=$(readlink $OFFLINE_DB)
	2 comments

	9 years agoUnstoppableDrew commented on review 20075 (mkrep.sh, line 477) for perforce-software-sdp:dev The sed command added the service user already. Remove the echo, add the \|\| bail to the previous line, and change > $TmpFile to > $GroupSpecFile ... The sed command added the service user already. Remove the echo, add the \|\| bail to the previous line, and change > $TmpFile to > $GroupSpecFile. «
	9 comments

	9 years agoUnstoppableDrew commented on review 20075 (mkrep.sh, line 488) for perforce-software-sdp:dev Change the sed command to this: sed "s:43200:unlimited:g;\$ s/./\t$ServiceUser/" This will replace the last line with tab + username and does away wi ... Change the sed command to this: sed "s:43200:unlimited:g;\$ s/./\t$ServiceUser/" This will replace the last line with tab + username and does away with needing to count lines and such in 489-495. Important to note you need double quotes around the sed expression so the service user name expands, and backslash escape the $ that specifies the line address to sed. «
	9 comments

	9 years agoUnstoppableDrew commented on review 20075 (mkrep.sh, line 278) for perforce-software-sdp:dev Your naming convention for temp files here and a few more, later on, is inconsistent. I would use mktemp to create a temp directory, then put all your ... Your naming convention for temp files here and a few more, later on, is inconsistent. I would use mktemp to create a temp directory, then put all your individual temp files in there. Then you only have to delete the tempdir at the end and don't have to keep track of the list of files. «
	9 comments

	9 years agoUnstoppableDrew requested review 19766 for perforce-software-sdp:dev @tom_tyler @russell_jackson Bug fix for running p4master_run as root, and some comment header cleanup. Job 000543 p4master_run: Preserve original...
	Add a comment

	9 years agoUnstoppableDrew modified job000500 for SDP Guide: inconsistent user name used in setup instructions. Page 9 of the pdf, step 1 says create user 'p4admin'. The rest of the guide that I've re...
	Add a comment

	9 years agoUnstoppableDrew created job000500 for SDP Guide: inconsistent user name used in setup instructions
	Add a comment

No shelved changes.

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default

Check all

I am the author, and
I change the state of a review
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed