Helix SwarmHelix Swarm

thomas_gray

thomas_gray (Thomas Gray)
  • 1
    Followers
  • 0
    Following
  • 8
    Projects
Full Name
Thomas Gray
Email address
tgray@perforce.com
Followers
zaheera569
Projects
  • JamBox
    • Owner, Member
  • ffr-reseed
    • Owner
  • MergeQuestJS
    • Following
  • P4 with biometric authentication
    • Following
  • P4PHP
    • Following
  • Slack
    • Following
  • Slack
    • Following
  • tricks
    • Following
  • Activity
  • Shelves
  • Settings
  • Notifications

  • All Activity
  • Followed Activity
  • Reviews
  • Commits
  • Comments
  • Jobs
9 years agoThomas Gray committed change 20527 into perforce_software-p4:2016-1
Update version information to reflect this specific change number.
Add a comment
9 years agoThomas Gray committed change 20494 into perforce_software-p4:2016-1
Update of p4 source code to 16.1/1429894.
Add a comment
9 years agoThomas Gray modified job000322 for perforce-software-workshop:
Workshop jobs listing should show open jobs only by default, with an option to show closed/obsolete jobs.
1 comment
9 years agoThomas Gray commented on job000322 for

In an effort to make the default use case more valuable, I've updated the job search form to prefill in search for open|inprogress jobs by default. A

...

In an effort to make the default use case more valuable, I've updated the job search form to prefill in search for open|inprogress jobs by default. All jobs can be searched for by blanking the field and submitting the search form.

 «
1 comment
9 years agoThomas Gray commented on job000472 for

Was able to reproduce, with the updated detail. Looks like the javascript that created the edit link was scoped too aggressively and included all lin

...

Was able to reproduce, with the updated detail. Looks like the javascript that created the edit link was scoped too aggressively and included all links in the job footer.

I've updated it to only grab the edit link, as appropriate. Thanks Tom!

 «
2 comments
9 years agoThomas Gray modified job000472 for perforce-software-workshop:
Broken changelist link when viewing WebUI.

See this ULR: https://swarm.workshop.perforce.com/projects/perforce-software-baseline-and-branch-import/jo...bs/job000459

This has a linked changelist; job job000459 is linked to
changelist 18401.

However, if you click the link on the text '18401' for the
changelist, or simply do the "mouse over" thing to see the
target URL, the target URL is the exact same behvaior as for
the "Edit this job." link.  That is to say, it pops up the
WebUI form for editing the job.

That is, the link you get is:
https://swarm.workshop.perforce.com/projects/perforce-software-baseline-and-branch-import/jobs/job000459

But of course the link you expect and want when you click
on '18401' text is:
https://swarm.workshop.perforce.com/changes/18401 «
2 comments
9 years agoThomas Gray edited a comment on job000443 for

Closed, as this was resolved via the internal issue tracker in a previous software update.

Now, the branch path is correct, indicates the lower case r

...

Closed, as this was resolved via the internal issue tracker in a previous software update.

Now, the branch path is correct, indicates the lower case requirements in a highlight colour, and is mostly auto-generated.

 «
1 comment
9 years agoThomas Gray edited a comment on job000443 for

Closed, as this was resolved via the internal issue tracker in a previous software update.

1 comment
9 years agoThomas Gray commented on job000443 for

Closed as is now resolved.

1 comment
9 years agoThomas Gray modified job000443 for perforce-software-workshop:
When editing a project, on the branch subform, the displayed branch path is incorrect - the full project id is used where it should remove the creator... id from the path. «
1 comment
9 years agoThomas Gray modified job000367 for perforce-software-workshop:
Protect table entries for projects occasionally going missing

We had a second case of a protect entry going missing today. We
need to sort out what... is causing it. «
1 comment
9 years agoThomas Gray commented on job000367 for

Development work suspended until we roll out a stable 16.1 server version. Fix requires features present in that release.

1 comment
9 years agoThomas Gray modified job000371 for perforce-software-workshop:
When forking and/or deleting projects, large projects take a very long time without user feedback.
 Implement status indicators or other user n...otification. «
Add a comment
9 years agoThomas Gray archived review 12921 for perforce-software-workshop:main
Update to the Markdown module to include the HTMLPurifier filter library.
 This library's purpose is to filter out potentially malicious rendere...d HTML, and is recommended by the Parsedown developer as method to mitigate XSS issues. «
4 comments
9 years agoThomas Gray commented on job000371 for

Development work suspended until we roll out a stable 16.1 server version. Fix requires features present in that release.

Add a comment
9 years agoThomas Gray modified job000371 for perforce-software-workshop:
When forking and/or deleting projects, large projects take a very long time without user feedback.
 Implement status indicators or other user n...otification. «
Add a comment
9 years agoThomas Gray commented on job000444 for

Due to changing business goals, we will not be implementing this feature.

1 comment
9 years agoThomas Gray modified job000444 for perforce-software-workshop:
Develop a feature where users can merge forked code back to the parent.
1 comment
9 years agoThomas Gray commented on job000320 for

Completed.

1 comment
9 years agoThomas Gray modified job000320 for perforce-software-workshop:
A delete button on the user page when logged in as a Swarm admin.
1 comment
9 years agoThomas Gray commented on job000338 for

Closing - due to changing business goals at Perforce we won't be implementing this feature.

1 comment
9 years agoThomas Gray modified job000338 for perforce-software-workshop:
Get a proper short domain name for short URLs
1 comment
9 years agoThomas Gray modified job000523 for perforce-software-workshop:
Allow users to have a readme.md file in their home path that's rendered on their user page.

Suggested by @trina
Add a comment
9 years agoThomas Gray modified job000523 for perforce-software-workshop:
Allow users to have a readme.md file in their home path that's rendered on their user page.

Suggested by @trina_morrow
Add a comment
9 years agoThomas Gray created job000523 for perforce-software-workshop:
Allow users to have a readme.md file in their home path that's rendered on their user page.
Add a comment
9 years agoThomas Gray modified job000521 for perforce-software-workshop:
.mp4 files must be downloaded and cannot be viewed/played in the browser.

Issue was brought forward by @netapp as they have a mp4 embedded in their r...eadme.md file they'd like to make easier to play. «
Add a comment
9 years agoThomas Gray created job000521 for perforce-software-workshop:
.mp4 files must be downloaded and cannot be viewed/played in the browser.
Add a comment
9 years agoThomas Gray approved review 12921 for perforce-software-workshop:main
Update to the Markdown module to include the HTMLPurifier filter library.
 This library's purpose is to filter out potentially malicious rendere...d HTML, and is recommended by the Parsedown developer as method to mitigate XSS issues. «
4 comments
9 years agoThomas Gray committed change 19035 into thomas_gray-jambox:main
Add default config file with default settings.
 Hostname, outbound email, and tickets will need to be updated when deployed.
Add a comment
9 years agoThomas Gray edited a comment on job000478 for

Apparently this doesn't work, but POSTing directly to the Slack channel does. Looks like it's an issue with Swarm or the module.

3 comments
9 years agoThomas Gray commented on job000478 for

Apparently this doesn't work, but POSTing directly to the Slack channel does.

3 comments
9 years agoThomas Gray modified job000478 for perforce_software-slack:
From user @rtande on the forums:
http://forums.perforce.com/index.php?/topic/4693-slack-integration-for-swarm/

I'm trying the Slack integration f...or Swarm and I think I have everything setup correctly. I'm using the instructions from https://swarm.worksh...software-slack/ but I'm not seeing anything in the Slack channel that I've created to receive updates from Swarm.

I've done the following

- copied across the files mentioned in the instructions to the relevant locations in my Swarm install
- changed the file permissions on the files and directories to ensure that they are writeable and executable as required
- set up the webhook in my Slack channel
- copied that webhook into the settings for the Swarm project that I'm using

I don't see any error messages in my Swarm error log or any POSTs from Swarm to the Slack webhook URL in my Swarm access log.

Any help or pointers gratefully accepted. «
3 comments
9 years agoThomas Gray commented on job000478 for

The install instructions don't match the standard Swarm custom module path for javascript files.
I installed the module according to the readme, then

...

The install instructions don't match the standard Swarm custom module path for javascript files.
I installed the module according to the readme, then checked the <head> tag to verify whether or not the Slack.js file was being loaded, and it wasn't present.
Then, I installed the module's javascript file as swarm/public/custom/Slack/Slack.js and verified that it was now present in Swarm.

Try having the customer install the Slack.js file into swarm/public/custom/Slack/Slack.js

 «
3 comments
9 years agoThomas Gray created job000478 for perforce_software-slack:
From user rtande on the forums:
http://forums.perforce.com/index.php?/topic/4693-slack-integration-for-swarm/

I'm trying the Slack integration fo...r Swarm and I think I have everything setup correctly. I'm using the instructions from https://swarm.worksh...software-slack/ but I'm not seeing anything in the Slack channel that I've created to receive updates from Swarm.

I've done the following

- copied across the files mentioned in the instructions to the relevant locations in my Swarm install
- changed the file permissions on the files and directories to ensure that they are writeable and executable as required
- set up the webhook in my Slack channel
- copied that webhook into the settings for the Swarm project that I'm using

I don't see any error messages in my Swarm error log or any POSTs from Swarm to the Slack webhook URL in my Swarm access log.

Any help or pointers gratefully accepted. «
3 comments
9 years agoThomas Gray edited a comment on job000470 for

Confirmed using vim on mac. Editing the description doesn't remove the ^M characters, so it's not browser-based. Maybe in something that's handling

...

Confirmed using vim on mac. Editing the description doesn't remove the ^M characters, so it's not browser-based. Maybe in something that's handling word-wap for the description?

 «
3 comments
9 years agoThomas Gray modified job000470 for perforce-software-workshop:
Jobs edited with Web UI have Windows line endings.

Jobs edited in The Workshop with the Web UI contain evil
Windows '^M' line endings introduced wh...en using the Web UI.
I'm not sure if it's got anything to do with Windows being
in the mix, but somehow those Windows line endings how up
in the job fields when viewed on Mac/Unix platforms. «
3 comments
9 years agoThomas Gray commented on job000470 for

Confirmed using vim on mac.

3 comments
9 years agoThomas Gray commented on job000470 for

Tom's sent me a screenshot. vim on mac.

3 comments
9 years agoThomas Gray modified job000470 for perforce-software-workshop:
Jobs edited with Web UI have Windows line endings.

Jobs edited in The Workshop with the Web UI contain evil
Windows '^M' line endings introduced wh...en using the Web UI.
I'm not sure if it's got anything to do with Windows being
in the mix, but somehow those Windows line endings how up
in the job fields when viewed on Mac/Unix platforms. «
3 comments
9 years agoThomas Gray edited a comment on job000470 for

Cannot reproduce on either Mac or Ubuntu. Tested using both TextEdit and vim.

What editor are you using and where do you see this character present?

3 comments
9 years agoThomas Gray edited a comment on job000472 for

Could not reproduce this using Chrome, Firefox, or Safari. Tested both unauthenticated and authenticated access.

Try clearing your browser's cached

...

Could not reproduce this using Chrome, Firefox, or Safari. Tested both unauthenticated and authenticated access.

Try clearing your browser's cached data and reload the page.
If that fails, re-open the job with details about your browser and version. A screenshot showing the url when you hover over the link would be great!

 «
2 comments
9 years agoThomas Gray edited a comment on job000472 for

Could not reproduce this using Chrome, Firefox, or Safari. Tested both unauthenticated and authenticated access.

Try clearing your browser's cached

...

Could not reproduce this using Chrome, Firefox, or Safari. Tested both unauthenticated and authenticated access.

Try clearing your browser's cached data and reload the page.
If that fails, re-open the job with details about your browser and version.

 «
2 comments
9 years agoThomas Gray modified job000470 for perforce-software-workshop:
Jobs edited with Web UI have Windows line endings.

Jobs edited in The Workshop with the Web UI contain evil
Windows '^M' line endings introduced wh...en using the Web UI.
I'm not sure if it's got anything to do with Windows being
in the mix, but somehow those Windows line endings how up
in the job fields when viewed on Mac/Unix platforms. «
3 comments
9 years agoThomas Gray commented on job000470 for

Cannot reproduce on either Mac or Ubuntu.

What editor are you using and where do you see this character present?

3 comments
9 years agoThomas Gray commented on job000471 for

Adjusted priority based on our current queue; deprecating existing unused fields is also a viable solution to this feature request.

1 comment
9 years agoThomas Gray modified job000471 for perforce-software-workshop:
Enhance WebUI Job Editing to edit all editable job fields.

The WebUI for The Workshop allows editing some job fields,
but not all of them.  Fo...r example, the DevNotes field does
not appear in the Web UI.  All job fields that can be edited
should be editable through the WebUI. «
1 comment
9 years agoThomas Gray modified job000472 for perforce-software-workshop:
Broken changelist link when viewing WebUI.

See this ULR: https://swarm.workshop.perforce.com/projects/perforce-software-baseline-and-branch-import/jo...bs/job000459

This has a linked changelist; job job000459 is linked to
changelist 18401.

However, if you click the link on the text '18401' for the
changelist, or simply do the "mouse over" thing to see the
target URL, the target URL is the exact same behvaior as for
the "Edit this job." link.  That is to say, it pops up the
WebUI form for editing the job.

That is, the link you get is:
https://swarm.workshop.perforce.com/projects/perforce-software-baseline-and-branch-import/jobs/job000459

But of course the link you expect and want when you click
on '18401' text is:
https://swarm.workshop.perforce.com/changes/18401 «
2 comments
9 years agoThomas Gray commented on job000472 for

Could not reproduce this - works fine for me.

Try clearing your browser's cached data and reload the page.
If that fails, re-open the job with detail

...

Could not reproduce this - works fine for me.

Try clearing your browser's cached data and reload the page.
If that fails, re-open the job with details about your browser and version.

 «
2 comments
9 years agoThomas Gray modified job000361 for perforce-software-workshop:
When adding a branch to a project provide the full (completed) depot path.
 Most of the information is available and as the user types the branc...h name you can auto update the depot path. «
6 comments
9 years agoThomas Gray commented on job000361 for

Cleaning up open jobs - this one's been sorted for a while.

6 comments
Change User Description Created
12920 Thomas Gray [review-12921] Update to the Markdown module to include the HTMLPurifier filter library.
...  This library's purpose is to filter out potentially malicious rendered HTML, and is recommended by the Parsedown developer as method to mitigate XSS issues. «		 10 years ago View Review

Profile Settings

Reset to default

Reviews

Sets default values for how diffs are displayed on all reviews.

Show comments in files
View diffs side-by-side
Show space and newline characters
Ignore whitespace when calculating differences

Time Display

Sets how you would like to display time across Swarm.

Display the time in

Adjust when notifications are sent to you about reviews that you're associated with (as an author, reviewer, project member or moderator).

Email me when:

Reset to default
Check all
I change the state of a review
I am the author, and
a review is requested
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
a review or change is committed
a comment is made on the review or change
a comment on the review or change is updated
Someone likes one of my comments
I am a member, and
a review is requested
a review or change is committed
I am a reviewer, and
files in the review are updated
tests on the review have finished
a vote is cast on a review
the state of the review changes
someone joins or leaves the review
a review or change is committed
a comment is made on the review
a comment on the review is updated
I am a moderator, and
files in the review are updated
tests on the review have finished
a review or change is committed